Commit Graph

17 Commits

Author SHA1 Message Date
Michal Čihař
93d1924179 Fix name of Advisor::byTime
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-05-15 09:44:58 +02:00
Michal Čihař
1c70ed49cb Move advisor helpers to the Advisor class
They no longer need to pollute global namespace as they are used only in
context of ExpressionLanguage.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-05-15 09:44:01 +02:00
Michal Čihař
f13476f454 Replace eval() by Symfony\ExpressionLanguage
This is already used by motranslator, so it doed not bring extra
dependency and we get rid of the eval() call.

Fixes #6363

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-05-15 09:44:01 +02:00
Michal Čihař
17f0af836f Merge branch 'QA_4_6' 2016-10-18 13:40:47 +02:00
Michal Čihař
4c52592fe3 Correctly localize message
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-10-18 13:40:25 +02:00
Michal Čihař
b20fd43aaf Document TODO for Advisor
See #6363

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-10-13 13:27:40 +02:00
Deven Bansod
dd34ca8512 Merge branch 'QA_4_6' 2016-08-26 00:08:02 +05:30
Deven Bansod
96f5f101cc Add error checking in reading the advisory_rules file
If the file does not exist or if it is not readable by PHP, it can return FALSE.
In such cases, we should print a user-friendly message and return from parsing the rules file.

Fix #12476

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-08-26 00:01:15 +05:30
Michal Čihař
46b329c32b Merge branch 'QA_4_6' 2016-08-18 17:37:34 +02:00
Michal Čihař
6faa1fe46a Add rel="noopener noreferrer" to all external target="_blank" links
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-18 17:35:20 +02:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
e1dd0a9f97 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-18 22:51:01 +02:00
Hugues Peccatte
c752c01309 Merge branch 'master' into useNamespaces_master 2015-09-27 20:50:19 +02:00
Hugues Peccatte
1b6ac482d8 Merge branch 'master' into useNamespaces_master 2015-09-26 22:53:58 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00