gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,953 Commits 12 Branches 481 Tags 2.4 GiB
eaad8d8a1c
Commit Graph

61 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b0604623d8
Extract PageSettings dependency from controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-06 20:17:34 -03:00
Maurício Meneghini Fauth
95ae4f7612
Extract Config\PageSettings initialization from constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-06 16:37:40 -03:00
Maurício Meneghini Fauth
b50b80da02
Fix Table\StructureControllerTest failing test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-13 22:07:44 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 11:44:01 -03:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Maurício Meneghini Fauth
aa119f7e62 Remove unused Config::$defaultServer property 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-30 13:23:27 -03:00
Kamil Tekiela
357680474e Memoize Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-04 11:59:29 +01:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
6735938f12 Remove dependancy in Table/StructureController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-16 20:58:48 +00:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down 
The idea is to only load the DBI when needed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
c8cd855fc8
Add basic test for Table\SqlController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-22 14:45:35 -03:00
Maurício Meneghini Fauth
99b0604739
Add basic test for Table\StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 21:54:42 -03:00
Maurício Meneghini Fauth
fb257e5922
Extract actions from Table\StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-09 13:48:07 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
5b2957bdc1
Add a redirection after dropping a column 
Instead of loading the page in the same action, redirect to the table
structure page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 11:24:12 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit 
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:25:34 +01:00
William Desportes
50e900a1bf
Remove all @test annotations 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-08 23:01:26 +01:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
Petr Duda
1086b2a6ee Fix #12961 Indexes shown at both tbl_structure and tbl_relation 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-09-13 19:31:59 +02:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes 
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
 2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 18:30:57 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true} 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 02:12:36 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:45:50 +02:00
William Desportes
bb0bc3bb93
Merge #16131 - Unit test suite improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 23:32:11 +02:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-21 15:29:36 -03:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action 
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 11:21:42 -03:00
William Desportes
947f9ad04f
Remove some unused code detected by codacy 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:57:22 +02:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00