Commit Graph

5037 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
4b1593bc1f
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-30 11:51:53 -03:00
Maurício Meneghini Fauth
ee9c9a0300
Merge pull request #18297 from kamil-tekiela/measure-time-only-for-user-queries
Measure time only for user queries
2023-03-30 10:23:36 -03:00
Maximilian Krög
c5343eeed9 Fix gis extent calculation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-29 21:14:40 -03:00
Kamil Tekiela
ef0ea05a8f Measure time only for user queries
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-30 00:41:38 +01:00
Liviu-Mihail Concioiu
d9e0b9d7e7
Fix move columns (#18271)
Fix #18232 - Fix issues when moving a column

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-29 17:23:52 -03:00
Maurício Meneghini Fauth
d25780fe20
Merge pull request #18255 from kamil-tekiela/Fix-ENGINE-escaping
Fix ENGINE escaping
2023-03-29 17:04:17 -03:00
Kamil Tekiela
2b922018f7
Add native param types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-29 16:42:43 -03:00
Maurício Meneghini Fauth
46df80f58f
Merge pull request #18281 from kamil-tekiela/getTrackingIcon
Optimize getTrackingIcon
2023-03-29 14:14:39 -03:00
MoonE
03db39aea7
Fix editing new values with gis editor (#18219)
* Test editing empty wkt string

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* gis editorfixed inserting of empty values initially

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-28 21:47:39 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
52c14a1911
Fix wrong global variable name
Introduced by 437215cab2

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 12:42:13 -03:00
Maurício Meneghini Fauth
fbbbebf6e2
Fix wrong global var name
Introduced by 437215cab2

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 23:14:41 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
40cc4a0dee
Fix merge issue
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 13:37:27 -03:00
Maurício Meneghini Fauth
6a183e3488
Merge pull request #18291 from kamil-tekiela/Fix-param-type-in-setUserValue
Fix param type in setUserValue
2023-03-26 09:45:27 -03:00
Kamil Tekiela
7c53199702
Fix merge issues (#18289)
* Fix type issues after merge

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update DbiDummy.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-25 22:53:14 -03:00
Maurício Meneghini Fauth
802d8f13b6
Merge pull request #18203 from kamil-tekiela/first-class-callable
Use first class callables
2023-03-25 15:16:07 -03:00
Kamil Tekiela
266f69ffb6 Fix param type in setUserValue
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-25 13:57:54 +00:00
Maurício Meneghini Fauth
8972c0ec22
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-24 18:15:47 -03:00
Maurício Meneghini Fauth
0301e48a27
Add ChangeLog entry for #17702
- Closes #17702

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-24 16:35:15 -03:00
Nicolas Hervouet
e4d9a1a66a
Fix for handle large number of tables in a single database (more than 10k)
getTablesFull was taking too much time, because MySQL do not have a real table where it stores all tables information.
So when it runs a query like select * from information_schema.TABLES ORDER BY Name limit 250 offset 0, MySQL has to read information about all tables to build his in memory table, then sort it by name, and then return 250 first tables.
But reading information about one table takes time, and that's why the query is very slow when you have a lot of tables.
Note that the problem is the same with 'SHOW TABLE STATUS'.

So, in order to speed up this query, we have to limit it to a small list of tables, as it, MySQL has to read table information only for few tables.
Note that SHOW TABLES is not that long, even with a large amount of tables.

The idea here is to use the result of SHOW TABLES query, to apply paging on this table list, and then to run the query on information_schema.TABLES only on tables we want.

Signed-off-by: Nicolas Hervouet <github@pico12.fr>
2023-03-24 11:55:30 -03:00
Kamil Tekiela
b5ae50454d Optimize getTrackingIcon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 13:07:22 +00:00
Kamil Tekiela
d698bdf80a Create DeleteLinkEnum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 12:55:24 +00:00
Kamil Tekiela
6b7286ff26 Add readonly for DisplayParts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 11:52:52 +00:00
Kamil Tekiela
4feeeb0c89 Add @psalm-return
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 10:14:56 +00:00
Kamil Tekiela
fa5cb8adf3 Refactor getBulkLinks
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 10:11:23 +00:00
Maurício Meneghini Fauth
6570089044
Merge pull request #18284 from MauricioFauth/config-overrides
Remove the _overrides key of the ConfigFile::$cfgDb
2023-03-21 18:23:32 -03:00
Maurício Meneghini Fauth
f243cf5b24
Remove templates/server/select/server_options.twig
Merges it with the templates/server/select/index.twig template.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-21 14:29:53 -03:00
Maurício Meneghini Fauth
9d19822fff
Remove the _overrides key of the ConfigFile::$cfgDb
It's always empty. It was introduced by 5c658310aa
and its last usage was removed by 2a8962aa95

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-21 11:06:18 -03:00
Maurício Meneghini Fauth
b836ace0f1
Merge config.values.php with ConfigFile class
This file is only used by the ConfigFile class, so makes sense to this
information to be inside the class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-20 21:26:37 -03:00
Maurício Meneghini Fauth
c7855f6e95
Create the PhpMyAdmin\Replication namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-20 14:16:01 -03:00
Kamil Tekiela
8550db2d11 Don't parse SQL if no tracking is in progress
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-20 16:24:35 +00:00
Maurício Meneghini Fauth
4d612b0175
Merge pull request #18279 from kamil-tekiela/fix-param-issues
Fix param type issues
2023-03-19 19:29:35 -03:00
Maurício Meneghini Fauth
e66aaf482a
Fix some type errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-19 19:08:02 -03:00
Kamil Tekiela
4e229445d9 Fix #18278
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-19 21:56:01 +00:00
Kamil Tekiela
74c48a499b Fix error in normalization
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-19 21:56:01 +00:00
Kamil Tekiela
691bf444c3 Fix #18277
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-19 10:07:04 +00:00
Kamil Tekiela
fce745a874 Fix #18275
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-19 10:04:49 +00:00
Kamil Tekiela
67cc2be2a0 Use TableName instead of string
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
938dd6f7f8 Remove getSqlResultForSelectableTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
924fcc79f9 Refactor logic for getting Tracking status
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:21 +00:00
Kamil Tekiela
ebbf2e8d01 Remove unused params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:34 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:32 +00:00
Maurício Meneghini Fauth
f13bd41bac
Merge pull request #18247 from kamil-tekiela/Native-param-types
Native param types
2023-03-17 17:52:45 -03:00
Kamil Tekiela
8a5ce0b557 Split long lines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:48:12 +00:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:47:43 +00:00
Kamil Tekiela
3774c29604 Fix implicit nulls
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb Add native param types
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:45:18 +00:00