Commit Graph

176 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
10e1a848ed
Add support for theme color modes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-13 23:28:29 -03:00
Maurício Meneghini Fauth
865c46e320
Move Theme and ThemeManager into the Theme namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-13 10:25:48 -03:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143)
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
d5b068b8e3
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 19:32:32 -03:00
William Desportes
4ce69f3a3d
Nicely exit in case of an early PHP type crash
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:51:21 +01:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 17:03:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-12 21:31:04 +00:00
Kamil Tekiela
7e5d96b559 Use DI for UserPreferences
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-10 16:23:34 -03:00
Maurício Meneghini Fauth
7cde53ed0d
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-09 18:41:44 -03:00
Maurício Meneghini Fauth
dfd5f13078
Fix some errors detected by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-05 16:27:20 -03:00
Maurício Meneghini Fauth
cdc2f37a1d
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-03 19:38:50 -03:00
William Desportes
19c4657f39
#17999 - Remove modals from the login page
It shows weird buttons

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-30 15:52:16 +04:00
Kamil Tekiela
6264f6f1ea
Various refactorings 2 (#17965)
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-24 12:54:23 -03:00
Maurício Meneghini Fauth
ab96edf359
Extract Navigation object dependency from CommonParams
This removes a circular dependency.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-14 20:08:58 -03:00
Maurício Meneghini Fauth
9546a45e98
Revert "Move menuResizer related functions to menu-resizer.js"
That commit broke the onload and teardown calls.
Reverting fixes the tests.

This reverts commit 5e6541e08a.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-04 15:15:44 -03:00
Maurício Meneghini Fauth
5e6541e08a
Move menuResizer related functions to menu-resizer.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-01 23:17:33 -03:00
Maurício Meneghini Fauth
83e8ed59cc
Remove Config object from the Window global object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-30 22:00:29 -03:00
Maurício Meneghini Fauth
49865fe647
Remove Indexes object from the Window global object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-29 14:39:16 -03:00
Maurício Meneghini Fauth
b7a710e83f
Remove common.js from Header::addDefaultScripts()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-29 14:17:04 -03:00
Maurício Meneghini Fauth
caf19897ac
Remove crossFramingProtection from the Window global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-28 23:43:35 -03:00
Maurício Meneghini Fauth
332e27ad39
Remove KeyHandlerEvents from the Window global object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-28 23:11:13 -03:00
Maurício Meneghini Fauth
479f10289f
Remove the Navigation object from the Window global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-28 22:29:13 -03:00
Maurício Meneghini Fauth
2e001c186a
Remove PageSettings from the window object
Imports PageSettings in the main.js file instead of relying on the
global window object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 22:00:56 -03:00
Maurício Meneghini Fauth
b2971d618f
Import the AJAX object where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 15:21:18 -03:00
Maurício Meneghini Fauth
3ce84326f2
Import the Functions object where possible
Instead of using from the Window global object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:43:25 -03:00
Maurício Meneghini Fauth
6f54621b41
Create a shared.js file for common JS dependencies
Instead of using the Webpack's dependOn setting, uses the splitChunks
setting to automatically generate the shared.js file.

As the contents of these shared dependencies are being moved to the
shared.js file, the generated file for each dependency is now empty.

Is probably safe to not generate them, but some adjustments are needed
for that first. For example, the AJAX's onload and teardown functions
expects that some of these files exists.

For now, only dependencies that are loaded for all pages should be added
in this shared.js file.

This will facilitate the refactoring of the JS files, but the trade off,
at least for now, is that will be a single large file instead of a few
medium ones.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:43:24 -03:00
Maurício Meneghini Fauth
df23516145
Reorder JS scripts loading in Header class
First load vendor scripts, then load the Messages, then the other
scripts.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-23 15:57:06 -03:00
Liviu-Mihail Concioiu
b343e16814 Fix filename
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-10-30 08:44:30 +01:00
William Desportes
ea5a541f7b
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-29 17:26:44 +02:00
William Desportes
12b76bb46f
Fix #17842 - Use jquery.validate.min.js (24 KB) instead of jquery.validate.js (50 KB)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-29 14:59:05 +02:00
William Desportes
29c54c250e
Use jquery-migrate.min.js (14kB) instead of jquery-migrate.min.js (31kB)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-26 17:28:09 +02:00
Kamil Tekiela
270ad693eb Replace uses of escapeJsString with json_encode
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:28:56 +01:00
Maurício Meneghini Fauth
d7e1dd7206
Extract Console dependencies from constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-20 15:52:06 -03:00
Maurício Meneghini Fauth
87d695f2c8
Extract js/messages.php entry point into a route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-06 22:25:32 -03:00
Maurício Meneghini Fauth
431b594ec3
Change doclinks.js to use JS modules
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-05 15:47:12 -03:00
Maurício Meneghini Fauth
4e19a88a1e
Extract Webpack runtime to the runtime.js file
This is needed since it has multiple entry points per page.

https://bundlers.tooling.report/code-splitting/multi-entry/

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-02 14:50:52 -03:00
Maurício Meneghini Fauth
ef299ea809
Extract side effects from page_settings.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-30 02:01:21 -03:00
Maurício Meneghini Fauth
f7379a6a2b
Extract side effects from common.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-30 01:33:05 -03:00
Maurício Meneghini Fauth
76e72d7ad5
Extract side effects from indexes.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-30 01:24:04 -03:00
Maurício Meneghini Fauth
ac55dab1eb
Extract side effects from navigation.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-30 00:51:13 -03:00
Maurício Meneghini Fauth
9c09feb78d
Extract side effects from the functions.js file
And some minor code style changes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-29 23:30:52 -03:00
Maurício Meneghini Fauth
3feb1f73f1
Extract side effects from config.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-28 01:46:24 -03:00
Maurício Meneghini Fauth
3560dcfdd4
Extract cross_framing_protection.js side effect into main.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-28 01:39:52 -03:00
Maurício Meneghini Fauth
4a30c8ccbd
Extract keyhandler.js side effects into main.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-28 01:39:51 -03:00
Maurício Meneghini Fauth
bdbf82b11f
Extract ajax.js side effects into main.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-28 01:39:51 -03:00
Maurício Meneghini Fauth
78b2c1f4eb
Extract function from cross_framing_protection.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-26 13:31:49 -03:00
Maurício Meneghini Fauth
7403cffab4
Assign CommonParams and CommonActions to the window object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-22 15:04:03 -03:00
Maurício Meneghini Fauth
d668e331b5
Remove jquery-debounce-throttle JS dependency
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-11 16:21:53 -03:00