Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Kamil Tekiela
3ecf14df34
Fixing erroneous params
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:47:43 +00:00
Kamil Tekiela
3774c29604
Fix implicit nulls
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb
Add native param types
...
Includes TypeHints.UnionTypeHintFormat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:45:18 +00:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Kamil Tekiela
e8c5eef6f8
Remove annoying empty statements ( #18114 )
...
* Remove annoying empty statements
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Make $extra strict and stop passing false to it
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Make $page strict and stop passing null
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-24 20:11:37 -03:00
Kamil Tekiela
f874bf1d99
Remove generateRowQueryOutput() method
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 14:45:59 +00:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
...
Since union type are now possible, using union with null makes more
clear that it is a union type.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Kamil Tekiela
cfe54a501b
Add union types
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-15 15:23:28 +00:00
Kamil Tekiela
67fbb4011d
Remove dead code in Navigation ( #17969 )
...
* Remove temporary variable $node
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify Generator::getNavigationLink
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-10 16:07:11 -03:00
Maurício Meneghini Fauth
3d4aea922c
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-19 00:08:39 -03:00
Daniel Kesselberg
79eacd6040
fix: remove analyze explain button
...
The service mariadb.org/explain_analyzer is unavailable.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-01-17 17:14:38 +04:00
Kamil Tekiela
6264f6f1ea
Various refactorings 2 ( #17965 )
...
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-24 12:54:23 -03:00
Maurício Meneghini Fauth
e6f8623e1f
Merge pull request #17921 from kamil-tekiela/like
...
Clean up LIKE escaping
2022-11-30 14:27:14 -03:00
William Desportes
69768f15e1
Fix #17632 - Login Page: Tab keypress to Text Fields
...
Closes : #17633
Fixes : #17632
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-25 22:17:26 +01:00
Kamil Tekiela
dd699f348d
Clean up LIKE escaping
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-25 00:06:52 +00:00
Maurício Meneghini Fauth
4044c3bc3c
Remove unnecessary global variable 'data'
...
Replaces it with a regular varible.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-06 13:22:46 -03:00
William Desportes
25c13d667b
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-26 12:22:38 +02:00
Mo Sureerat
aeab8a1c41
Fix #17793 - insert UUID ( #17797 )
...
* Add/Change table schema - Add UUID in default options
* Insert/Update - Generate uuid only not defined and not check null option
* Add/Change table schema - Hide UUID from default options if database not support & add unit test
Fix #17793
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-20 15:57:53 -03:00
Kamil Tekiela
c9e6767850
Refactor linkOrButton
...
Warning: there are no tests and this part seems to be unused.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:31:04 +01:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
059705f06e
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 19:53:54 -03:00
Liviu-Mihail Concioiu
5dc0daaa45
Add the links from "Server variables and settings" to the url system ( #17768 )
...
Fixes #17178
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-10-11 14:41:07 -03:00
Maurício Meneghini Fauth
75cf045fa3
Extract url.php entry point into a route
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-06 15:02:49 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
...
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Isaac Bennetch
985912f58f
Fix merge conflicts from security branch
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
7dde0d019f
Fix Generator::linkOrButton issue after merge
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 20:11:54 -03:00
Maurício Meneghini Fauth
02e8588404
Merge branch 'QA_4_9-security' into QA_5_1-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 18:39:23 -03:00
Kamil Tekiela
a4b2d7e524
Deimplement fetchRow() helper
...
This helper isn't needed anymore.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 22:44:53 +00:00
Kamil Tekiela
47a039d70c
Implement ResultInterface & MysqliResult
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method
...
Now, it returns last error message or an empty string instead of false
if no errors occurred.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
45cea7319b
Extract the HTML from Generator::getListNavigator
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-21 15:55:33 -03:00
Maurício Meneghini Fauth
857a9d3337
Remove unnecessary @var annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-18 12:15:30 -03:00
Maurício Meneghini Fauth
220ed30ef8
Remove printview.css theme files
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-31 17:35:55 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
William Desportes
1c9c4b183a
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-20 02:45:54 +02:00
Maximilian Krög
93c8a9e505
Fix inserting spatial data
...
Fix inserting geometries with MySQL < 5.6
Fix wkb functions for inserting
Fix selecting default function in insert form
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2021-08-14 20:12:14 +02:00
Maximilian Krög
037c4c45bf
Remove useless code
...
Extracted from pull-request #17074 by myself (@williamdes).
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2021-08-14 14:42:13 +02:00
William Desportes
ef84f770d1
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 00:02:00 +02:00
William Desportes
a36dd1126b
Fix #17006 - Disable the URL limit for the MariaDB analyser feature
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 21:32:56 +02:00
William Desportes
e6e496f67b
Code improvements for Html/Generator::getSupportedDatatypes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 15:52:13 +02:00
Fawzi E. Abdulfattah
9954c47577
Fix #16138 - ignore the length of integer types, and show a warning
...
Fixes : #16138
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 15:42:57 +02:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
bcdb7e40fb
Replace strncmp === 0 with str_starts_with
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 19:14:30 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
4cc034ef66
Fix PhpMyAdmin\Html\Generator doc block issue
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 17:03:02 -03:00