gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,261 Commits 12 Branches 481 Tags 2.4 GiB
eb07bb575d
Commit Graph

54 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Kamil Tekiela
555c6798eb Add native param types 
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
William Desportes
110b609e92
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 20:35:10 +01:00
Mo Sureerat
a36ee101e7 [ISSUE-17793] Remove unreachable condition 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-04 01:23:33 +07:00
Mo Sureerat
8929288efd [ISSUE-17793] Add more test for coverage 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-04 00:33:41 +07:00
Mo Sureerat
250be6adbc [ISSUE-17793] Fix static analysis warning 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 22:57:07 +07:00
Mo Sureerat
afd568e889 [ISSUE-17793] Revert previous change + Fix default selection of uuid in alter table 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 05:11:19 +07:00
Kamil Tekiela
2c416128e5 Pass as argument to Table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 22:30:33 +01:00
Maurício Meneghini Fauth
59b8f31a83
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-16 02:05:39 -03:00
William Desportes
6a69face6c
Fix PHP 8.2: ${var} deprecated string interpolation syntax 
Ref: https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated

Left over to patch:
- libraries/classes/Git.php#L397
- libraries/classes/Database/Qbe.php#L878
- libraries/classes/Database/Qbe.php#L879

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-07-13 11:14:20 +02:00
Maurício Meneghini Fauth
01ae38266a
Add basic test for Table\ColumnsDefinition class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-25 14:21:04 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-09 22:25:58 +00:00
Kamil Tekiela
ce527035c2 PHPStan checkAlwaysTrueCheckTypeFunctionCall fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 15:26:52 +00:00
Kamil Tekiela
f446e6da88 Remove unused variables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 15:12:56 +00:00
Kamil Tekiela
488e7cb5bf Use array_keys whenever only keys are needed in foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-11-29 20:37:39 +00:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
78c266d98f
Move partition classes to the Partitioning namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-21 14:01:25 -03:00
Fawzi E. Abdulfattah
9954c47577
Fix #16138 - ignore the length of integer types, and show a warning 
Fixes: #16138

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-13 15:42:57 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
aaaff9c307
Extract some compatiblity checks into the Query\Compatibility class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 21:02:50 +02:00
William Desportes
d99da46f7a
Move isVirtualColumnsSupported to Query\Compatibility and simplify the code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:31:38 +02:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
5e17787c15 Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-20 12:05:24 -03:00
Maurício Meneghini Fauth
0e5d9535e6 Remove columns_definitions/transformation template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-17 17:56:07 -03:00
Maurício Meneghini Fauth
858e8dc666 Extract template render from ColumnsDefinition::displayForm 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 17:21:36 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-08 18:20:48 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00