gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,984 Commits 12 Branches 481 Tags 2.4 GiB
eb3703882b
Commit Graph

48 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
3d3010916e
Fix an issue reported by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-21 17:31:03 -03:00
Maurício Meneghini Fauth
2c5143feda Remove ResponseRenderer::getFooter method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-09 12:32:14 -03:00
Maurício Meneghini Fauth
0d4d2a4935
Add exceptions for invalid identifier names 
- Adds the PhpMyAdmin\Dbal\InvalidIdentifierName exception
- Adds the PhpMyAdmin\Dbal\InvalidDatabaseName exception
- Adds the PhpMyAdmin\Dbal\InvalidTableName exception

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-19 17:35:35 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
7aec65222a
Fix an issue reported by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-28 12:21:11 -03:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00
Kamil Tekiela
47e81a5161 Remove $route global 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-27 11:47:40 +00:00
Kamil Tekiela
ef6dbe05ec Implement Common::getRequest() to remove global 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-27 11:42:39 +00:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
ca91eaeb38
Accept mixed for DatabaseName and TableName constructors 
This avoids redundant type assertions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-23 16:25:05 -03:00
Maurício Meneghini Fauth
995ec44d13
Move DatabaseInterface::initRelationParamsCache method to Relation class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
9e2bb1e996
Replace Assert exceptions with a more specific one 
Catches only \Webmozart\Assert\InvalidArgumentException instead of all
\InvalidArgumentException.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-09 14:50:25 -03:00
Maurício Meneghini Fauth
0c781c9335
Rename TableName|DatabaseName create method to fromString 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 22:14:51 -03:00
Maurício Meneghini Fauth
88b48c810d
Use ServerRequest for Table\Partition controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 16:56:34 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
a1113b282f
Use DatabaseName and TableName to validate db and table values 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-23 21:51:07 -03:00
Maurício Meneghini Fauth
f61d3183fb
Inline some phpcs ignores and remove deprecated annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-12 11:59:39 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method 
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-02 13:20:50 -03:00
William Desportes
b72f941167
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-23 20:35:42 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
519533a202
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-07 14:19:49 -03:00
Maurício Meneghini Fauth
262cbe45b9
Move some Core methods to Common class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 16:52:54 -03:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
c11e8d5f64 Remove Common::database method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:56:58 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
3c49539a98 Extract db collation handler from Common class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
36d93cf2f9 Remove Common::table method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
6b81080127 Remove Common::server method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-08 13:32:25 -03:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities 
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:42:53 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
William Desportes
cfc17e56ea
Fix some potential bugs after my last commit 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 01:43:57 +02:00
Maurício Meneghini Fauth
82db7444c3 Extract db_table_exists.inc.php to DbTableExists class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-02 17:01:26 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code 
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0 Refactor database pages common code 
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
a1bcb9f0f3 Refactor server pages common code 
Extracts server_common.inc.php code to the Common::server() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00