Commit Graph

80 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e7487227e5
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-06 17:07:13 -03:00
Andrija Vučinić
c6bb867787 Revert to old behavior for ShowServerInfo
Seems we changed the flag behavior here: cd1b8a9b77 (diff-bb8d8aecc2e174245e8b95be9344176aba8971d024f3b2c2311b8e58ddd59b31L149)

I'm not sure whether that was intentional, but it causes the `Database server` panel to always show compared to pre 5.2.0.

Truth be told, it doesn't make sense to have that flag and then the additional checks in the block when we know it's `true`, so I updated the code to take care of that.

Signed-off-by: Andrija Vučinić <andrija.vucinic@gmail.com>
2022-05-11 22:57:55 +02:00
Maurício Meneghini Fauth
c5611531c0 Remove trigger_error calls from HomeController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-30 22:13:54 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-09 22:25:58 +00:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
9adce40034
Extract controllers from HomeController
Extracts CollationConnectionController, GitInfoController and
RecentTablesListController controllers from HomeController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-05 00:40:18 -03:00
Maurício Meneghini Fauth
2de0a7cbd7
Update Psalm baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-28 12:11:52 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-22 15:14:24 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-11 01:20:20 +02:00
William Desportes
ef758ae43d
Merge #16855 - Replace secure.php.net with www.php.net and remove Polish and Persian
Pull-request: #16855

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-10 23:30:25 +02:00
William Desportes
9487604a42
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-28 02:12:17 +02:00
William Desportes
34f8295b94
Fix #16854 - Undefined index: SERVER_SOFTWARE
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-27 23:57:30 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
f19a3d95c4
Remove LanguageManager::getSelectorDisplay method
Redesign the language selector to use Bootstrap style.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-22 15:51:26 -03:00
William Desportes
187ef65d26
Extract some logic from HomeController::checkRequirements into smaller functions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 22:27:58 +02:00
Maurício Meneghini Fauth
7ba3e3db9e
Fix possible null arg when creating a new Git object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-25 14:18:45 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 19:39:28 -03:00
William Desportes
84ede575e3
Remove dependency on Config class of Git class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-24 18:29:52 +01:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
William Desportes
b5263d44c8
Replace PMA_MAJOR_VERSION by Version::SERIES
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-05 21:22:42 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
12d662baa3
Replace themes preview popup with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-04 23:21:31 -03:00
Maurício Meneghini Fauth
17a01d9d9d
Extract the HTML from ThemeManager::getHtmlSelectBox
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 22:34:01 -03:00
William Desportes
2141d81e7e
Fix #16520 - $cfg['ShowDatabasesNavigationAsTree'] = false; on select not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 14:35:05 +01:00
Maurício Meneghini Fauth
6b81080127 Remove Common::server method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e6ec9df84e Remove DBI dep from Controllers/AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
461cc87521 Remove list templates
- templates/list/item.twig
- templates/list/unordered.twig

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 20:43:55 -03:00
Maurício Meneghini Fauth
4821b45ef8 Return commit info in Git::checkGitRevision method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-30 03:23:08 -03:00
Maurício Meneghini Fauth
7486e99568 Extract HTML from Git::getHtml method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-30 01:33:34 -03:00
Maurício Meneghini Fauth
65c93872f0 Remove Display\GitRevision class
Move display method to Git class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 22:50:49 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
585ae508eb
Move out of Config Class all Git methods
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 15:18:45 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 20:15:42 -03:00
Maurício Meneghini Fauth
cd009f8ede Use Bootstrap list group for the home page lists
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-14 16:27:30 -03:00