Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest
...
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-06 23:36:57 -03:00
Rodrigo Pokemaobr
556804c4e2
Removing get tables from twig template and removing relationextension from twig template
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-31 16:22:46 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-27 16:25:39 -03:00
Maurício Meneghini Fauth
6201c7f2ba
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-27 13:27:59 -03:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive
...
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-24 21:35:30 -03:00
Rodrigo Pokemaobr
547f89996f
Removing Foreign Data from Twig
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 16:17:04 -03:00
Rodrigo Pokemaobr
d5585c3104
Removing search columns in foreigners from twig
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 15:34:55 -03:00
Rodrigo Pokemaobr
228fde03ee
Removing get display field function on twig template
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 14:38:49 -03:00
Maurício Meneghini Fauth
dc7090386b
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-21 16:51:47 -03:00
Maurício Meneghini Fauth
9e4f3833a5
Fix Table\OperationsController failing test
...
The Partition::getPartitionNames method returns [0=>null] when no
partitions were found.
Related to 346d6c7981 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-21 16:35:36 -03:00
Maurício Meneghini Fauth
4c12e7a5f9
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 20:58:48 -03:00
Maurício Meneghini Fauth
346d6c7981
Fix error in table operation page when partitions are broken
...
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17496
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 20:52:55 -03:00
Maurício Meneghini Fauth
9931600c4d
Fix coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-18 22:57:44 -03:00
Rodrigo Pokemaobr
272725f86e
Adjusting the lint in files
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 18:02:26 -03:00
Rodrigo Pokemaobr
5ce4fe0b49
Removing foreign dropdown from twig functions
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 16:35:35 -03:00
Maurício Meneghini Fauth
9550066810
Introduce the ServerRequest object to AddFieldController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-04 15:55:22 -03:00
Maurício Meneghini Fauth
6dc859cbc2
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-28 15:56:18 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency
...
This polyfill is not needed anymore.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
b008cca95d
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-26 21:20:06 -03:00
Maurício Meneghini Fauth
04f3f5a4b6
Merge branch 'QA_5_1' into QA_5_2
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-26 21:03:20 -03:00
Maurício Meneghini Fauth
5d80594341
Remove jQuery SVG JS dependency
...
Removed by https://github.com/phpmyadmin/phpmyadmin/pull/17041 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-24 20:39:12 -03:00
Maurício Meneghini Fauth
62683a0115
Add method to AbstractController to send error messages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-20 16:39:33 -03:00
Maurício Meneghini Fauth
0d4d2a4935
Add exceptions for invalid identifier names
...
- Adds the PhpMyAdmin\Dbal\InvalidIdentifierName exception
- Adds the PhpMyAdmin\Dbal\InvalidDatabaseName exception
- Adds the PhpMyAdmin\Dbal\InvalidTableName exception
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-19 17:35:35 -03:00
Maurício Meneghini Fauth
619d4acb4a
Refactor DropColumnConfirmationController class
...
- Removes global variables
- Redesigns the HTML to use Bootstrap styles
- Add more tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-18 15:36:07 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
...
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
40135c26cc
Add basic test for Table\DeleteRowsController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-25 16:44:49 -03:00
Maurício Meneghini Fauth
687a83923a
Add basic test for Table\GetFieldController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 12:54:43 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
1cac3baeab
Fix create index form accepting too many columns
...
- Fixes #16769
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-20 13:11:30 -03:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers
...
Replaces them with their respective globals.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-02 14:48:43 -03:00
Maurício Meneghini Fauth
87f8ece01d
Deprecate the db and table properties from controllers
...
The database and table parameters should be got from the server request
or from the respective globals.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 20:51:03 -03:00
Maurício Meneghini Fauth
8529de4d88
Merge pull request #17303 from kamil-tekiela/Remove-globals
...
Remove globals
2022-01-28 16:47:16 -03:00
Maurício Meneghini Fauth
a8d514a350
Remove db and table globals from DbTableExists class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 16:43:48 -03:00
Kamil Tekiela
47e81a5161
Remove $route global
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-27 11:47:40 +00:00
Kamil Tekiela
86031d2bf6
Deimplement fetchAssoc() helper
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 22:44:53 +00:00
Kamil Tekiela
73b7094b2b
Remove redundant isset
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:38:22 +00:00
Kamil Tekiela
83b4dda1a3
Change QUERY_STORE to QUERY_BUFFERED
...
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c
Implement ResultInterface & MysqliResult
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method
...
Now, it returns last error message or an empty string instead of false
if no errors occurred.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
ca91eaeb38
Accept mixed for DatabaseName and TableName constructors
...
This avoids redundant type assertions.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-23 16:25:05 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
92418f2226
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-21 13:39:29 -03:00