gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
90,069 Commits 12 Branches 481 Tags 2.4 GiB
ee69b718a8
Commit Graph

654 Commits

Author SHA1 Message Date
Jeff Chan
896fe8169a Fix PMA_arrayWalkRecursive to ensure single pass thru keys 
Fix a bug with PMA_arrayWalkRecursive that causes it to apply a function
to its keys/values more than once. A previously incorrect test is fixed
as well.

The bug happens because when keys are modified, PHP's foreach loops
through the new keys again. This does not usually happen unless the
iterating array is passed through by reference (or has refcount=1).
See: http://stackoverflow.com/a/14854568/791890

Please see #936 for full explanation.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
 2014-02-17 03:09:34 +00:00
Jeff Chan
9a5603f908 Cast unit size value for formatByteDown to float to avoid overflow. 
Add another test case to formatByteDown which fails on HHVM 2.4

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
 2014-02-10 18:25:54 +00:00
Dhananjay
0a18d86059 Fix for bug#4237. 
Signed-off-by: Dhananjay <dhananjaynakrani@gmail.com>
 2014-02-07 11:56:46 +05:30
Michal Čihař
a4788a9c90 Adjust tests to new messages 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2014-02-02 11:42:42 +01:00
Marc Delisle
1b639952d6 Merge commit '8ee7fc8' 2014-01-30 13:24:56 -05:00
Marc Delisle
8ee7fc8a9c bug #4265 Missing datepicker icon for DATETIME(length) 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-01-30 13:23:31 -05:00
Madhura Jayaratne
cdd53ace21 Merge branch 'QA_4_1' 
Conflicts:
	libraries/Util.class.php
	test/libraries/PMA_insert_edit_test.php
 2014-01-29 23:30:33 +05:30
Madhura Jayaratne
c1c50b5944 Revert e8fa9e5335, ea0ad9d41c and f36fbfd4c6 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2014-01-29 23:06:43 +05:30
Michal Čihař
e7288ef4c5 Adjust test to current mesasge 2014-01-29 14:27:18 +01:00
Marc Delisle
2a2d4cd2bb Fix merge conflict 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-01-27 12:48:11 -05:00
Sampath Liyanage
ea0ad9d41c unit tests updated. Some global variables were set in setup functions of some test files. one testing function with mockobjects was changed from once() to exactly(2) because the bug fix has made that function calls twice 
Signed-off-by: Sampath Liyanage <plbsam@gmail.com>
 2014-01-27 21:53:36 +05:30
Marc Delisle
3d72b1cc87 Fix typos 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-01-24 08:24:14 -05:00
Marc Delisle
0e88efbf9b Merge branch 'QA_4_1' 2014-01-22 08:37:58 -05:00
Marc Delisle
7064e047a3 bug #4218 Chrome behavior with date fields 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-01-22 08:37:32 -05:00
Hugues Peccatte
ae0c9218ce PHPDoc update. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2014-01-09 20:51:40 +01:00
Hugues Peccatte
f7d5da319e Fix coding style. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2014-01-09 18:22:11 +01:00
Hugues Peccatte
33cc76d3c3 Fix unit test. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2014-01-07 21:16:18 +01:00
Marc Delisle
eedc0f3071 Merge commit '10a6260' 2014-01-06 09:37:02 -05:00
Marc Delisle
10a6260180 Fix failing test 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-01-06 09:35:54 -05:00
Michal Čihař
9d215e6ac5 Remove unused parameter binary_log_file_names 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2014-01-06 11:33:25 +01:00
Michal Čihař
790a2c2bee Rename variable to match current meaning 
There is not only INFORMATION_SCHEMA now, so the variable should have
more generic name.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2014-01-06 11:11:34 +01:00
Hugues Peccatte
6b01f835cb Rename too short variables. 
Remove useless initializations.
Rename too long variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2014-01-04 20:46:18 +01:00
Marc Delisle
a6926c4f43 Improve function names 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-01-02 08:31:37 -05:00
Chanaka Indrajith
74e22e34bf Merge remote branch 'upstream/master' into rfe_1462 2014-01-01 19:35:35 +05:30
Marc Delisle
7cd460d511 Merge branch 'QA_4_1' 2013-12-28 06:25:43 -05:00
Marc Delisle
8cc5103b00 Fix failing test 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-28 06:13:51 -05:00
Hugues Peccatte
4f05a8abfa Merge pull request #808 from Tithugues/nestedLevels 
Nested levels
 2013-12-27 05:33:10 -08:00
Hugues Peccatte
ef49eff205 Standardize names of functions. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-27 13:49:57 +01:00
Chanaka Indrajith
4ca8f9cdc2 Added table comment tool tip for tables, listed in database structure page 
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
 2013-12-26 00:32:43 +05:30
Hugues Peccatte
8a6f0bbe53 Add missing include in unit tests. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-23 21:31:51 +05:30
Hugues Peccatte
6a8276a855 Update unit tests. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-23 21:31:20 +05:30
Marc Delisle
93d4b37e34 Merge branch 'QA_4_1' 2013-12-15 13:43:35 -05:00
Marc Delisle
887cd2b6e9 Fix test 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-15 13:43:08 -05:00
Marc Delisle
2a8962aa95 Signed-off-by: Marc Delisle <marc@infomarc.info> 
Added warning about the mysql extension being deprecated
and removed the extension directive
 2013-12-14 14:26:12 -05:00
Marc Delisle
bf35e2cd0f Fix coding style 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-11 06:23:22 -05:00
Hugues Peccatte
32a6150272 Fix PHPCS new errors. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-09 08:09:42 +01:00
Marc Delisle
48db6c7064 Merge branch 'QA_4_1' 2013-12-08 19:27:43 -05:00
Marc Delisle
f488cbbb86 Remove test no longer correct 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-08 19:27:06 -05:00
Marc Delisle
b1fb71c120 Improve function name 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-08 09:05:36 -05:00
Marc Delisle
6003743557 Improve function name 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-08 09:00:18 -05:00
Hugues Peccatte
b76f616079 Fix unit test. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-08 11:16:07 +01:00
Hugues Peccatte
bbf08d3a13 Add new unit tests. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-07 21:39:22 +01:00
Hugues Peccatte
226ae34061 New unit tests. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-07 20:01:49 +01:00
Marc Delisle
a329137fbd Fix tests 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-06 07:22:47 -05:00
Marc Delisle
4f612de31d Remove unneeded transformation 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-06 06:31:47 -05:00
Marc Delisle
17a2ed78e0 Fix test for new transformation 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-06 06:22:22 -05:00
Marc Delisle
ea39707eeb Fix test for the new transformation 2013-12-03 12:51:44 -05:00
Madhura Jayaratne
6a5062af3d Fix failing tests 2013-11-28 21:34:02 +05:30
ptarjan
840f7b1215 Make unit tests friendlier to running independently 2013-11-20 14:43:55 -08:00
Michal Čihař
8075bd0dd3 These tests can take longer, give them more time 2013-11-19 09:26:04 +01:00