Commit Graph

86 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 19:39:28 -03:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 15:03:39 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
William Desportes
7e42b5a7a3
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-19 01:13:50 +01:00
William Desportes
6be33c4eb6
Ref #16666 - Ref #16424 - Adjust the index like the zoom controller
Even if this is not needed, better that it is the same in the 2 controllers

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-19 00:42:01 +01:00
Saksham Gupta
4da866ed94 Fix #16424 - Numerical search in table and zoom
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fixes #16667

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment and change variable name

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-02-19 00:33:10 +05:30
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
36d93cf2f9 Remove Common::table method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
405b6277e7 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-10 14:16:25 -03:00
Isaac Bennetch
93c93bc9ee Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-10-09 22:14:49 -04:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
aecdfc80cb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-04 00:29:04 +02:00
Petr Duda
661af18061 Fix #16377 Uncaught ReferenceError: Stickyfill is not defined
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-10-01 21:39:49 +02:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
5aa2856f7f Remove Util::buildActionTitles and the titles global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 22:50:08 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-27 14:22:22 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
e26bde7e96 Fix coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-24 20:33:47 -03:00
William Desportes
47c70dacc7
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-23 19:57:46 +02:00
William Desportes
fe9e7ba89d
Fix #16255 - Tinyint(1) shown as INT in search page
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-23 19:53:52 +02:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
918b1f38c6 Change return type of Sql::executeQueryAndSendQueryResponse
Remove Response::addHTML call.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
William Desportes
06ffb871b4
Merge branch 'QA_5_0' and sync Search controllers
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-07 15:00:47 +02:00
Ankush Patil
69d49789ce
Fixes #16248: identifying searchType in validation function
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
2020-07-07 13:57:23 +02:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 17:20:43 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
e6d72f64f9
Fix merge issues
Ref: 54e0250dae

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-20 00:15:55 +02:00
William Desportes
54e0250dae
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 12:50:30 +02:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 20:15:42 -03:00
Ankush Patil
66338ccaec fixes #16041: added regex validation for INT having MULTIPLE prop
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>

added proper error message

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>

Fixing ambguious js code

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
2020-04-14 14:12:33 +05:30
William Desportes
191a0a06ec
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-24 22:53:35 +01:00
Isaac Bennetch
095cb4d5a2 Fix phpcs test errors
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-22 23:08:22 -04:00
Isaac Bennetch
6efdd77483 Merge branch 'QA_5_0' 2020-03-20 22:50:16 -04:00