Commit Graph

35 Commits

Author SHA1 Message Date
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
24fba67ccd Create ExportType enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-14 00:34:12 +00:00
Maurício Meneghini Fauth
7d6b17a417
Replace sql_query global var with Current::$sqlQuery
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-09 13:51:22 -03:00
Liviu-Mihail Concioiu
ef0dfce381 Fix GisVisualizationControllerTest
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-12-02 15:17:03 -03:00
Kamil Tekiela
ba3c2ded04 Update ZoomSearchControllerTest.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
7ffd21eb79 Replace $GLOBALS['goto']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
db7ce67a21 Use ServerRequest
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
6add4fccf0 Refactor UrlParamsSetting
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
c7582c282e Add type hint
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
039481df30 Create UrlParams::$params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
92a58a630a Handle default values during insert
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-10-30 21:22:59 +00:00
Kamil Tekiela
cf6d5ed4b5
Use getParsedBodyParamAsString (#19333)
* Use getParsedBodyParamAsString
* Remove unused stubs

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-10-29 12:07:39 -03:00
Maurício Meneghini Fauth
2c597e3f79
Fix compatibility with PHPUnit 11
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-29 13:51:46 -03:00
Maurício Meneghini Fauth
90ee00efd5
Create the 'pma' global variable for Twig templates
Creates the Twig\PmaGlobalVariable class to handle the 'pma' Twig global
variable.

The idea of this global variable is to automatically inject in all
templates some useful information.

For now it only includes `pma.version` to get the phpMyAdmin version
and `pma.text_dir` to get the text direction ('ltr' or 'rtl').

Adding new variables to the `pma` global variable should be done with
caution.

- https://twig.symfony.com/doc/3.x/advanced.html#globals

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-09 20:30:48 -03:00
Maurício Meneghini Fauth
bd4bcc92d6
Extracts OpenLayers JS from the GIS PHP classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-31 14:40:16 -03:00
Maurício Meneghini Fauth
d2060c56d5
Change InvocableController to always return a Response
When 'null' is returned, ResponseRenderer::response() is called, so
call it early to always return a Response object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 15:22:56 -03:00
Maurício Meneghini Fauth
c10d265ae5
Move flash message context to the shaped array
Does not group the messages by context.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-16 14:41:04 -03:00
Maurício Meneghini Fauth
64a8a9d779
Rename the FlashMessages class to FlashMessenger
This class handles the flash messages instead of being a collection
of flash messages, so FlashMessenger is a better name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-15 19:42:35 -03:00
Maurício Meneghini Fauth
24fcf259f3
Add support for statement messages in FlashMessages class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-15 19:20:37 -03:00
Maurício Meneghini Fauth
ea322a6b2c
Remove ResponseRenderer::disable from GisVisualizationController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:51:08 -03:00
Maurício Meneghini Fauth
d2e96532a0
Remove ResponseRenderer::disable from GetFieldController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:38:07 -03:00
Maurício Meneghini Fauth
06fed2283c
Remove ResponseRenderer::disable from TrackingController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:07:44 -03:00
William Desportes
11fb621a89
Ignore Generic.Files.LineLength.TooLong for providerForTestGenerateAlterTableSql
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-04-28 14:41:25 +02:00
William Desportes
f665e5037a
Merge branch 'QA_5_2' 2024-04-28 13:11:30 +02:00
Maurício Meneghini Fauth
137283f909
Remove unused constructor params from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:34 -03:00
Maurício Meneghini Fauth
542f1ad466
Merge pull request #19079 from kamil-tekiela/getWarningMessagesArray
Refactor Operations::getWarningMessagesArray
2024-03-27 10:15:34 -03:00
Kamil Tekiela
2f3c4d3830 Refactor Operations::getWarningMessagesArray
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-23 14:39:05 +01:00
Kamil Tekiela
abdaefca82 Remove PreserveGlobalState
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-21 15:17:30 +01:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Kamil Tekiela
8754b9b0c5
Fix PHPUnit 11 deprecations (#19057)
* Metadata in doc-comments is deprecated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix deprecated Group('medium') on classes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix #[Group('large')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix some #[Group('medium')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in NodeDatabaseChildTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyGroupTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PluginPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in GisGeometryTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove getMockForAbstractClass from StorageEngineTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyOneItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-17 13:35:28 -03:00
Kamil Tekiela
30ec978ded Remove $GLOBALS['plugin_param']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-15 16:02:18 +01:00
Maurício Meneghini Fauth
21fc3a48ed
Extract loadTableInfo() from SearchController constructor
Refactors Table\SearchController tests.
Makes private methods private.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 15:25:43 -03:00
Maurício Meneghini Fauth
66916f39f7
Remove dead code from Table\SearchController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 14:00:45 -03:00
Maurício Meneghini Fauth
861dd4e8b8
Extract loadTableInfo() from FindReplaceController constructor
Refactors FindReplaceController tests.
Makes private methods private.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 13:40:05 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00