Commit Graph

61 Commits

Author SHA1 Message Date
Tekin Birdüzen
bf486ccd1f Fixed typo in variable name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-12-10 09:02:55 -05:00
Michal Čihař
61fcf215e5 Detect failure of curl_init
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-12-05 10:20:13 +01:00
Madhura Jayaratne
93366c8c24 Merge branch 'QA_4_2' into QA_4_3
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-20 21:44:53 +05:30
Madhura Jayaratne
b99b6b6672 bug #4595 [security] Path traversal can lead to leakage of line count
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-20 06:24:34 +05:30
Madhura Jayaratne
9364e2eee5 bug #4596 [security] XSS through exception stack
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-20 06:20:49 +05:30
Hugues Peccatte
fd7f02f929 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 14:33:41 +01:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
5985894160 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-07 00:31:45 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
chanaka
237b00cc00 Fixed some codesniffer errors
Signed-off-by: chanaka <chanaka@oneit.com.au>
2014-07-28 21:49:11 +05:30
Marc Delisle
864a80209a Handle possible execution path
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-23 06:49:38 -07:00
Michal Čihař
a01e065d55 Fix typo
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:30:55 +02:00
Michal Čihař
c04f7e86c6 Query string does not have to be present
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:06:06 +02:00
Michal Čihař
2cc58f0847 Handle error on top page
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:05:00 +02:00
Michal Čihař
60211dd027 Document problem in a code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:03:49 +02:00
Ann + J.M
6b778e09d9 Fix coding style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-22 16:34:34 +02:00
Dhananjay Nakrani
8b09aa7f76 Make Syntax compatible with php-5.3
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
c00d1d5ef6 Change hardcoded indexing to dynamic one.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
b2e3164441 Make return values of PMA_getReportData() consistent.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e37616adba Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
0b9439a246 Make automatic php error report submission ('sendErrorReport'='always') aysnchronous. Stop infinite auto error reporting loop.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
86b3f352a9 Stop false alarms (displaying prompts-reporting form and reporting for 'false' (user warnings) errors).
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
ed564f4d63 Remove unnecessary code. A deliberate error & local error-reporting-server URL.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
6d04bc17bc Send only backtrace (not displayBacktrace). Change getBacktrace to return first 'X' frames. Send stackhash too.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
1ba7140be5 Send only(without HTML) error message string.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Dhananjay Nakrani
43e1aa5ce2 Fix Syntax errors.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Dhananjay Nakrani
e74cd6ec1d Report errors based on user preference. All the cases taken care of.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Michal Čihař
c17eea8dba Remove documentation for removed parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 14:06:24 +02:00
Michal Čihař
3f21b2816f Get rid of overridable return type
Separate function for collecting the data from pretty printing it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 13:26:41 +02:00
Sachith Hasaranga Seneviratne
4e28aa1a81 (Feature Request 1466)
Refactor PMA_Util::getLatestVersion() and PMA_sendErrorReport()
to further reuse curl_handle option setting code.

Signed-off-by: Sachith Seneviratne sachith500@gmail.com
2014-01-08 19:08:18 +05:30
Madhura Jayaratne
6335b10574 Fix coding style
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 14:35:15 +05:30
Sachith Hasaranga Seneviratne
45b30c130f Refactor PMA_Util::getLatestVersion() and PMA_sendErrorReport() (Feature Request 1466)
Signed-off-by: Sachith Seneviratne sachith500@gmail.com
2014-01-05 09:11:04 +05:30
Hugues Peccatte
008b1fa8d3 Rewrite to decrease number of nested levels.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-07 22:16:16 +01:00
Michal Čihař
a8bd9e5b9f Set Content-Type in request 2013-11-18 15:03:37 +01:00
Michal Čihař
118c6f3501 Merge pull request #735 from m0hamed/error_reporting_pretty_fix
Fixed prettifying for older php versions
2013-11-18 02:49:34 -08:00
Mohamed Ashraf
3a76b83343 Moved inline css to theme files 2013-11-17 18:55:14 +01:00
Mohamed Ashraf
71862deca2 fixed merge conflict bug 2013-11-17 18:31:12 +01:00
Mohamed Ashraf
5c102f48af Added test cases for PMA_prettyPrint 2013-11-17 15:38:44 +01:00
Mohamed Ashraf
6816436eac Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin into error_reporting_pretty_fix 2013-11-17 15:02:43 +01:00
Marc Delisle
677e4496b7 Bug #4114 No params checking in error_report.php 2013-11-17 08:56:55 -05:00
Mohamed Ashraf
21b026a44d Added another prettifying function and changed the way the report is represented in the dialog 2013-10-28 12:54:19 +02:00
Rouslan Placella
4a7236a418 Made label clickable in error reporting dialog 2013-10-27 19:40:34 +00:00
Madhura Jayaratne
cb798bc5d2 Fix coding style 2013-10-22 07:05:44 +05:30
Marc Delisle
11a9be4980 Fix coding style 2013-10-21 03:30:12 -07:00
Michal Čihař
54da98e827 Add full stop to end of a sentence 2013-10-17 12:58:38 +02:00
Michal Čihař
21812d6ac9 Make error reporting work with PHP older than 5.4
This is workaround for #4113 with cost of having not readable JSON shown
to user in report detail.
2013-10-17 10:32:02 +02:00
Michal Čihař
4f4167f67c Enable allow_url_fopen backend for error reporting 2013-10-17 10:32:02 +02:00
Michal Čihař
79dd43afe6 Fixed error submission using curl
The problem is that curl inserts Expect: header which server does not
support.

More details at:

http://pilif.github.io/2007/02/the-return-of-except-100-continue/
http://stackoverflow.com/questions/3755786/php-curl-post-request-and-error-417
2013-10-17 10:18:39 +02:00
Marc Delisle
2c01fd93c3 Merge pull request #728 from nijel/autolinecount
Automatic counting of lines for error reporting
2013-10-16 08:16:21 -07:00
Marc Delisle
92f2204110 Improve a message 2013-10-03 12:58:16 -04:00