William Desportes
f2ac6644b0
Fix ResultsTest::testGetTableNavigationButton
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 00:29:54 +02:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
ec7d53af55
Extract HTML from table rows checkbox and links
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-23 20:26:26 -03:00
Maurício Meneghini Fauth
19406efd89
Extract HTML from results bulk action checkbox
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-23 16:04:04 -03:00
Maurício Meneghini Fauth
b2d1615176
Fix Display\ResultsTest test on Windows
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-25 17:30:03 -03:00
William Desportes
191a0a06ec
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-24 22:53:35 +01:00
Isaac Bennetch
095cb4d5a2
Fix phpcs test errors
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-22 23:08:22 -04:00
Isaac Bennetch
98f761a245
Merge branch 'QA_5_0'
2020-03-20 23:04:06 -04:00
Isaac Bennetch
6f698b87b3
Fix tests for phpunit 9
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-20 23:02:44 -04:00
Isaac Bennetch
6efdd77483
Merge branch 'QA_5_0'
2020-03-20 22:50:16 -04:00
Isaac Bennetch
0d4c7c66a5
Merge branch 'QA_4_9' into QA_5_0
2020-03-20 22:01:14 -04:00
Maurício Meneghini Fauth
46a7aa7cd4
Fix Display\ResultsTest errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-05 18:49:50 -03:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
6db94abb7e
Create Table\GetFieldController controller
...
Moves the table get field entry point logic to the controller and
removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-23 23:15:01 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
8a0aa251fe
Replace some custom CSS utilities with Bootstrap equivalents
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 19:35:37 -03:00
Maurício Meneghini Fauth
5dd7a0f9da
Use the router for table get field
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 22:51:44 -03:00
Maurício Meneghini Fauth
74f8246fd5
Use the router for the database routines page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-07 01:53:31 -03:00
Maurício Meneghini Fauth
208b0e25e1
Use the router for the sql pages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
e4982d677d
Use the router for the table change page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-26 02:13:37 -03:00
Maurício Meneghini Fauth
aec0402679
Use the router for table structure page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-19 20:18:06 -03:00
William Desportes
b9217146ab
Fix multi server setup number of results selector
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 20:51:30 +02:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c9129e9bd8
Remove unnecessary string concatenation
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 17:47:33 -03:00
Maurício Meneghini Fauth
9102b98ede
Fix broken tests with PHPUnit 8.2
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-08 16:43:55 -03:00
Maurício Meneghini Fauth
aa0796c7db
Move special_schema_links.inc.php to Config\SpecialSchemaLinks
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-22 21:29:58 -03:00
Maurício Meneghini Fauth
92cc67fbf7
Replace assertContains() with assertStringContainsString()
...
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f
Add void return type declaration for tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
f8f8d2ae05
Extract HTML from Display\Results::_getTableNavigation
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 23:12:12 -02:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
9eba565bf4
Remove unnecessary HTML closing tags
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
4c6993b2c2
Fix some tests on Windows
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-17 23:15:37 -03:00
William Desportes
e816e45c18
phpstan level 0 ( #14405 )
...
* Fix phpdoc @return
- Fixed @return typehint
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix incorrect case on function calls
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Type hint + typo fix
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fixes
- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
- libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor libraries/classes/Error.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Update config
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Access to an undefined property
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Update config
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix bootstrap-phpstan
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix typos and phpstan config
Fixes : #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
285e38e931
Fix some PSR-2 coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
dc8c92bfd8
Enable strict mode in test files
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
cbfbb3adaf
Remove incomplete tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-30 00:31:37 -03:00
Maurício Meneghini Fauth
c73e72e7ca
Refactor PhpMyAdmin\Transformations static methods
...
Replaces static methods with instance methods.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-01 01:34:17 -03:00
Maurício Meneghini Fauth
ccacfb018f
Fix Display/ResultsTest global dependencies
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 19:08:45 -02:00
Michal Čihař
3b6a994dcd
Move collation connection setting to user preferences
...
It is now handled same way as other user settings.
Issue #11688
Issue #13466
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 14:16:31 +01:00
Maurício Meneghini Fauth
bdb35e5769
Use template for _buildNullDisplay method
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-19 00:28:44 -02:00
Maurício Meneghini Fauth
70e9ec0fcd
Use template for _buildValueDisplay
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 23:40:56 -02:00
Maurício Meneghini Fauth
dfa796be07
Use template for _getTableNavigationButton
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
dba5237520
Use template for _getShowAllCheckboxForTableNavigation
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Michal Čihař
99e9854473
Always use POST for links containing SQL query
...
This way the SQL queries will not apper in the web server logs.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:33:53 +01:00