Commit Graph

309 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
4834c5fe7d
Remove bypass flag from Util::backquote method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-26 11:51:34 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
86798ec45e
Refactor PhpMyAdmin\Plugins::getChoice method
Extracts the getDefault method from the getChoice method and adds a
getName method to the Plugin interface.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-27 13:38:01 -03:00
Maurício Meneghini Fauth
84d175b282
Extract HTML from Plugins::getChoice method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 15:29:43 -03:00
Maurício Meneghini Fauth
7a4536d4d6
Remove PhpMyAdmin\Twig\PluginsExtension class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 11:00:21 -03:00
Maurício Meneghini Fauth
2de0a7cbd7
Update Psalm baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-28 12:11:52 -03:00
William Desportes
f77433b9b7
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-28 01:37:17 +02:00
William Desportes
42165e4953
Fix #15370 - Edit routine UI incorrectly removes too many escape slashes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-27 23:12:04 +02:00
William Desportes
587536b766
Remove non used variables
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 02:13:27 +02:00
S. B. Hunter
a0410aa77d
Replace REQUEST to POST in Routines.php (#16904)
Signed-off-by: Akihiro Asahara <akihiro.asahara@gmail.com>

Co-authored-by: Akihiro Asahara <akihiro.asahara@gmail.com>
2021-07-14 14:24:08 -03:00
Maurício Meneghini Fauth
1835ebb4fc
Replace mb_strpos !== false with str_contains
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
William Desportes
6996e8dd28
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 19:01:02 +02:00
William Desportes
6a7230cb8c
Fix #16982 - do not try to delete internal relations if they are not configured
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 16:23:34 +02:00
William Desportes
ab6fedbd5c
Backquote phpMyAdmin table name on internal relation delete query
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 16:00:31 +02:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
e376c4189b
Remove the .pma-fieldset from some pages
Replaces with Bootstrap's cards

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 18:18:23 -03:00
Maurício Meneghini Fauth
b9464bdd1b
Extract the HTML from the Triggers::getEditorForm method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 15:44:21 -03:00
Maurício Meneghini Fauth
bfc93d8e6f
Extract the HTML from Database\Triggers::export method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 14:26:58 -03:00
Maurício Meneghini Fauth
95fdd35e2f
Remove the .pma-table CSS class
Replaces with equivalent Bootstrap classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-15 17:16:22 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-11 01:20:20 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:51:45 +02:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
Maurício Meneghini Fauth
cb55bdbaf7
Rename Database\Qbe class variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 13:01:37 -03:00
Fawzi E. Abdulfattah
a4b7bbb334 support RTL mode - Designer
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-04-16 00:02:53 +02:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 01:13:58 +01:00
William Desportes
2885bbca99
Fix #14430 - Execute button is disabled for routines
Allow the procedure definer to the procedure

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 00:29:00 +01:00
William Desportes
157be3004d
Do not query twice to ask about "CREATE ROUTINE" privs
They do not change between calls, store the value then.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 00:05:03 +01:00
William Desportes
c2bf51ea19
Fix #16694 - check privileges for triggers down to the table if possible
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-22 23:29:09 +01:00
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
Brittany Barnes
dc1be997c9
Converted getExecuteform to utilize twig template (#16712)
Signed-off-by: Britt Barnes <britbarnes92@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-19 15:23:27 -03:00
Maurício Meneghini Fauth
d3ce67593d
Fix some errors found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-09 17:22:03 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
1ac9a165e0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-25 18:44:47 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
Saksham Gupta
6f64a08906 Fix 13325 : Created procedure shows up in triggers and events and vice versa
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove console.log

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Change variable name tableType

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-02-17 13:56:01 +05:30
William Desportes
54f09a8e9c
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-05 01:51:54 +01:00
William Desportes
2cac456ce2
Fix code comment typos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-05 01:03:28 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
05d1f0a0c8
Redesign the Triggers pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-23 18:07:02 -03:00