Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
...
This improves the type checking and simplifies the code.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
William Desportes
2d307ed062
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-31 00:18:17 +02:00
William Desportes
dc5cf4766b
Fix #16906 - Escape the table name that is checked with backquotes on canAccessStorageTable function
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 04:06:18 +02:00
William Desportes
b0ec0fd112
Fix #16906 - Replace table names with the configuration ones while creating the storage tables
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 03:55:58 +02:00
William Desportes
576decd1f4
Fix coding standard issues
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 01:46:45 +02:00
William Desportes
c01e681c33
Prevent overriding user setting while auto fixing pma storage
...
Once the table was created it was overriding the setting. It should respect that the user said the table will be named pma__userconfig_table and not pma__userconfig (the default value).
If the database had the default tables in it, the detection would silently mark them as the right tables totally ignoring the user defined settings for the table names.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 00:05:07 +02:00
William Desportes
b527b13e2d
Old typo fix
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 23:23:22 +02:00
William Desportes
bb2c869e4c
Ref #16906 - Clear the relation cache after the control db was created
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 23:10:50 +02:00
William Desportes
9c0dcc2043
Fix #16906 - Use the control connection to create the storage database and tables
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 23:09:16 +02:00
William Desportes
2ea46aa113
Ref #16906 - Return an error message if the pma storage db could not be selected
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 22:32:56 +02:00
William Desportes
806e2740ba
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 22:09:55 +02:00
William Desportes
cdb027c119
Ref #16906 - Allow to create the pma storage db using a different name than "phpmyadmin"
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 17:06:45 +02:00
William Desportes
8aa4e30512
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-29 03:16:09 +02:00
William Desportes
0de25bebd4
Fix #16995 - Edit binary foreign key adds a 1 on the selected value
...
Caused-by: e9d3fdd493
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-28 18:48:59 +02:00
William Desportes
45d6336b90
Ref #15247 - Remove defined('TESTSUITE') from Relation::setHistory
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:13 +02:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
William Desportes
6996e8dd28
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 19:01:02 +02:00
William Desportes
6529d81b71
Fix "Notice: Undefined index: foreign_keys_data"
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 15:46:57 +02:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
95fdd35e2f
Remove the .pma-table CSS class
...
Replaces with equivalent Bootstrap classes.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-15 17:16:22 -03:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 19:01:26 +02:00
William Desportes
eb258a806d
Query adjustments
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 16:19:53 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
...
Uses the PhpMyAdmin\Version::VERSION constant instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
2625e0e1f6
Replace .caution and .success CSS classes
...
Replaces with .text-danger and .text-success.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-23 19:37:52 -03:00
Maurício Meneghini Fauth
d3c31fabd4
Remove some custom CSS utilities
...
Uses Bootstrap equivalents.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-23 19:06:38 -03:00
Maurício Meneghini Fauth
c64b77abe1
Move HTML's table CSS to the pma-table class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-16 16:36:16 -03:00
William Desportes
5abcae9255
Fixed some typos in the code base
...
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
e7c8e20edb
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
461cc87521
Remove list templates
...
- templates/list/item.twig
- templates/list/unordered.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 20:43:55 -03:00
Maurício Meneghini Fauth
e5514a6b66
Fix some PHPStan errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-10 21:24:35 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
05c62ad1a8
Fix some PHPStan errors
...
Fixes "Cannot access offset on array" errors.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
58eee2e371
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
199e3d9813
Fix coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
William Desportes
1dd98ba696
Trim down Relation::checkTableAccess
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 21:03:44 +02:00
William Desportes
c86f90dffa
Split some code in Relation class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 19:20:53 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00