gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
122,584 Commits 12 Branches 481 Tags 2.4 GiB
f2fb87f385
Commit Graph

149 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
5f4fd07483
Remove some assignments to the $_POST global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-03 15:49:39 -03:00
William Desportes
72800e2524
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-15 00:52:33 +02:00
William Desportes
d804e60820
Fix broken docs link after FK types mismatch error 
See: https://web.archive.org/web/20200921164945/https://dev.mysql.com/doc/refman/8.0/en/innodb-foreign-key-constraints.html

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-14 15:28:55 +02:00
William Desportes
12c390948c
Fix a phpstan reported error 
[ci skip] One failing test fixed on next push

And remove an error from the baseline from previous merge

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-20 17:54:04 +02:00
William Desportes
587536b766
Remove non used variables 
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:13:27 +02:00
William Desportes
d84e3cde28
Fix psalm detected errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-13 21:45:34 +02:00
Fawzi E. Abdulfattah
9954c47577
Fix #16138 - ignore the length of integer types, and show a warning 
Fixes: #16138

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-13 15:42:57 +02:00
Maurício Meneghini Fauth
ed45c51d59
Add Stringable interface to classes with __toString 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-10 14:11:51 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
1129b68d29
Refactor PhpMyAdmin\Plugins::getPlugin method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-25 17:40:20 -03:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
9928882de3
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-23 00:24:59 -03:00
William Desportes
2204ef77a0
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-30 00:09:21 +02:00
William Desportes
bd7a7efdc7
Ref #16842 - Also check PerconaDB in Table::getColumnGenerationExpression 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 23:42:56 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
41e0d4dfb7
Use the Query\Compatibility class to simply and remove duplicate checks 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:57:10 +02:00
Maurício Meneghini Fauth
9b95d252fe
Rename variables to use camelCase format in Table class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-25 15:04:12 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 19:39:28 -03:00
William Desportes
e76c181d87
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-24 03:22:25 +01:00
William Desportes
52b872feb8
Merge #16737 - Fix #16728 - Wrong SQL query built on table structure index for new column 
Pull-request: #16737
Fixes: #16728

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-24 03:09:57 +01:00
Saksham Gupta
b8540bdc3c Fix #16728 - Wrong SQL query built 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-03-16 14:07:18 +05:30
Maurício Meneghini Fauth
d3ce67593d
Fix some errors found by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-09 17:22:03 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
7d3a3cd74c
Add more type casts for #16634 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-16 17:59:45 +01:00
peterdd
805ceb08c3
Fix #16575 - move timestamp column with default value 
Signed-off-by: Peter Liscovius <ddpm@liscovius.de>
 2021-02-16 15:36:54 +01:00
Fawzi E. Abdulfattah
7df23b47c6
Fix #16641 - query generation bug which allowing JSON to have length 
Fixes: #16641

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-02-14 13:06:12 +01:00
William Desportes
f018156de3
Merge #16427 - Fix #16422 - Renaming Database with views throws an error 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 16:36:38 +01:00
Saksham Gupta
d0be531ede Renaming Database with views error 
Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16422

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16214

Revert "Add PHP 8 to composer.json"

This reverts commit 64090387f1.

Revert "Renaming Database with views error"

This reverts commit 23ffa730c94c9ed26f0b7f06a853c0e9af0aa637.

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove fix
 2020-11-20 20:59:33 +05:30
William Desportes
e4bd8b51aa
Fix #16429 - PHP 8 errors on preg_replace 
49) PhpMyAdmin\Tests\Setup\ConfigGeneratorTest::testGetConfigFile
TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, int given

libraries/classes/Setup/ConfigGenerator.php:183
libraries/classes/Setup/ConfigGenerator.php:53
test/classes/Setup/ConfigGeneratorTest.php:55
vendor/phpunit/phpunit/phpunit:61

50) PhpMyAdmin\Tests\TableTest::testGenerateFieldSpec
TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, int given

libraries/classes/Table.php:596
test/classes/TableTest.php:491
vendor/phpunit/phpunit/phpunit:61

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-19 18:28:37 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base 
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
William Desportes
da8230fced
Merge #16368 - Fix #16365 - Foreign keys are not showing 
Pull-request: #16368
Fixes: #16365

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-10-06 09:23:35 +02:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Petr Duda
ceb289743f Fix #16365 Foreign keys not showing 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-09-20 10:50:53 +02:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a22f7b1b7a Fix some PHPStan errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-04 00:00:59 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
William Desportes
e89b02c08d
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-24 09:07:17 +02:00
Ankush Patil
de36400507
globalised DEFAULT_GENERATED matching 
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
 2020-06-22 21:34:15 +05:30
charliewindred
ca3c5e17b0 Remove underscore prefix from method names 
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
 2020-06-02 16:44:16 +01:00