Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
d441c88aad
Fix failing unit tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 14:20:21 -03:00
Maurício Meneghini Fauth
5f4fd07483
Remove some assignments to the $_POST global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-03 15:49:39 -03:00
Maurício Meneghini Fauth
f7fc4177af
Add support for account locking
...
- https://dev.mysql.com/doc/refman/en/account-locking.html
- https://mariadb.com/kb/en/account-locking/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-21 00:55:33 -03:00
Maurício Meneghini Fauth
a1379fa1c6
Remove $dbi mock from PrivilegesTest::testGetHtmlForUserProperties test
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-13 17:00:18 -03:00
William Desportes
ab2e5358f7
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-21 18:49:19 +02:00
William Desportes
6d5c5e69d6
Add tests after #17015
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-21 18:42:16 +02:00
William Desportes
25c2cfe699
Fix tests after #17015
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-21 18:39:59 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
a96be01b6d
Fix some failing tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-13 15:01:07 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
b4f3a2c8aa
Fix some failing PHPUnit tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-02 14:53:17 -03:00
Daniel Tiringer
debb6af80f
Move html from server/select to template
...
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Factor out logic from server listing
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Create the base twig skeleton
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Insert template and variables to form part
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Insert list view template part
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Insert just options fork
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Factor out repeating code into server_options template
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Render the template
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Comment out test parts that don't work due to translate
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Fix the typos in the translatable elements
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Refactor the test into separate scenarios
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Remove indentation spaces
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Codesniffer cleanup
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Add test for fieldset existence
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Code style fixes
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Reorder lines in test
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Replace include function with tag
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Removing the escape calls
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
2021-05-05 16:17:20 +02:00
Maurício Meneghini Fauth
5750dfb1bb
Extract method to get edit user group modal form
...
Creates a new route: /server/user-groups/edit-form
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-26 22:59:09 -03:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
ba35901594
Merge branch 'origin/QA_5_1' into master
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:53:14 +02:00
Maurício Meneghini Fauth
4273634c17
Extract getActiveAuthPlugins method to Plugins class
...
Extracts the getActiveAuthPlugins method from the
PhpMyAdmin\Server\Privileges class to the PhpMyAdmin\Server\Plugins
class, rename it to getAuthentication and adds tests.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-14 16:07:40 -03:00
William Desportes
7a3978a948
Remove useless htmlspecialchars on URL generation
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 17:23:12 +02:00
Maurício Meneghini Fauth
a7d6df17d6
Remove warnings from PHPUnit
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-09 13:28:47 -03:00
Maurício Meneghini Fauth
d05ba8e733
Remove PHPUnit's at() matchers from Server\UserGroupsTest
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-05 22:53:04 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
...
Uses the PhpMyAdmin\Version::VERSION constant instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
443e4289c3
Replace user groups jQuery UI's dialog with a modal
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:22 -03:00
Maurício Meneghini Fauth
4ad6e2ea4e
Use Bootstrap's pagination for user accounts page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-29 17:59:59 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
William Desportes
1b5781f825
Fix #16477 - Fix failing unit test
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-15 22:54:05 +01:00
Saksham Gupta
be3905944f
Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16477
...
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix db Edit privileges
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix conflict
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add missing bracket
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix Lint
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2020-11-16 02:09:54 +05:30
Maurício Meneghini Fauth
4873c32273
Remove DatabaseInterface::isUserType method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
71d9a8f760
Remove is_grantuser and is_createuser PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
34dd2a61f8
Remove strPrivDesc* global variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
ba09c84a05
Fix PHPStan errors for PHPUnit assert methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-10 16:20:53 -03:00
Maurício Meneghini Fauth
c92663adbb
Move ChangePassword::getHtml to Server\Privileges class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 19:12:35 -03:00
William Desportes
ddfdbc2134
Remove some useless doc blocks and fix some coding standard warnings
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-18 00:14:32 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
ae975e594e
Remove Privileges::getHtmlForUserGroupDialog method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
47f0960dce
Add return type declaration to test methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
dfa5f92c31
Add return type declaration to fetch row methods
...
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
William Desportes
076d7b1a7f
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:27:18 +02:00
William Desportes
5164bea16a
Fix #16166 - Make the alter user privileges MySQL 8.0.11+ compatible
...
Ref: #14217
Ref: #14788
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:08:50 +02:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00