Commit Graph

11 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e330402b5b Refactor the core functions into static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-03 00:52:22 -03:00
Michal Čihař
ae9006e9be Use one temporary directory
Share one directory for Twig cache, SHP import and file uploads.

The code now also validates the cache directory and creates it on the
fly, so it properly detects if the directory can not be used.

Also the documentation has been improved to document securing this
directory.

Fixes #13225
Fixes #13226

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-05-05 11:08:36 +02:00
Michal Čihař
1b7914a4e5 Remove connect_type setting
It is really not necessary as MySQL decides connection type rather based
on hostname than on anything else.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-02-02 16:08:44 +01:00
Michal Čihař
1dd22f4dea Merge branch 'QA_4_6-security' into master-security 2017-01-07 11:02:01 +01:00
Michal Čihař
c962ee4287 Remove setup download/load/delete features
This removes risk of third party manipulating with the configuration as
there was race condition between editing and using the file.

Downloading the file should not be big hassle and this really makes the
whole setup a bit simpler.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 11:34:42 +01:00
Michal Čihař
84971eaf4f Make function static as it's called statically
Issue #12690, #12514

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-11-28 12:13:20 +01:00
osaid
b8a9b0f30d Share code for getting temporary directory
Changed Encoding.php and File.php.

Fixes #12514

Signed-off-by: Osaid <osaid.nasir@gmail.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-11-28 12:12:59 +01:00
Michal Čihař
1aee86a4fe Remove the nopasswd setting
It does nothing since removal of related feature in
53f541af86.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-10-17 17:20:54 +02:00
Deven Bansod
eef59d6c48 Fix order of testing DBConnection with different parameters in Config method
In setup, try to follow what the docs say.
'Password login is still tried first, but as fallback, no password method is tried.'

Fix #12472

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-12 14:03:50 +05:30
Michal Čihař
3ebacb0025 Simplify loading of vendor configuration
Do it just once and very early, so that all scripts can rely on it being
available.

Fixes autoloading of phpseclib.

Fixes #11914

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-09 11:00:54 +01:00
Hugues Peccatte
e5e447e937 Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:23 +02:00