Commit Graph

21726 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e2c7aa8628
Fix error when a db group name is same as container name
Fixes #17659

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-23 18:38:22 -03:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:28:43 -03:00
atomu330
6957064cea
replace isset to empty
IF statement ! isset($this->uiprefs) was causing issue.

Private property 'uiprefs' is initialized to empty array, so ! isset($this->uiprefs) is always FALSE;
It's not hopefull, so I replace ! isset($this->uiprefs) to empty($this->uiprefs) to fix #17617 bug;

Fixes #17617
Closes #17644

Signed-off-by: Atomu Oku <atomu.work@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 13:04:59 -03:00
Maurício Meneghini Fauth
519522428e
Fix some languages not getting correctly detected
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-15 21:32:22 -03:00
William Desportes
0fb9f4c266
Fix PHP 8.2: ${var} deprecated string interpolation syntax on Git class
Ref: af7338f706

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-07-13 15:28:08 +02:00
William Desportes
6a69face6c
Fix PHP 8.2: ${var} deprecated string interpolation syntax
Ref: https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated

Left over to patch:
- libraries/classes/Git.php#L397
- libraries/classes/Database/Qbe.php#L878
- libraries/classes/Database/Qbe.php#L879

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-07-13 11:14:20 +02:00
Maurício Meneghini Fauth
9e554da5d8
Fix Symfony exception when db/table has two %%
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17584

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-16 21:20:47 -03:00
Maurício Meneghini Fauth
bf2add8312
Fix preview SQL modal not working inside Index modal
- Fixes #17606

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-15 20:09:13 -03:00
Maurício Meneghini Fauth
bf084233ea
Add ChangeLog entry for #17586
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-11 14:04:58 -03:00
Maurício Meneghini Fauth
bc61c2f8c3
Merge pull request #17587 from liviuconcioiu/statistics
Fix #17586 Statistics not showing for empty databases

Fixes #17586
2022-06-11 11:35:19 -03:00
Maurício Meneghini Fauth
fd5300e9e0
Merge pull request #17583 from kamil-tekiela/password_hash_5_2
5.2 backport of #17582

Fixes #17121
Closes #17120
2022-06-11 10:53:46 -03:00
Maurício Meneghini Fauth
a8cc5d93c5
Merge pull request #17578 from liviuconcioiu/language
Fix PHP documentation links for Chinese (Simplified)
2022-06-10 16:20:06 -03:00
Maurício Meneghini Fauth
8f55743def
Merge pull request #17569 from liviuconcioiu/export_limit
Fix export limit size calculation

Fixes #17424
2022-06-10 03:11:10 -03:00
Maurício Meneghini Fauth
a112942515
Add missing variable to Server\Status\Processes::getList
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-10 01:16:26 -03:00
Maurício Meneghini Fauth
2e52f362e8
Merge pull request #17566 from liviuconcioiu/proc
Fix #17271 - database names dissapearing from Processes tab
2022-06-09 22:48:23 -03:00
Maurício Meneghini Fauth
fcea0f39e8
Merge pull request #17517 from aidvu/patch-2
Revert to old behavior for `ShowServerInfo`
2022-06-06 16:30:36 -03:00
Liviu-Mihail Concioiu
479f8472b3 Fix statistics
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-06-06 21:12:47 +02:00
Kamil Tekiela
6d0a30a391 Fix errors in InsertEdit
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-06-04 19:06:16 +01:00
Liviu-Mihail Concioiu
a50b276a89 Fix PHP documentation links for Chinese (Simplified)
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-06-02 22:11:58 +02:00
Liviu-Mihail Concioiu
d14e5a74f8 Fix export limit size calculation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-31 08:22:25 +02:00
Liviu-Mihail Concioiu
8ddfd4893f Show Progress column only on MariaDB
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-30 01:13:15 +02:00
Liviu-Mihail Concioiu
fb1afbe444 Fix database names dissapearing from Processes tab
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-30 00:44:38 +02:00
Liviu-Mihail Concioiu
e9a5ec01f5 Revert "Fix database names dissapearing from Processes tab"
This reverts commit af4434dee2.
2022-05-30 00:39:39 +02:00
Liviu-Mihail Concioiu
af4434dee2 Fix database names dissapearing from Processes tab
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-29 19:54:04 +02:00
Liviu-Mihail Concioiu
c729dddc7b Fix system memory and system swap values on Windows
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-28 21:31:27 +02:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
9e4f3833a5
Fix Table\OperationsController failing test
The Partition::getPartitionNames method returns [0=>null] when no
partitions were found.

Related to 346d6c7981.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-21 16:35:36 -03:00
Maurício Meneghini Fauth
346d6c7981 Fix error in table operation page when partitions are broken
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17496

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 20:52:55 -03:00
Maurício Meneghini Fauth
43cfe7d256
Mark Plugins\Plugin::isAvailable as static method
Allows for checking the availability before creating a new instance.

- Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17519

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 14:17:57 -03:00
Maurício Meneghini Fauth
827e32a92e
Improve ErrorHandler::handleException to show errors
It doesn't shows a blank page when not in development environment
anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-19 20:56:24 -03:00
Maurício Meneghini Fauth
4bc1ae53da
Fix error when configuring 2FA without XMLWriter or Imagick
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17506.

References:
- d70c840f68/src/Renderer/Image/SvgImageBackEnd.php (L45)
- 0459a5d7ba/src/QRCode/Bacon.php (L75)

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-19 12:15:06 -03:00
Rodrigo Pokemaobr
5a57873744 Removing types from in RelationExtension for avoid null error on global
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 15:11:46 -03:00
Maurício Meneghini Fauth
9f076774e5
Remove table-light CSS classes
These classes were added by 6408b7179a.
However they aren't exactly the same as thead-light classes that exists
in Bootstrap 4.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/17455.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-14 17:31:31 -03:00
Maurício Meneghini Fauth
680e59eb5f
Ignore invalid routes cache file
If the `libraries/cache/routes.cache.php` file is invalid (usually from
5.1), ignores it and try to write a new one instead of failing.

Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17522.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-13 21:46:17 -03:00
Andrija Vučinić
c6bb867787 Revert to old behavior for ShowServerInfo
Seems we changed the flag behavior here: cd1b8a9b77 (diff-bb8d8aecc2e174245e8b95be9344176aba8971d024f3b2c2311b8e58ddd59b31L149)

I'm not sure whether that was intentional, but it causes the `Database server` panel to always show compared to pre 5.2.0.

Truth be told, it doesn't make sense to have that flag and then the additional checks in the block when we know it's `true`, so I updated the code to take care of that.

Signed-off-by: Andrija Vučinić <andrija.vucinic@gmail.com>
2022-05-11 22:57:55 +02:00
Maurício Meneghini Fauth
1c7aab1a4d
Fix issue reported by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-11 14:52:05 -03:00
Isaac Bennetch
f2d3767e28 Prepare for version 5.2.1-dev
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-05-11 01:43:41 -04:00
Isaac Bennetch
89c68f74a9 Prepare for version 5.2.0
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-05-11 00:18:12 -04:00
Maurício Meneghini Fauth
a34dc9f064
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-08 14:14:52 -03:00
Maurício Meneghini Fauth
e2c4c4a10f
Replace for with foreach in Display\Results::getTable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-07 14:13:18 -03:00
Maurício Meneghini Fauth
973023737f
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-06 09:52:52 -03:00
Maurício Meneghini Fauth
29170a28f9
Remove UI props if cached fields count differs from actual
- Fixes #17428
- Fixes #17498

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-05 22:33:58 -03:00
Maurício Meneghini Fauth
49e2b081ba
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-28 15:26:35 -03:00
Maurício Meneghini Fauth
0312396a75 Remove jQuery Mousewheel JS dependency
This dependency was removed by
https://github.com/phpmyadmin/phpmyadmin/pull/17032.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 21:21:25 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
04f3f5a4b6
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-26 21:03:20 -03:00
Maurício Meneghini Fauth
5d80594341 Remove jQuery SVG JS dependency
Removed by https://github.com/phpmyadmin/phpmyadmin/pull/17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-24 20:39:12 -03:00
Maurício Meneghini Fauth
b17700dd09 Remove PMA_IS_WINDOWS constant
Gets the value from the Config class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-24 20:37:55 -03:00
Maurício Meneghini Fauth
449d922428
Improve type check for UserPreferences::load method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/17465.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-24 01:23:17 -03:00
Rodrigo Wanderley de Melo Cardoso
518a37d23f
FIXES #17414 - Adjusting export object in PluginExport to export databases with comp… (#17491)
* Adjusting export object in PluginExport to export databases with compress

Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>

* Adjusting dbi in tests and psalm requisites

Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>

* Adjusting dbi in tests and psalm requisites

Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>

* Adjusting dbi in tests and psalm requisites

Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-04-23 00:33:41 -03:00