Commit Graph

3613 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e6f08a8682 Ignore ISO-2022-CN-EXT charset for iconv
Fixes possible glibc/iconv vulnerability (CVE-2024-2961).

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 14:14:17 -05:00
Maurício Meneghini Fauth
7355ddff8d Fix XSS vulnerability on Insert page
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 14:02:28 -05:00
Maurício Meneghini Fauth
04a5ad592c
Fix import shp failing test with dbase enabled
Ref ded87e3301

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-17 20:39:25 -03:00
William Desportes
ded87e3301
Fix #16936 - Do not specify the collation when creating tables for imported data
Backport of https://github.com/phpmyadmin/phpmyadmin/pull/19035

Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-16 11:52:16 +01:00
Liviu-Mihail Concioiu
6ed8df9877 Fix badge colors
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-13 21:43:44 +01:00
Maurício Meneghini Fauth
1da6aeb6c6
Merge pull request #19499 from liviuconcioiu/17730
Fix #17730 - Make LIKE %...% as default search operator
2025-01-13 17:31:16 -03:00
Liviu-Mihail Concioiu
01013880df
Fix Undefined global variable $col_priv (#19511)
* Fix query

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix Undefined global variable $col_priv

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix test

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Update libraries/classes/Normalization.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-13 14:49:00 -03:00
Maurício Meneghini Fauth
5ac0d3c6a4
Replace $GLOBALS['l'] with TCPDF::setLanguageArray()
The l global variable was not being used by TCPDF.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-11 17:57:45 -03:00
Liviu-Mihail Concioiu
58bdf3994a Make LIKE %...% as default operator
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-04 19:55:13 +01:00
Maurício Meneghini Fauth
9ee8e20385
Merge pull request #19388 from MoonE/revert-query-stats-for-count
Revert "Show query stats for count(*) query"

Didn't manage to fix the duplicate query results, so this is reverts #19221 #19237 for now
Fixes #19245
Should reopen #16869
2024-12-25 12:12:58 -03:00
Maurício Meneghini Fauth
b76b7eef71
Merge pull request #19460 from liviuconcioiu/quotes
Add double quotes for Windows
2024-12-22 14:35:34 -03:00
William Desportes
0d961a4888
The tests testBlowfishWithInvalidSecret and testBlowfishWithValidSecret need zip and bz2 PHP exts
Or assertArrayNotHasKey('error', $messages) does not PASS.
Found this on a new PHP 8.4 setup without zip and bz2.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-21 15:06:14 +01:00
Liviu-Mihail Concioiu
6c4f66147a Add double quotes for Windows
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-12-19 16:33:45 +01:00
William Desportes
18f8ae0da1
Ref #19455 - Move all the code for revision-info.php to the Git class
Pull-request: #19458
Ref: #19455

And add one more new line

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 02:08:35 +01:00
William Desportes
b950c49a77
Fix #19455 - Support reading all the commit info from revision-info.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 01:18:29 +01:00
Maximilian Krög
61b4f6739d Don't abuse name attribute of svg elements
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-11-28 09:49:39 -03:00
Maximilian Krög
e9c3c282e4
Revert "Show query stats for count(*) query"
This reverts commit b9c793e7f8.
This reverts commit 2a4fb46391.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-11-14 01:36:30 +01:00
Liviu-Mihail Concioiu
78f3ff4554 Remove padding around varchar textarea
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-11-13 19:29:07 -03:00
Maurício Meneghini Fauth
f6ce169290
Fix issue when updating privs for various databases
The sql_query global variable should be a string, and it can be a string
in this case, which will cause an error as the string will not be
converted to array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-05 15:09:21 -03:00
Maurício Meneghini Fauth
dd83e9c50f
Backport DatabaseInterface factory for tests
- aa829af98c
- a9de979397

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-05 14:59:24 -03:00
Maurício Meneghini Fauth
12efd0a0fe
Replace replication statements with new terminology
SHOW MASTER LOGS was removed in MySQL 8.4.0 and SHOW BINARY LOGS is
available since MySQL 4.1.1.

As of MySQL 8.2.0, SHOW BINARY LOG STATUS is available.
As of MariaDB 10.5.2, SHOW BINLOG STATUS is available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-31 13:50:11 -03:00
Liviu-Mihail Concioiu
f3c7a5eb14
Remove whitespace to avoid double whitespace (#19336)
* Remove whitespace to avoid double whitespace

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-10-26 12:07:03 -03:00
Maurício Meneghini Fauth
0bf7c0fa18
Suppress deprecation message of E_STRICT constant
The E_STRICT constant was deprecated in PHP 8.4.

It's still a possible error level when using PHP 7.2 and PHP 7.3.

See:
https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-15 17:18:30 -03:00
Maurício Meneghini Fauth
598308d2aa
Add covers annotations to TransformationPluginsTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-15 02:57:54 -03:00
Maurício Meneghini Fauth
555ea56cbd
Make PHPUnit's assertions stricter
Backports #18993 to QA_5_2.

This makes merging QA_5_2 into master easier.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-12 15:33:45 -03:00
Maurício Meneghini Fauth
7fc96d6621
Call PHPUnit static methods using static calls
Backports #18907 to QA_5_2.

This makes merging QA_5_2 into master easier.
Changes done using Rector.

- #18907

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-12 14:28:22 -03:00
Maurício Meneghini Fauth
2fb2477af5
Add phpstan/phpstan-deprecation-rules package
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-09-30 17:14:50 -03:00
Maurício Meneghini Fauth
a522a9982f
Improve tests for WebAuthn
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-28 20:20:01 -03:00
Maurício Meneghini Fauth
46f2c8871c
Backport some fixes for PHPUnit 10 compatibility
- Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1070623

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-13 20:13:18 -03:00
Maurício Meneghini Fauth
587d185bb7
Validate *_structure_or_data param when exporting
- Fixes #19213

This is not the best fix, but will avoid generating an invalid file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-18 16:07:46 -03:00
Maximilian Krög
2a4fb46391
Show query stats for count(*) query
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-07-05 00:04:49 +02:00
Maurício Meneghini Fauth
7baf4f8f3c
Merge #19188 Simulate query fixes
Fixes #19187

Depends on https://github.com/phpmyadmin/sql-parser/pull/560 to work
without regression in the case of a condition `0` because now the
query is parsed and built again to remove comments.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-16 11:55:04 -03:00
Maurício Meneghini Fauth
ece6f4da0b
Fix routes cache validation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-03 20:04:59 -03:00
Maximilian Krög
3b84890770
Fix simulating query with -- comment
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-06-01 00:58:42 +02:00
Maximilian Krög
6d917b5b7f
Fix simulate multiple queries with ; in a string
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-06-01 00:16:35 +02:00
Maximilian Krög
901ea2646b
Fix column sorting with limit subquery
The used regex found the subquery limit and added the order
clause before that. Better to use Query::replaceClause here.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-05-23 23:59:43 +02:00
Maximilian Krög
626aa23841
Remove duplicate server and lang param from links
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-05-03 02:54:06 +02:00
William Desportes
0bcc3e402d
Merge #19105 - Fix #17920, Fix #18006, Fix #18962 - Preserve check constraint during column move
Pull-request: #19105
Fixes: #17920
Fixes: #18006
Fixes: #18962

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-04-28 10:46:15 +02:00
Maximilian Krög
582f2e6525
Export views after indexes
When a view uses USE INDEX syntax import failed because of
the missing index.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-28 02:11:43 +02:00
Maximilian Krög
3b992e6a13
Preserve check constraint during column move
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-19 22:01:43 +02:00
Maximilian Krög
cc2ab4bde6
Test for delimiter after exported trigger
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-01 03:11:38 +02:00
Maurício Meneghini Fauth
1d8367368e
Remove allowDeny_forbidden global
Fixes issue introduced by 2327dbf3c3.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-26 16:08:42 -03:00
Peter de Kraker
10a8943cfc
Add RocksDB support
Signed-off-by: Peter de Kraker <peterdekraker@umito.nl>
2024-03-15 20:13:58 -03:00
Maurício Meneghini Fauth
5f43edb5f8
Merge pull request #18965 from CM43210/QA_5_2
Fix #18559: Add db/table params to URL for profiling toggle

Fixes #18559
2024-03-13 21:40:40 -03:00
Alexander Bij
40794783f9 Support Azure by changing header Referer-Policy.
Signed-off-by: Alexander Bij <AlexanderBij@godatadriven.com>
2024-03-11 22:01:51 +01:00
Luca Camillo
78335aac87
Add role based auth for MySQL 8.x and compatibles (#18814)
* add role based auth for mysql 8.x or compatible like mariadb/aws rds aurora mysql

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Using cache and check server version

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* implement tests for getCurrentRolesAndHost / getCurrentRoles functions

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* fix role checks on mariadb

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Simplify code + ignore NONE as result of CURRENT_ROLE()

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fixes #18782

---------

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-02 19:31:03 -03:00
Maurício Meneghini Fauth
0048963013
Fix case where tables from wrong db is loaded in navigation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-29 16:23:30 -03:00
Maurício Meneghini Fauth
4eb4a1a0b7
Merge pull request #18937 from kamil-tekiela/Fix-#18930
Fix import of empty tables from MediaWiki
2024-02-18 18:26:33 -03:00
Cezary Marcinik
0ee3240796 Fix #18559: Add db/table params to URL for profiling toggle
Signed-off-by: Cezary Marcinik <cezary.marcinik@o2.pl>
2024-02-02 13:13:01 +01:00
Maurício Meneghini Fauth
a5e620c00b
Merge pull request #18929 from kamil-tekiela/Fix-navigation-after-table-edit
Fix navigation page after table edit
2024-01-31 11:52:41 -03:00