Commit Graph

6425 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f862ade53b
Improve unit tests for the Navigation\NodeFactory class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-05 10:55:42 -03:00
Maurício Meneghini Fauth
3abe8ed8d9
Improve Util::formatByteDown() return type hint
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 22:36:50 -03:00
Maurício Meneghini Fauth
1f935e57f7
Move the Import class to the Import namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 12:44:04 -03:00
Maurício Meneghini Fauth
f23ab54ca9
Move the Export class to the Export namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 12:28:38 -03:00
Sachin Bahukhandi
aad3b57792
Fixed the test cases (#18479)
* Fixed the test cases

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Modified the docblocks as suggested

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Update test/classes/Controllers/Table/ImportControllerTest.php

Added the changes suggested by team

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Removed sodium extension required check  as suggested

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

---------

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
2023-06-28 09:07:17 -03:00
Maurício Meneghini Fauth
531d6ad2c5
Merge pull request #18374 from MoonE/test-query-return-value
Fix dummy query return value in tests
2023-06-28 09:02:28 -03:00
Maurício Meneghini Fauth
053ee31d11
Move the routes from routes.php to the Routes class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-26 21:16:50 -03:00
Maurício Meneghini Fauth
50d97afd0e
Move Routing class to the Routing namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-26 18:16:59 -03:00
Kamil Tekiela
f8111a7a7e
Replace inline static with class static (#18490)
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-26 16:00:51 -03:00
ru-asdx
62a2b7fa34
Replace superglobals with serverrequest in ReplaceController (#18501)
* Replace superglobals with serverrequest in ReplaceController

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

* fixes

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

---------

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2023-06-26 14:48:40 -03:00
Maurício Meneghini Fauth
826b1c7aaf
Replace system monitor setting popup with a collapse button
Also replace settings links with buttons.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-19 21:31:21 -03:00
Maurício Meneghini Fauth
ddbc1afd28
Replace system monitor tab links with buttons
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-19 21:28:34 -03:00
Maurício Meneghini Fauth
6cda25211e
Replace jqPlot with Chart.js for the profiling chart
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-17 23:44:04 -03:00
Maurício Meneghini Fauth
6427b1b931
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-17 16:54:34 -03:00
Maurício Meneghini Fauth
5f7499abb0
Fix profiling chart not loading when profiling is activated
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-17 15:26:19 -03:00
Maurício Meneghini Fauth
af6f448842
Remove JS media type from HTML script tags
The type attribute is unnecessary for JavaScript resources.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-16 20:39:27 -03:00
Maurício Meneghini Fauth
f6e74de251
Extract some dependencies from the Application class
- Extracts the ErrorHandler, Config and Template dependencies from the
  Application class.
- Loads HTTP ServerRequest object after loading the user config.
- Requires a Config object for the Template class.
- Disables Twig's cache if an exception is thrown before loading the
  user config. This way a possible different cache directory will not be
  used.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-16 15:55:20 -03:00
Maurício Meneghini Fauth
c6f04fbedc
Fix results table header with transparent background
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-14 09:55:29 -03:00
Maurício Meneghini Fauth
1b7fbb9806
Merge pull request #18496 from MauricioFauth/common-class
Rename the Common class to Application
2023-06-14 09:04:51 -03:00
Maurício Meneghini Fauth
b50b80da02
Fix Table\StructureControllerTest failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-13 22:07:44 -03:00
Maurício Meneghini Fauth
951c965d6e
Change Application static methods to instance methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-13 16:36:31 -03:00
Maurício Meneghini Fauth
1aa8221276
Rename the Common class to Application
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-13 14:40:21 -03:00
Maurício Meneghini Fauth
de58d27326
Remove .pma-fieldset and related CSS classes
Replaces most of them with the Bootstrap card component.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-11 00:37:39 -03:00
Maurício Meneghini Fauth
e138c43419
Refactor UtilTest::testBackquoteForbidenWords() test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-09 19:30:29 -03:00
Maurício Meneghini Fauth
5cfd801177
Fix UtilTest::testBackquoteForbidenWords() failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-09 18:51:09 -03:00
Maurício Meneghini Fauth
e963d6610d
Fix Tests\TableTest::testGetColumns() failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-09 16:56:59 -03:00
Maurício Meneghini Fauth
a52667ee28
Merge pull request #18488 from kamil-tekiela/Add-never-type
Add never return type
2023-06-09 16:13:33 -03:00
Maurício Meneghini Fauth
bea5211660
Add basic unit test for BrowseForeignersController class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-09 15:56:09 -03:00
Kamil Tekiela
079892b49e Add never return type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-06-07 21:35:05 +01:00
Maurício Meneghini Fauth
70ff7dcd6b
Improve return type of Sql::getDetailedProfilingStats()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 16:01:10 -03:00
Maurício Meneghini Fauth
827d8de28f
Bump sql-parser version to 6.0.x-dev
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 15:49:07 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
22c6a2f9d8
Add a wrapper around the exit language construct
Creates the PhpMyAdmin\ResponseRenderer::callExit() method as a wrapper
to the exit language construct. That makes the tests more correct as the
method will always stop the code execution.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-06 21:54:07 -03:00
Maurício Meneghini Fauth
1b2138b502
Fix invalid PHPUnit covers annotation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-06 21:53:19 -03:00
Maurício Meneghini Fauth
a4940d79ec
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-06 14:46:01 -03:00
Kamil Tekiela
15bfd74c75 Move ScaleData to Ds namespace
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-06-05 12:41:23 +01:00
Kamil Tekiela
ea616f6d8a Add Gis Value Objects
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-06-05 12:41:23 +01:00
Kamil Tekiela
2400dde8c1 Add array shapes in GisPolygon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-06-05 12:34:00 +01:00
Maurício Meneghini Fauth
7b88ab16af
Fix a case where a fatal error message was not displayed
A fatal error message was not displayed when the ResponseRenderer object
already had some HTML, because the output buffer is only displayed when
there is no HTML.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-03 17:01:51 -03:00
Maurício Meneghini Fauth
b8c26e9609
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-02 16:43:57 -03:00
Maurício Meneghini Fauth
64eceff4f9
Fix state times not getting summed in the profiling table
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-02 16:31:10 -03:00
Maurício Meneghini Fauth
1be42d13de
Create the Identifiers\Identifier interface
Changes Dbal\DatabaseName, Dbal\TableName and Triggers\TriggerName to
implements the new Identifier\Identifier interface.
Moves Dbal\DatabaseName, Dbal\TableName and Triggers\TriggerName to the
Identifiers namespace.
Renames the tryFromValue() and fromValue() methods to just tryFrom() and
from() respectively.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-01 19:09:25 -03:00
William Desportes
bf9519444a
Merge #18474 - Require min php 80102 (8.1.2)
Pull-request: #18474
Ref: #18217

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-06-01 10:00:32 +02:00
Maurício Meneghini Fauth
578dbb301c
Fix SQL statement not being displayed correctly on RTL languages
Fixes #18471

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 12:48:34 -03:00
Maurício Meneghini Fauth
b11d81b40c
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 00:50:54 -03:00
Maurício Meneghini Fauth
3f587ccce4
Improve unit test for ResponseRenderer::setAjax()
Also tests the setAjax() method of Header, Footer and Console classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 00:26:48 -03:00
Maurício Meneghini Fauth
946fa9dd66
Refactor Template class to lazy load the Twig Environment
Loads the Twig Environment class only when rendering a template
for the first time, not when constructing the Template object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-30 17:55:30 -03:00
Maurício Meneghini Fauth
f110beb5f3
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-30 15:03:57 -03:00
Maurício Meneghini Fauth
b9084615f6
Fix execute routine page not working when not in a modal
Fixes #18441

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-30 15:00:22 -03:00
Maurício Meneghini Fauth
5c9847101c
Merge pull request #18453 from kamil-tekiela/quoteString
Use quoteString in CentralColumns
2023-05-30 14:28:19 -03:00