Maurício Meneghini Fauth
a9f8e503a3
Replace $GLOBALS['cfg'] with Config::$settings array
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-27 22:23:36 -03:00
Maurício Meneghini Fauth
0f31d66274
Replace $GLOBALS['cfg']['Server'] with Config::$selectedServer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-20 14:49:57 -03:00
Maurício Meneghini Fauth
83b1d6be45
Replace DatabaseInterface global var with a singleton object
...
Removes the DbiLoading middleware.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-18 14:08:10 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 23:10:10 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] ( #18149 )
...
* Remove $GLOBALS['PMA_PHP_SELF']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove $GLOBALS['PMA_PHP_SELF'] from tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Moved cleanupPathInfo to Routing
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove parse_url from getRootPath
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update baselines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove invalid tests
Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix trailing slash in path
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
...
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Kamil Tekiela
65ab1608f8
Remove dependency in DatabasesController
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-16 20:58:48 +00:00
Maurício Meneghini Fauth
d0d90551c3
Remove the dblist global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-13 21:08:00 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down
...
The idea is to only load the DBI when needed.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
72a69471e8
Remove the AbstractTestCase::assertAllSelectsConsumed method
...
Uses the DummyDbi method instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-11 16:38:37 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
aaee7961c1
Remove Template dependency from Relation class
...
Related to 2299a62e49 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
e3554879ef
Extract actions from controllers to new controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-07 21:19:43 -03:00
William Desportes
2c28a715b4
Add methods to DbiDummy and AbstractTestCase to control changing databases
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-24 02:01:00 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
b59bf1fc8a
Fix failing unit test
...
Random seed: 1623874659
PhpMyAdmin\Tests\Controllers\Server\DatabasesControllerTest::testCreateDatabaseAction
Undefined index: utf8
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-16 17:46:17 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
...
Uses the PhpMyAdmin\Version::VERSION constant instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e6ec9df84e
Remove DBI dep from Controllers/AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 22:48:44 -03:00
William Desportes
2d267861bc
Fix failing tests in a random order for seed: 1602433695
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 18:57:07 +02:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
47f0960dce
Add return type declaration to test methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
0964470643
Use parent::setGlobalConfig();
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
ae0d7127e0
Extract the drop_db action from mult_submits
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-20 20:00:52 -03:00
Maurício Meneghini Fauth
8029ea9875
Move request handling from routes to controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c
Move response handling from routes to controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
e8c5ba4f80
Convert Messages to Bootstrap Alerts
...
Replaces Messages custom styles with a Bootstrap Alerts theme
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 15:28:47 -03:00
Maurício Meneghini Fauth
0c99e03a1e
Refactor the server databases entry point
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
711ef54eca
Add Charsets::findCollationByName method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
7be0f6bfae
Reference class names in use statements
...
Sort use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00