Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
61eae4dba9
Remove navigation link generation from the Nodes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-11 23:50:17 -03:00
Maurício Meneghini Fauth
8e5cc35e72
Extract navigation icons generation from the Nodes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-08 20:40:54 -03:00
Maurício Meneghini Fauth
d8a224ec6c
Merge pull request #16880 from danielTiringer/14801-extract-small-html-elements-from-navigationtree
...
14801 - Extract small HTML elements from NavigationTree to Twig
2021-05-07 12:58:37 -03:00
Daniel Tiringer
d47cf0e0d0
Extract NavigationTree->fastFilter HTML to Twig
...
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Extract NavigationTree->fastFilter, create twig
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Remove debug data
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Rename variables and refactor template logic
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Remove unnecessary ternary
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
2021-05-05 21:36:15 +02:00
Daniel Tiringer
15f434a6d5
Extract small navtree functions to twig
...
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Extract controls to twig
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Extract quick_warp to twig
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Bugfix
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Keep class names intact
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
2021-05-05 20:44:13 +02:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 19:01:26 +02:00
William Desportes
eb258a806d
Query adjustments
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 16:19:53 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
William Desportes
9f0fc40cdb
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-02 13:40:28 +02:00
William Desportes
c781a7af75
Fix #16784 - Add a space between .second and .double CSS classes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-02 12:55:12 +02:00
William Desportes
2b42dc9bcb
Fix #16786 - JS error when clicking on phpMyAdmin logo link defined to an external website using config NavigationLogoLinkWindow = main
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-01 23:59:39 +02:00
William Desportes
43a5c3cb76
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-20 01:29:06 +01:00
William Desportes
105a51ae28
Fix #16717 - Make main drawer sync call async and remove the reflow issue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-19 19:40:07 +01:00
Maurício Meneghini Fauth
2c2127b369
Rename PMA_Theme global variable to theme
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-07 15:15:27 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
7994eb3ac6
Fix some errors found by Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-10 17:12:11 -03:00
Maurício Meneghini Fauth
5194b81e27
Check if PMA_Theme is instanceof Theme
...
Instead of checking if is not null.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-27 12:11:36 -03:00
Maurício Meneghini Fauth
a83959b3aa
Extract methods from Navigation\Nodes\Node::getData
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-20 17:44:32 -03:00
Maurício Meneghini Fauth
40c4f07de6
Use sprintf for Navigation\Nodes\Node::getData query strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-19 22:28:26 -03:00
William Desportes
66f38555d4
Ref #14801 - Remove plain HTML for PHP code for ShowDatabasesNavigationAsTree option
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 10:31:11 +01:00
William Desportes
dfce335134
Some text code improvements
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 01:03:03 +01:00
Maurício Meneghini Fauth
ac9bccf67d
Replace $GLOBALS['dbi'] with global $dbi
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
William Desportes
466ff06b3b
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-15 14:22:24 +02:00
William Desportes
62b9d8ca92
Merge #16354 - Fixes #14698 - Database named as 'New' causes PHP fatal error
...
Pull-request: #16354
Fixes : #14698
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-15 14:18:56 +02:00
Nina Pypchenko
de168edc59
Fixes #14698 . Navigation tree no longer breaks on encountering a database named 'New'
...
Signed-off-by: Nina Pypchenko <22447785+nina-py@users.noreply.github.com>
2020-09-15 20:53:02 +10:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
2358b9c4f9
Fix missing property type hints
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
652c55a5ef
Remove Config\PageSettings::getNaviSettings method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 17:40:19 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
William Desportes
fd21520711
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-01 14:40:36 +02:00
William Desportes
50af2c9baa
Fix coding standard issues
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-01 14:35:20 +02:00
William Desportes
bbe1132484
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-01 14:05:53 +02:00
William Desportes
9444234e78
Fix #16237 - Logo missing in upper left corner of navigation panel
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-01 13:55:11 +02:00
William Desportes
4f6a1fc161
Fix coding standard issues after merge of #16226
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-27 18:13:45 +02:00
William Desportes
d6a1e4aee2
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-26 19:19:57 +02:00
William Desportes
425c1c32a7
Fix #16226 - Error 500 after copying a table
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-26 19:11:53 +02:00
Maurício Meneghini Fauth
2529824c23
Extract change column action from table structure index method
...
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 18:20:48 -03:00
William Desportes
5d933e03b9
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:40:25 +02:00
William Desportes
d06ec742e3
Fix an "Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek()"
...
Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek(): Argument #2 ($offset) must be of type int, string given, called in libraries/classes/Navigation/Nodes/NodeDatabase.php on line 488 and defined in libraries/classes/DatabaseInterface.php:2724"
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:06:40 +02:00
William Desportes
055a9bf3bc
Be sure to cast the result and not a possibly undefined index that would send a notice
...
Ref: 490d731d6c
2020-06-05 14:03:13 +02:00
William Desportes
7623fed14a
Fix all found errors and add typehints if possible on NavigationTree class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:50:49 +02:00
William Desportes
62baf0b8ea
Change Node::getChild return to ?Node
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:10:35 +02:00
William Desportes
6266583e63
Add some typehints on NavigationTree
...
Ref: #16158
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 09:18:51 +02:00
William Desportes
490d731d6c
Add some fallbacks if the data is not available
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:25:23 +02:00
William Desportes
a1a6dd99ea
Move vPath, aPath, pos to paths_nav using data-* attributes
...
Ref: d944f0851eaec59d5007
2020-05-31 00:58:16 +02:00
William Desportes
aec59d5007
Move pos3_name and pos3_value to pos3_nav using data-* attributes
...
Ref: d944f0851e
2020-05-31 00:47:11 +02:00
