Commit Graph

343 Commits

Author SHA1 Message Date
William Desportes
821dce6c80
Fix #14301 - Javascript error when editing a JSON data type column
Fixes: #14699
Fixes: #14301
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:34:30 +02:00
William Desportes
c793b998a7
ESLINT fixes
Make eslint green for CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 08:30:48 +01:00
William Desportes
2cf2959098
Fix: #14425 - Null Checkbox automatically unmarked
Fixes: #14425
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 12:21:58 +01:00
Kartik Kathuria
219df7a48f FixedError#14425 Null Checkbox automatically unmarked
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-02-26 00:03:02 +05:30
Thomas Wong
4a5ae16eff Fix textarea failed to popup (issue #13518)
Signed-off-by: Thomas Wong <ufosaga@gmail.com>
2018-02-09 10:13:56 +08:00
Maurício Meneghini Fauth
ef99fef8d6 Change ESLint's eqeqeq to error
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 21:30:14 -03:00
Maurício Meneghini Fauth
97323989cb Change ESLint's brace-style to error
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 17:58:45 -03:00
Maurício Meneghini Fauth
00e1ca9b66 Automatic fixes by ESLint
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 14:22:35 -03:00
Madhura Jayaratne
bf08e0ab6d Merge branch 'QA_4_7' 2017-08-29 23:33:43 +10:00
Madhura Jayaratne
047de9cdf4 Merge branch 'QA_4_7' of github.com:phpmyadmin/phpmyadmin into QA_4_7 2017-08-29 23:27:22 +10:00
Madhura Jayaratne
f4d77f905d Fix #13177 Grid editing repeats action after error
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2017-08-29 23:25:14 +10:00
Michal Čihař
ff84a36e09 Merge branch 'QA_4_7' 2017-07-17 16:57:23 +02:00
Michal Čihař
6a3d51e084 Make hex inline editor accept 0x at the begining
Issue #13387

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 16:52:49 +02:00
Michal Čihař
0ded26965b Merge pull request #13317 from manishbisht/json-editor
JSON data shown in JSON format while editing
2017-06-28 17:01:26 +03:00
J.M
0950bd9bdb Make grid editor NULL checkbox text clickable
So you can click the text "NULL" in addition to the checkbox itself.

Signed-off-by: J.M <jm@jublo.net>
2017-06-24 11:32:59 +02:00
Manish Bisht
bae477477b data shown in JSON format if the data-type is json
Signed-off-by: Manish Bisht <manish.bisht490@gmail.com>
2017-06-15 23:00:43 +05:30
Michal Čihař
f7bb752573 Automatically add token to all AJAX requests
This way we don't have to do the same in every AJAX request, it can be
done just once in shared handler.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 11:45:40 +02:00
Madhura Jayaratne
ea5640fd9c Merge branch 'QA_4_7' 2017-05-17 23:43:32 +10:00
Madhura Jayaratne
660123d228 Fix #13177 Grid editing repeats action after error
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2017-05-17 23:41:56 +10:00
Gemorroj
6d2bf012d2 Simplify HTML: <input></input> -> <input />
Signed-off-by: Gemorroj <wapinet@gmail.com>
2017-04-28 16:09:20 +02:00
Dan Ungureanu
1ca19f0ac1 Replaced deprecated jQuery calls.
'bind' and 'unbind', 'delegate' and 'undelegate' have been deprecated in
favor of 'on' and 'off'.

Partially fixes #13166.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2017-04-10 13:06:32 +03:00
Michal Čihař
91a16c90c8 Fixed editing of rows with text primary key
We do htmlspecialchars in PHP, so we should not URL de/encode here.

Fixes #13088

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-16 15:12:38 +01:00
Michal Čihař
55880451eb Always use \r\n as newline when editing fields
Convert \n to \r\n during inline editing to be consistent with form submitted
value.

The internal browser representation has to be just \n while form submitted
value \r\n, see specification:

https://www.w3.org/TR/html5/forms.html#the-textarea-element

Fixes #12918

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-23 16:28:13 +01:00
Michal Čihař
c77d8cff25 Do not use deprecated $.parseJSON
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 14:27:39 +01:00
Deven Bansod
c2f7f82a98 If date is invalid acc to datePicker plugin, close the UI
There are partial dates like '0000-00-00', '2016-00-00' etc. which are
rejected by the Datetimepicker JQuery plugin, but can be accepted by MySQL server

Fix #12651

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-26 21:29:54 +05:30
flash1452
0d8085c070 Fix #11864 Move noSelect mehthod to makegrid.js
Signed-off-by: Vishal Pandey <vishpandey2014@gmail.com>
2016-02-03 14:06:51 +01:00
Michal Čihař
cd1d926a57 Remove unused variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 13:56:58 +01:00
Michal Čihař
c3e057b942 Remove unused parameters
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 13:56:15 +01:00
Madhura Jayaratne
723b4bdfbe Fix #11846 Grid editing window is disabled the second time
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-01-12 20:21:12 +11:00
Michal Čihař
7dd415776a Remove unused parameters
Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-22 09:17:51 +01:00
Deven Bansod
393f0cfc21 Merge branch 'QA_4_5' 2015-12-21 18:28:44 +05:30
Deven Bansod
fe5f69c401 Prevent unnecessary update when nothing is changed
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-12-21 18:27:03 +05:30
Michal Čihař
5abdf6886b Merge remote-tracking branch 'origin/QA_4_5' 2015-12-21 11:16:39 +01:00
Deven Bansod
0b64ff7f72 Fix #11724 : live data edit of big sets is not working
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-12-21 13:53:03 +05:30
Hugues Peccatte
ff4517ca60 Remove useless variables and simplify code.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 22:36:54 +01:00
Madhura Jayaratne
000d679d63 Merge branch 'QA_4_5' 2015-12-10 07:07:28 +11:00
Madhura Jayaratne
269fcd2a54 issue #11724 Temporary fix for live data edit of big sets is not working
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-12-10 07:01:42 +11:00
Nisarg Jhaveri
296caced73 Add grid-edit update query only to last query result box
Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
2015-11-30 01:07:34 +05:30
Marc Delisle
db19812acf Merge branch 'QA_4_4' 2015-08-05 09:46:18 -04:00
Dan Ungureanu
bbd581a906 Fixes #11320.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-05 09:43:14 -04:00
Madhura Jayaratne
805b0d7860 Fix #11322 Missing null checkbox when grid editing a null cell
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-27 12:29:26 +05:30
Marc Delisle
7f7e45de6b Merge branch 'QA_4_4' 2015-07-13 06:54:21 -04:00
Jack Smith
e88f290d44 Remove confusing second inline edit window (bug #4826)
When a long truncated text field is being inline edited it pops up a second edit window which could be confusing. Removed it.

Signed-off-by: Jack Smith <devjacksmith@gmail.com>
2015-07-13 06:52:07 -04:00
Madhura Jayaratne
42a4088943 More local variables
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-02 22:52:09 +05:30
Madhura Jayaratne
81bd7f38af More local variables
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-02 20:55:42 +05:30
Nisarg Jhaveri
befe89ad4e Make Scrutinizer Happy
Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
2015-06-30 21:58:21 +05:30
Deven Bansod
1ef602ccfd RFE#1359 - Ctrl Navigation in Grid Editor
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-06-04 12:18:13 +05:30
Madhura Jayaratne
4354049fde Merge branch 'QA_4_4'
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-22 19:04:49 +05:30
Madhura Jayaratne
6c7ee747b7 #4918 Date field popup dialog position bug
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-22 14:55:25 +05:30
Marc Delisle
bb7a254ce4 rfe #1146 Show original size of truncated columns
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-04-30 09:42:24 -04:00