Commit Graph

418 Commits

Author SHA1 Message Date
Piyush Vijay
bf0198938c Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

(cherry picked from commit e58dd74c40)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 04:53:08 -03:00
Maurício Meneghini Fauth
bec8888e7c Revert "Merge pull request #14046 from shucon/login"
This reverts commit 5a1ceef67d, reversing
changes made to 063f380639.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:07:17 -03:00
Maurício Meneghini Fauth
7a6b3cbba8 Revert "Cannot read property sql_query of undefined: #14104 issue fix (#14105)"
This reverts commit ad86eab974.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:06:53 -03:00
Piyush Vijay
ad86eab974 Cannot read property sql_query of undefined: #14104 issue fix (#14105)
Fix #14101
Fix #14104

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-03-26 13:25:33 -03:00
Michal Čihař
5a1ceef67d
Merge pull request #14046 from shucon/login
Restore SQL query after session expire
2018-03-16 13:07:20 +01:00
Saksham Gupta
0eaf1b108c Add cookie restore and empty save error
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-02 11:50:13 +05:30
Michal Čihař
f4026f60a4 Merge branch 'QA_4_7' 2018-03-01 16:02:57 +01:00
Michal Čihař
984c6a0054 Honor arg_separator in AJAX requests
Fixes #13940

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-03-01 15:50:41 +01:00
Saksham Gupta
8537d0125a Fix whitespaces
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-01 02:20:53 +05:30
Saksham Gupta
e5ff7f34fe Restore SQL query after session expire
Partially Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/13654

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-01 02:17:28 +05:30
Michal Čihař
1f00c99be9 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 1fc566fd90)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 16:01:00 -03:00
Michal Čihař
be7d5ee738 Simplify handling of long URLs in Util::linkOrButton
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 3b9fb2b664)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 13:02:58 -03:00
Michal Čihař
1fc566fd90 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-08 17:35:32 +01:00
xypXiong
f65c3dc2ed fix #13727 copied table data add number of orders (#13823)
Signed-off-by: yanping <xyp.xiong@gmail.com>
2017-11-28 10:40:42 +01:00
Michal Čihař
3b9fb2b664 Simplify handling of long URLs in Util::linkOrButton
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:33:53 +01:00
Maurício Meneghini Fauth
ef99fef8d6 Change ESLint's eqeqeq to error
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 21:30:14 -03:00
Maurício Meneghini Fauth
00e1ca9b66 Automatic fixes by ESLint
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 14:22:35 -03:00
Jakub Stanecki
5b1ed4c326 Added remember table sorting when browsing table
Signed-off-by: Jakub Stanecki <staneckijakub@gmail.com>
2017-09-11 21:37:29 +02:00
akritianand
4f6335bb59 Do not include messages when copying results
Unnecessary data should not come in clipboard copied table.

Fixes #13617 

Signed-off-by: Akriti Anand <anand.akriti@gmail.com>
2017-09-04 09:55:12 +02:00
Michal Čihař
5e9bb1b584 Merge branch 'QA_4_7' 2017-08-02 08:19:45 +02:00
Michal Čihař
ef891b2bba Simplify code for copying to clipboard
Honestly I don't understand the old code, but it breaks on fields with
applied transformations, while using simply text() works fine.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:18:37 +02:00
Michal Čihař
626c2b3a29 Remove not needed variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:14:12 +02:00
Michal Čihař
12f54fd0cf Fixed copy results to clipboard
Copy only results table, not all tables on the page.

Fixes #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:12:41 +02:00
Michal Čihař
33dd51eaf7 Move SQL copy handler to sql.js
Issue #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:11:32 +02:00
Michal Čihař
f7bb752573 Automatically add token to all AJAX requests
This way we don't have to do the same in every AJAX request, it can be
done just once in shared handler.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 11:45:40 +02:00
Michal Čihař
135e82cc69 Replace jquery.cookie.js with js.cookie.js
The latter one is suggested replacement for no longer maintained
jquery.cookie.js.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 10:19:09 +02:00
Gemorroj
6d2bf012d2 Simplify HTML: <input></input> -> <input />
Signed-off-by: Gemorroj <wapinet@gmail.com>
2017-04-28 16:09:20 +02:00
Dan Ungureanu
1ca19f0ac1 Replaced deprecated jQuery calls.
'bind' and 'unbind', 'delegate' and 'undelegate' have been deprecated in
favor of 'on' and 'off'.

Partially fixes #13166.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2017-04-10 13:06:32 +03:00
Michal Čihař
dbce3b54d1 Fix query simulating for more servers
The server parameter was missing.

Fixes #13047

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-03 14:48:11 +01:00
Michal Čihař
c77d8cff25 Do not use deprecated $.parseJSON
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 14:27:39 +01:00
Deven Bansod
857be4efdf Some more Token mismatch errors, Issue #12523
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-02 14:03:51 +05:30
Michal Čihař
ad5187383d Automatically save SQL query in browser local storage
..when available rather than in cookie as we do not want to send huge
cookies with SQL query there and back.

Issue #12251
Issue phpmyadmin/docker#32

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-27 09:15:28 +02:00
Madhura Jayaratne
413f66f4c2 Fix #12125 Cannot highlight a column if I scroll down from the top of the table
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-03-31 21:34:43 +11:00
Hugues Peccatte
ff4517ca60 Remove useless variables and simplify code.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 22:36:54 +01:00
Deven Bansod
1f4cff8fc6 Fix misspelt word
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-11-29 23:05:30 +05:30
Achilles-96
f72864cb2b Fixes issue 11504
Signed-off-by: Achilles-96 <raghuram.vadapalli@research.iiit.ac.in>
2015-11-29 15:44:56 +05:30
Atul Pratap Singh
50a9c19fe4 Rename 'Print view' to 'Print'
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2015-11-18 19:46:28 +05:30
Achilles-96
d336301566 Fixes issue #11504
Signed-off-by: Achilles-96 <raghuram.vadapalli@research.iiit.ac.in>
2015-11-17 22:32:05 +05:30
Madhura Jayaratne
3e244c89be Hide the jqPlot details inside the method
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-07 08:08:20 +11:00
Marc Delisle
a815444712 Merge branch 'QA_4_5' 2015-09-24 09:28:13 -04:00
Marc Delisle
5bad4dab82 Fixes #11495 'PMA_Microhistory' is undefined
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-24 09:27:17 -04:00
Madhura Jayaratne
914b1cbd51 POST requests for deleting rows
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-28 15:39:08 +10:00
Hugues Peccatte
71666da392 Fix unterminated statements.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-20 21:53:28 +02:00
Madhura Jayaratne
e70d2cf551 bug #4981 Uncaught TypeError: Cannot read property 'attr' of null
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-14 17:03:30 +05:30
Atul Pratap Singh
3031153746 Fix non-html5 microhistory behavior
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2015-07-09 16:45:52 +05:30
Atul Pratap Singh
563b3b709d Move to HTML5 API for maintaining AJAX history
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2015-07-09 13:21:36 +05:30
Atul Pratap Singh
9b101e2ab7 Separate microhistory code conditionally
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2015-07-09 10:32:55 +05:30
Madhura Jayaratne
42a4088943 More local variables
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-02 22:52:09 +05:30
Madhura Jayaratne
3e9b97ef6c These are local variables
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-02 22:27:46 +05:30
Madhura Jayaratne
ac0d22638d Merge branch 'QA_4_4' 2015-06-16 17:15:59 +05:30