Commit Graph

432 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
059705f06e
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 19:53:54 -03:00
Kamil Tekiela
c19f6ae9ce Fix isNumeric
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-10 15:02:15 +01:00
Jesper Skytte Marcussen
23995b3c73
Adding inputmode numeric to integer fields (#17753)
* Adding inputmode numeric to integer fields

To easier use phpMyAdmin on touch devices with virtual keyboards, adding the inputmode ensures that the correct virtual keyboard is shown per default when focusing the field.

See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode for more information.

Related to #17745.

Signed-off-by: Jesper Skytte <jesper@skytte.it>
2022-10-09 15:26:32 -03:00
Maurício Meneghini Fauth
135cd76d3b
Fix exception for invalid db and table names for the privileges page
Related to #17729

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-30 20:49:21 -03:00
Maurício Meneghini Fauth
bb97ed988f
Reduce usage of the containerBuilder global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29 22:36:46 -03:00
Maurício Meneghini Fauth
f54cc49f86
Remove loadContainerBuilder call from AbstractTestCase::setUp method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29 20:22:31 -03:00
Maurício Meneghini Fauth
a56b425a2a
Extract /console/bookmark/add action from ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-21 00:06:14 -03:00
Maurício Meneghini Fauth
c2018c4c21
Extract /console/bookmark/refresh action from ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-20 21:55:28 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
c36dd24b59
Add unit tests for Table\Structure\SpatialController class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-20 18:21:07 -03:00
Maurício Meneghini Fauth
ec03bac629
Add unit tests for Table\Structure\UniqueController class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-20 17:23:15 -03:00
Maurício Meneghini Fauth
8645920f0d
Extract normalization's partial dependencies action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 22:49:07 -03:00
Maurício Meneghini Fauth
28d53fe50b
Extract normalization's create new column action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 21:38:55 -03:00
Maurício Meneghini Fauth
a37e5681c8
Extract normalization's get columns action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 20:48:48 -03:00
Maurício Meneghini Fauth
c550d41d1d
Extract normalization's add new primary action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 16:45:30 -03:00
Maurício Meneghini Fauth
66970049cc
Rename NormalizationController to Normalization\MainController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 15:57:05 -03:00
Maurício Meneghini Fauth
a5024edcc5
Extract normalization's move repeating group action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 15:31:41 -03:00
Maurício Meneghini Fauth
97c5c01a87
Extract normalization 3NF create new tables action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 14:43:13 -03:00
Maurício Meneghini Fauth
c9bccf3b3d
Extract normalization 2NF create new tables action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 13:47:03 -03:00
Maurício Meneghini Fauth
b92e95d062
Extract normalization 3NF new tables action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 11:22:56 -03:00
Maurício Meneghini Fauth
efc04db52b
Extract normalization 3NF step 1 action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-30 17:49:12 -03:00
Maurício Meneghini Fauth
dd25695569
Extract normalization 2NF new tables action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-30 00:36:58 -03:00
Maurício Meneghini Fauth
51db9db3dd
Extract normalization 2NF step 1 action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-29 21:10:52 -03:00
Maurício Meneghini Fauth
bcb02c2e01
Extract normalization 1NF step 4 action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-29 20:11:56 -03:00
Maurício Meneghini Fauth
08297d96b8
Extract normalization 1NF step 3 action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-29 19:03:35 -03:00
Maurício Meneghini Fauth
6e8600f321
Extract normalization 1NF step 2 action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 22:52:28 -03:00
Maurício Meneghini Fauth
398bdae484
Extract normalization 1NF step 1 action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 18:33:34 -03:00
Maurício Meneghini Fauth
9c9ae5069e
Extract HTML from Normalization::getHtmlForNormalizeTable method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 11:56:27 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
b0c4426a43
Add basic tests for Controllers\Table\Partition classes
Adds better message for invalid partition name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-27 15:29:02 -03:00
Maurício Meneghini Fauth
c6c28498e4
Add basic tests for Controllers\Table\Maintenance classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-26 20:55:36 -03:00
Maurício Meneghini Fauth
31bfbbe816
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-20 20:57:41 -03:00
Maurício Meneghini Fauth
dbe3db564e
Fix Enum/Set editor error when creating a new column
Fixes #17551

https://github.com/phpmyadmin/phpmyadmin/issues/17551#issuecomment-1136074722

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-20 20:54:07 -03:00
Maurício Meneghini Fauth
cba9b38a28
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:51:12 -03:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:28:43 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down
The idea is to only load the DBI when needed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
72a69471e8
Remove the AbstractTestCase::assertAllSelectsConsumed method
Uses the DummyDbi method instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-11 16:38:37 -03:00
Maurício Meneghini Fauth
4930c7a119
Remove the AbstractTestCase::assertAllQueriesConsumed method
Uses the DummyDbi method instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-11 14:58:11 -03:00
Maurício Meneghini Fauth
8543e0abe5
Load DBI into container only when needed by the test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-11 13:42:22 -03:00
Maurício Meneghini Fauth
e4ea2308c0
Assign Messages global var to the window object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-02 11:23:07 -03:00
Maurício Meneghini Fauth
065d6d618c
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-10 00:40:13 -03:00
Maurício Meneghini Fauth
3412fb2c03
Add ChangeLog entry for #17271
Fixes #17271

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-10 00:27:14 -03:00
Maurício Meneghini Fauth
8116903ba6
Create dbi for each test in Table\ReplaceControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-08 19:54:14 -03:00
Maurício Meneghini Fauth
3ac11ffa75
Introduce the ServerRequest object to ChangeController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-08 19:12:19 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
27bdd0d64d
Extract InsertEdit dependencies to constructor params
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-01 23:42:47 -03:00
Liviu-Mihail Concioiu
fb1afbe444 Fix database names dissapearing from Processes tab
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-30 00:44:38 +02:00
Liviu-Mihail Concioiu
e9a5ec01f5 Revert "Fix database names dissapearing from Processes tab"
This reverts commit af4434dee2.
2022-05-30 00:39:39 +02:00
Liviu-Mihail Concioiu
af4434dee2 Fix database names dissapearing from Processes tab
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-05-29 19:54:04 +02:00