gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,528 Commits 12 Branches 481 Tags 2.4 GiB
fbdca09dd0
Commit Graph

199 Commits

Author SHA1 Message Date
Jesper Skytte Marcussen
23995b3c73
Adding inputmode numeric to integer fields (#17753) 
* Adding inputmode numeric to integer fields

To easier use phpMyAdmin on touch devices with virtual keyboards, adding the inputmode ensures that the correct virtual keyboard is shown per default when focusing the field.

See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode for more information.

Related to #17745.

Signed-off-by: Jesper Skytte <jesper@skytte.it>
 2022-10-09 15:26:32 -03:00
Maurício Meneghini Fauth
135cd76d3b
Fix exception for invalid db and table names for the privileges page 
Related to #17729

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 20:49:21 -03:00
Maurício Meneghini Fauth
bb97ed988f
Reduce usage of the containerBuilder global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 22:36:46 -03:00
Maurício Meneghini Fauth
f54cc49f86
Remove loadContainerBuilder call from AbstractTestCase::setUp method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 20:22:31 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
c36dd24b59
Add unit tests for Table\Structure\SpatialController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-20 18:21:07 -03:00
Maurício Meneghini Fauth
ec03bac629
Add unit tests for Table\Structure\UniqueController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-20 17:23:15 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
b0c4426a43
Add basic tests for Controllers\Table\Partition classes 
Adds better message for invalid partition name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-27 15:29:02 -03:00
Maurício Meneghini Fauth
c6c28498e4
Add basic tests for Controllers\Table\Maintenance classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-26 20:55:36 -03:00
Maurício Meneghini Fauth
31bfbbe816
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-20 20:57:41 -03:00
Maurício Meneghini Fauth
dbe3db564e
Fix Enum/Set editor error when creating a new column 
Fixes #17551

https://github.com/phpmyadmin/phpmyadmin/issues/17551#issuecomment-1136074722

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-20 20:54:07 -03:00
Maurício Meneghini Fauth
cba9b38a28
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:51:12 -03:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found 
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:28:43 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down 
The idea is to only load the DBI when needed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
72a69471e8
Remove the AbstractTestCase::assertAllSelectsConsumed method 
Uses the DummyDbi method instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-11 16:38:37 -03:00
Maurício Meneghini Fauth
8543e0abe5
Load DBI into container only when needed by the test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-11 13:42:22 -03:00
Maurício Meneghini Fauth
8116903ba6
Create dbi for each test in Table\ReplaceControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-08 19:54:14 -03:00
Maurício Meneghini Fauth
3ac11ffa75
Introduce the ServerRequest object to ChangeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-08 19:12:19 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
27bdd0d64d
Extract InsertEdit dependencies to constructor params 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-01 23:42:47 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 16:25:39 -03:00
Maurício Meneghini Fauth
9550066810
Introduce the ServerRequest object to AddFieldController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-04 15:55:22 -03:00
Maurício Meneghini Fauth
1b9e6b6088
Inline DbiDummy instances in some test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-19 17:43:10 -03:00
Maurício Meneghini Fauth
2cf3497a0e Inline dbi creation in some test classes 
Creates a new instance of DatabaseInterface for each test.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-19 11:22:34 -03:00
Maurício Meneghini Fauth
a9de979397 Inline dbi creation in some test classes 
Creates a new instance of DatabaseInterface class for each test.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-18 21:50:18 -03:00
Maurício Meneghini Fauth
cf7fa38feb
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-26 01:39:57 -03:00
Maurício Meneghini Fauth
3befb5f8d0
Remove debugSQLInfo JS global variable 
Replaces it with a ConsoleDebug property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-22 15:24:13 -03:00
Maurício Meneghini Fauth
62683a0115 Add method to AbstractController to send error messages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-20 16:39:33 -03:00
Maurício Meneghini Fauth
0d4d2a4935
Add exceptions for invalid identifier names 
- Adds the PhpMyAdmin\Dbal\InvalidIdentifierName exception
- Adds the PhpMyAdmin\Dbal\InvalidDatabaseName exception
- Adds the PhpMyAdmin\Dbal\InvalidTableName exception

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-19 17:35:35 -03:00
Maurício Meneghini Fauth
619d4acb4a
Refactor DropColumnConfirmationController class 
- Removes global variables
- Redesigns the HTML to use Bootstrap styles
- Add more tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-18 15:36:07 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
48fbce3ca3
Add basic test for Table\AddFieldController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-28 15:10:12 -03:00
Maurício Meneghini Fauth
1c66f554ab
Add basic test for Table\ChangeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-28 13:55:23 -03:00
Maurício Meneghini Fauth
5bc129d7c1
Add unit tests for Table\ChangeRowsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-28 13:19:44 -03:00
Maurício Meneghini Fauth
3a51491d8f
Add basic test for Table\ChartController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-27 12:16:23 -03:00
Maurício Meneghini Fauth
9facf6524c
Add basic test for Table\CreateController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-27 11:15:11 -03:00
Maurício Meneghini Fauth
0b37a84f79
Fix Table/DeleteConfirmControllerTest db name 
Introduced by 49a39313c2.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-27 09:57:28 -03:00
Maurício Meneghini Fauth
49a39313c2
Add basic test for Table\DeleteConfirmController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-26 08:52:42 -03:00
Maurício Meneghini Fauth
40135c26cc
Add basic test for Table\DeleteRowsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-25 16:44:49 -03:00
Maurício Meneghini Fauth
9ebb17dd50
Add basic test for Table\DropColumnConfirmationController 
Fixes 476a80c277

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-25 16:02:06 -03:00
Maurício Meneghini Fauth
476a80c277
Add basic test for Table\DropColumnConfirmationController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-25 16:00:18 -03:00
Maurício Meneghini Fauth
60f75803e8
Add basic test for Table\DropColumnController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 22:29:22 -03:00
Maurício Meneghini Fauth
e1dc022d33
Add basic test for Table\Structure\SaveController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 18:53:58 -03:00
Maurício Meneghini Fauth
c3acdeeb16
Add basic test for Table\ExportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 16:52:27 -03:00
Maurício Meneghini Fauth
6d2246f912
Add unit tests for Table\ExportRowsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 15:35:26 -03:00
Maurício Meneghini Fauth
687a83923a
Add basic test for Table\GetFieldController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-24 12:54:43 -03:00