Commit Graph

203 Commits

Author SHA1 Message Date
William Desportes
d82b43c5ff
Fixup testGetMySQLDocuURL after changing setVersion() in DBI
and fix a phpc issue

See: cac09436c9

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:38:12 +02:00
Maurício Meneghini Fauth
059705f06e
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 19:53:54 -03:00
Kamil Tekiela
c19f6ae9ce Fix isNumeric
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-10 15:02:15 +01:00
Maurício Meneghini Fauth
ba02d77c53
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-09 15:18:27 -03:00
Mo Sureerat
f0a938f783
Fix issue - Edit/Copy/Delete row doesn't work when using GROUP BY (#17758)
* Fix issue - Edit/Copy/Delete row doesn't work when using GROUP BY

Root cause: GROUP_FLAG and NUM_FLAG have the same flags value 32768

Reference to https://www.php.net/manual/en/mysqli-result.fetch-fields.php

Fixes #17756

Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-09 14:33:21 -03:00
Maurício Meneghini Fauth
9cdf0b1cd9
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-03 21:00:20 -03:00
William Desportes
71035fd9b0
Add a test for the compressed option for MariaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-09-30 23:19:09 +02:00
Maurício Meneghini Fauth
262e3e8129
Add some unit tests for the Util class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-06 22:14:14 -03:00
Maurício Meneghini Fauth
b20d7f3a04
Remove UtilTest's setUp method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-05 17:31:36 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
4ad66f464f
Fix some errors reported by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-28 22:53:38 -03:00
Maurício Meneghini Fauth
4891f2dc74
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-21 14:45:17 -03:00
Maurício Meneghini Fauth
4c1668d663
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-21 14:29:25 -03:00
Maurício Meneghini Fauth
533766b3d7
Merge pull request #17437 from erolatreston/switch-user-QA_5_1
Allow authentication plugin to switch database users
2022-04-21 13:55:47 -03:00
Maurício Meneghini Fauth
ce14c14544
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-05 20:26:56 -03:00
Maurício Meneghini Fauth
cd1bef6c70
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-05 19:50:06 -03:00
Maurício Meneghini Fauth
e33e164e90
Fix PhpMyAdmin\Util::getConditionValue tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-05 15:50:05 -03:00
Erol Guven
8920eae5db Allow authentication plugin to switch database users
Signed-off-by: Erol Guven <erol.guven@appian.com>
2022-03-09 11:53:50 +00:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 22:59:33 -03:00
Kamil Tekiela
1270efc2a9
Refactor util.php (#17212)
* Remove extra space

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove null checks on properties that cannot be null

The value could be null only if the property exists in stdClass
returned by mysqli but is null. Mysqli doesn't do that. Unless the value
can be null in some other way, this check is redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add psalm-return

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $handle parameter of getUniqueCondition()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Type hint the $row parameter

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-02 17:37:09 -03:00
Maurício Meneghini Fauth
a835d7cfcc
Remove array support from Util::backquote
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-10 19:33:09 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
4834c5fe7d
Remove bypass flag from Util::backquote method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-26 11:51:34 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
William Desportes
dd4f0571ac
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-14 14:42:12 +02:00
William Desportes
89365207c6
Add test cases for phpmyadmin/docker#328
Closes: phpmyadmin/docker#328

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-13 02:35:35 +02:00
Maximilian Krög
c1c6b01195
Use correct min MySQL version for axis-order (8.0.1)
There was no version 8.0.10
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2021-07-20 01:28:29 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
a96be01b6d
Fix some failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-13 15:01:07 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
280a201f79
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-28 17:42:02 +02:00
Maurício Meneghini Fauth
fd4cf3b4f7
Add tests for the Util::getUniqueCondition method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-25 14:43:15 -03:00
William Desportes
6699fb1923
Fix 32-bit issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-24 22:03:41 +02:00
Maurício Meneghini Fauth
878ab12dec
Change Util::getUrlForOption fallback to base route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-11 20:19:05 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:51:45 +02:00
William Desportes
94add64100
Add tests for #16777
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 16:46:08 +02:00
William Desportes
ba35901594
Merge branch 'origin/QA_5_1' into master
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:53:14 +02:00
William Desportes
3ba356759e
Merge #16818 - Fix #16792 - Remove useless htmlspecialchars on URL generation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:30:00 +02:00
William Desportes
f547765120
Add testcases for #16797
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 22:08:52 +02:00
William Desportes
7a3978a948
Remove useless htmlspecialchars on URL generation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 17:23:12 +02:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 01:13:58 +01:00
William Desportes
942a252b46
Fix #16694 - Do not escape _ for TABLE_NAME in information schema
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-22 23:20:23 +01:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 15:03:39 -03:00
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00