Commit Graph

1275 Commits

Author SHA1 Message Date
Piyush Vijay
1c3660d213 Comment code in js/functions.js to disable tirggering of codemirror loading from js/functions.js
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-08-14 18:11:18 +05:30
Piyush Vijay
0b5c9b3eea Add isStorageSupport in functions.js for code compatibility and add config.js in file loading object.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-08-02 20:54:53 +05:30
Piyush Vijay
ce8d11c858 Add todo for code that will not be used in future after revamping all
the files.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-07-26 02:31:26 +05:30
Piyush Vijay
491b4871a7 Commented code, debug statements and unused variable in Script.php is removed.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-07-26 02:31:25 +05:30
Piyush Vijay
38cfa4630c Some functions moved from server_privilages.js to functions.js and typo error removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-07-26 02:31:25 +05:30
Maurício Meneghini Fauth
c697a872a1 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-03 22:49:38 -03:00
Maurício Meneghini Fauth
fca206f27a Fix some JavaScript coding style issues
Automatic fixes by ESLint

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-03 22:46:48 -03:00
Maurício Meneghini Fauth
8343e67759 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-03 21:22:11 -03:00
Maurício Meneghini Fauth
9bbc4c3441 Add ChangeLog entry for #14045
Fix trailing whitespace in js/functions.js

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-03 21:18:39 -03:00
Aswani Prakash
636dd335c6 #14045 issue fix filtering is slow (#14236)
* 14045 issue fix filtering is slow

Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>

* space issue

Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
(cherry picked from commit b978def8dc)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-03 21:08:01 -03:00
Aswani Prakash
b978def8dc #14045 issue fix filtering is slow (#14236)
* 14045 issue fix filtering is slow

Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>

* space issue

Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
2018-07-03 21:05:42 -03:00
Maurício Meneghini Fauth
1f76f859fb
Merge pull request #14204 from Piyush3079/PMA_14189
Remember table's sorting broken in 4.8.0 issue: #14189 fixed
2018-05-12 04:51:29 -03:00
Maurício Meneghini Fauth
2936492555 Revert "Replace .focus() with .on()"
This reverts commit d18076eb96.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 02:40:33 -03:00
Maurício Meneghini Fauth
d18076eb96 Replace .focus() with .on()
.focus() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 02:17:51 -03:00
Maurício Meneghini Fauth
8f8e3c26c9 Replace .click() with .on()
.click() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-11 23:58:35 -03:00
Maurício Meneghini Fauth
f4fedc20ee Replace .change() with .on()
.change() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-11 20:45:36 -03:00
Maurício Meneghini Fauth
dc72341b75 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:44:19 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp()
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:39:53 -03:00
Piyush Vijay
b621f0dd9a
javascript warnings of eslint removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-04-16 19:42:37 +05:30
Maurício Meneghini Fauth
7a6b3cbba8 Revert "Cannot read property sql_query of undefined: #14104 issue fix (#14105)"
This reverts commit ad86eab974.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:06:53 -03:00
Maurício Meneghini Fauth
ece9fe84c9 Revert "Remove redundant else"
This reverts commit 8b04a2b2a7.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:06:20 -03:00
Maurício Meneghini Fauth
8b04a2b2a7 Remove redundant else
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-26 13:27:51 -03:00
Piyush Vijay
ad86eab974 Cannot read property sql_query of undefined: #14104 issue fix (#14105)
Fix #14101
Fix #14104

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-03-26 13:25:33 -03:00
Maurício Meneghini Fauth
b8e7e9fa3b Merge branch 'QA_4_7' 2018-03-23 03:11:14 -03:00
Isaac Bennetch
4d7ca8fe04 Fixes JavaScript error when editing rows with Internet Explorer
Fixes #14060
Fixes #14096

Internet Explorer does not support StartsWith()

See the comments by
tm8544 at https://github.com/phpmyadmin/phpmyadmin/issues/14096#issue-306243721
and qcybb at https://github.com/phpmyadmin/phpmyadmin/issues/14060#issuecomment-374730276

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-03-21 10:50:13 -04:00
Maurício Meneghini Fauth
0c21321803 Remove default function parameters in functions.js
Replace ES2015 default function parameters in js/functions.js with a check in the function body.

Fix #14061

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-15 15:20:58 -03:00
Maurício Meneghini Fauth
741a50a905 Merge branch 'QA_4_7' 2018-03-12 19:24:44 -03:00
Alexander Kamp
dc75d407c0 Fixes for issue 14059: (#14075)
Missing '=' after fk_checks (value was appended onto field name)
sql_query variable not set due to GET-POST method change in tbl_structure.php 'add_key' situation

Fix #14059

Signed-off-by: Alexander Kamp <git@akamp.nl>
2018-03-12 19:16:57 -03:00
Michal Čihař
3034a23fed Revert "Honor arg_separator in AJAX requests"
This reverts commit 984c6a0054.

See #13940

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-03-05 15:46:32 +01:00
Michal Čihař
16c6c114fa Revert "Fix missing addition operator on string concatenation"
This reverts commit a0024aa041.
2018-03-05 15:45:54 +01:00
Maurício Meneghini Fauth
1a322e1a8f Merge branch 'QA_4_7' 2018-03-01 22:27:44 -03:00
Maurício Meneghini Fauth
a0024aa041 Fix missing addition operator on string concatenation
Fix #14050

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:15:04 -03:00
Michal Čihař
f4026f60a4 Merge branch 'QA_4_7' 2018-03-01 16:02:57 +01:00
Michal Čihař
984c6a0054 Honor arg_separator in AJAX requests
Fixes #13940

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-03-01 15:50:41 +01:00
Maurício Meneghini Fauth
60032ce9de Fix getPostData function
dataPost can be undefined

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit 367f49b12b)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 16:07:49 -03:00
Michal Čihař
1f00c99be9 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 1fc566fd90)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 16:01:00 -03:00
Michal Čihař
35dc6d4f2c Adjust table truncate operation to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit ff20564ef0)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 13:48:19 -03:00
Michal Čihař
be7d5ee738 Simplify handling of long URLs in Util::linkOrButton
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 3b9fb2b664)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 13:02:58 -03:00
Maurício Meneghini Fauth
367f49b12b Fix getPostData function
dataPost can be undefined

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-08 17:12:44 -02:00
Michal Čihař
1fc566fd90 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-08 17:35:32 +01:00
Michal Čihař
e9ec1388d0 Fixed configuration ops with multiple servers
Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-08 14:15:35 +01:00
Juvenildo Vaz
3767d8343f Removed all remaining inline styles from functions.js #12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>
2017-12-25 17:33:37 -03:00
Michal Čihař
d934364bac Merge branch 'QA_4_7' 2017-12-15 13:20:30 +01:00
Michal Čihař
c08c3aa688 Ensure datetimepicker is always loaded for datetime fields
We do not need to check the type here as caller is supposed to do this
anyway.

Fixes #13856

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 13:19:38 +01:00
Michal Čihař
ff20564ef0 Adjust table truncate operation to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 11:51:18 +01:00
Michal Čihař
51a65e022b Avoid using deprecated jQuery functions
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 12:37:18 +01:00
Michal Čihař
241f93c4be Initial javascript API for handling user configuration
There ar now configGet/configSet functions which can be used to
manipulate user settings.

Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 11:09:16 +01:00
Michal Čihař
19a69c61b5 Merge branch 'QA_4_7' 2017-11-28 10:22:07 +01:00
Michal Čihař
784fbcd38f Lock page when changes are done in the SQL editor
The CodeMirror does not update underlying textarea in all cases, so we
need to handle it directly.

Fixes #13821

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 10:20:30 +01:00
Michal Čihař
0aed31b854 Remove extension from js images API
Now when we use CSS classes, it's up to themes to define this.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 13:58:17 +01:00