Commit Graph

269 Commits

Author SHA1 Message Date
Hugues Peccatte
bdb5f333d7 Fix PHPCS issues.
PHPDoc updates.
Minor coding style modifications.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-01 22:07:18 +01:00
Hugues Peccatte
e17de11c74 Improve multibytes string manipulation performances.
Review SQL import process.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-30 17:40:09 +01:00
Hugues Peccatte
74f0beda8f Fix syntax error.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-20 20:56:12 +02:00
Ann + J.M
a540e6ba87 More fixes to new PMA_URL_getCommon style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-10-18 19:42:39 +02:00
Ann + J.M
b1a7039ae3 Convert PMA_URL_getCommon calls to new style
Rewritten tests need validation
Signed-Off-By: Ann + J.M. <phpMyAdmin@ZweiSteinSoft.de>
2014-10-18 19:42:29 +02:00
Madhura Jayaratne
8059f3fff0 Merge pull request #1375 from madhuracj/DisableIS
Performance improvements related to IS
2014-10-16 18:49:18 +05:30
Madhura Jayaratne
492d0f133f Additional fix for bug #3869. Consider tables in information_schema as views to benefit from 'MaxExactCountViews' and avoid count(*) in information_schema tables
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-10-16 14:59:45 +05:30
Marc Delisle
32c1192351 Fix code execution path warning
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-14 12:12:49 -04:00
Hugues Peccatte
70a21ec25c Merge from master.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-08 21:49:37 +02:00
Hugues Peccatte
f9cd1a1a22 Replace mb functions by standard string functions.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-05 11:31:50 +02:00
Marc Delisle
115ec64b1d Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-02 05:50:43 -04:00
Marc Delisle
45d234f638 Adapt to PMA_String
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-30 13:20:19 -04:00
Marc Delisle
faafea0bd1 Merge branch 'QA_4_2' 2014-09-30 13:14:14 -04:00
Marc Delisle
58cc1e5ae2 bug #4543 Changing column name can break saved "order by" clause
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-30 13:13:21 -04:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Marc Delisle
6fd724cb24 Refactor duplicate code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-25 11:57:28 -04:00
Marc Delisle
ac08019ef4 Merge branch 'QA_4_2' 2014-09-25 08:18:43 -04:00
Marc Delisle
da6e5b6e8e bug #4542 Tab key in column name not shown
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-25 08:18:04 -04:00
Marc Delisle
0f74231fee rfe #1251 Show "Overhead" with same precision for all tables
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-24 15:54:17 -04:00
Marc Delisle
e35133c25e Remove unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-10 07:29:45 -04:00
Hugues Peccatte
fe452a7240 Make Scrutinizer happier.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 13:56:42 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Marc Delisle
ed6968eabc Add missing parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-21 09:04:28 -04:00
Marc Delisle
5a677a3ec4 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-18 21:34:19 -04:00
Marc Delisle
6d3a919ee0 Fix parameter type
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-18 21:10:49 -04:00
Ashutosh Dhundhara
60610f9b83 Fix issues reported by Scrutinizer.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-17 02:20:05 +05:30
Marc Delisle
dbfc3acb1f Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-17 16:51:26 -04:00
Marc Delisle
a483abec07 Fix parameter type
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-16 10:37:05 -04:00
Isaac Bennetch
175c1a786a Merge pull request #1276 from D-storm/FR-637
RFE-637: Custom field handlers (input transformations)
2014-07-12 09:45:35 -04:00
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Marc Delisle
57475371a5 bug #4486 [security] XSS injection due to unescaped table comment
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-11 06:36:17 -04:00
Ashutosh Dhundhara
622bab8f06 Function says that it returns HTML.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-07-09 23:00:20 +05:30
Marc Delisle
ca4c37282e Merge pull request #1257 from smita786/gsoc_automated_normalizaion
automated normalizaion to 1NF
2014-06-30 15:44:09 -04:00
Smita Kumari
1e971f3263 1NF: initial commit
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

step 1 to 1NF complete

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added layout for step2 and step3

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

basic 1NF complete

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fix coding style

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added doc comment

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fix coding style

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

error handling plus during split shows my string type columns

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

removing unnecessory code

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

removing unnecessory code

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

code refactoring plus translatable message format

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added events on cancel and added unbind function calls

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

hide default textarea when value NONE

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

remove unnecesory alert

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

create unique column screen fixed plus starting link for normalization on tbl_structure page

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added hint to follow steps carefully and finish message changes

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Fix coding style plus messages

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added wand icon for normalization

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

bug fix: dont go next step if any index other than primary/unique is crated

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

bug fix: replace .live with .on plus others

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

change show central column message plus refresh central column list on split save

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-06-30 22:32:53 +05:30
Marc Delisle
f1b37d7ffc Fix incorrect parameter type definition
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-30 11:33:01 -04:00
Ann + J.M
6b778e09d9 Fix coding style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-22 16:34:34 +02:00
Ashutosh Dhundhara
3b24737d14 Bug: Escape table name.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-06-21 09:15:45 +05:30
Marc Delisle
9f37c3ddd7 Fix merge conflits
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-20 12:44:51 -04:00
Marc Delisle
d51893b0b7 Clarify parameter type
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-16 13:01:38 -04:00
Marc Delisle
00bad7150b Merge pull request #1211 from smita786/gsoc_central_columns_list
option to Make table consistent with central list of columns
2014-06-09 12:27:40 -04:00
Smita Kumari
6b8575734c option to Make table consistent with central list of columns
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

make messages transtalable

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Coding style fix

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Make confirmation button options translatable

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-06-09 20:35:10 +05:30
Ashutosh Dhundhara
99b9e8d83c RFE#1145: Preview SQL instead of executing it.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-06-07 00:27:39 +05:30
Ann + J.M
cb7c703c03 Fix XSS in recent/favorite tables list feature
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-06 18:40:19 +02:00
Ann + J.M
fea0fe03ef Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-04 18:02:44 +02:00
Marc Delisle
bd762244ec Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:27:02 -04:00
Marc Delisle
4627be8968 Clarify message
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-28 08:21:06 -04:00
Marc Delisle
93ce1a69de Merge pull request #1195 from smita786/gsoc_central_columns_list
Gsoc central columns list
2014-05-26 15:14:04 -04:00
Smita Kumari
200737bcce gsoc:central list of columns, added sync and remove column list on db_structure page
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixing indentation in mult_submits.inc.php

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

naming convention,typos, indentaion fix and removed unnecessory file db_sync_central_columns.php

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

check if central columns storage is configured, if not configured don't show the option to sync/remove

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

add/remove columns to central list of columns from tbl_structure page

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added icon image for central columns add/delete

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

add/remove of columns option in tbl_structure page in columns rows depending upon if column is already present in central columns or not

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixed php notices, apporiprate message when a non existing column is removed and when a existing column is added to cenral list

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

documentation added for central_columns configuration

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

regenerated sprite

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

changed central_columns table structure + modified functions to add to central column as per new tbl def

updated delete and other function as per new db structure

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

remove notices

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

sprintf for variable message

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fix unit test failure errors

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixed whitespace issues plus function definition

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

refactoring code plus fixing coding style issues

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-05-26 23:13:03 +05:30
Marc Delisle
0db68db620 Merge branch 'QA_4_2' 2014-05-21 12:51:03 -04:00
Marc Delisle
c2d719b4eb bug #4423 Moving fields not working
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-21 12:49:55 -04:00