gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
118,563 Commits 12 Branches 481 Tags 2.4 GiB
ff86a0b6d6
Commit Graph

80 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action 
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 11:21:42 -03:00
William Desportes
a72203c514
Remove some unused code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 23:51:43 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-28 23:18:59 +02:00
Maurício Meneghini Fauth
4a0bce1d53 Extract db structure bulk actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 23:13:35 -03:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-16 20:15:42 -03:00
Maurício Meneghini Fauth
db642ab19e Extract HTML from Index:getHtmlFromIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-29 23:43:18 -03:00
Maurício Meneghini Fauth
eb2804540f Extract HTML from Index::getHtmlForDisplayIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-29 16:09:50 -03:00
Maurício Meneghini Fauth
558226d78e Extract HTML from StorageEngine::getHtmlSelect() 
Renames the method to StorageEngine::getArray().

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-27 19:31:35 -03:00
Maurício Meneghini Fauth
c8c2e9d793 Refactor tbl_columns_definition_form.inc.php 
Extracts the tbl_columns_definition_form.inc.php logic to the
PhpMyAdmin\Table\ColumnsDefinition::displayForm static method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-17 02:55:20 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:23:16 +01:00
William Desportes
517222ff59
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-13 00:07:11 +01:00
William Desportes
0b2937dd6a
Fix #15781 - Illegal string offset error on structure page of 'information_schema' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-12 23:11:41 +01:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
William Desportes
ae0577ab1e
Merge #15820 - Fix #15797 - Relation view broken 
Fixes: #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa fixes url. 
fixes #15797

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
 2020-01-19 20:06:03 +05:30
William Desportes
fd036d7f4a
Merge #15808 - Fix #15312 - added LOCK=NONE to ALGORITHM=INPLACE 
Fixes: #15312
Pull-request: #15808
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-19 13:53:25 +01:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-17 19:44:00 -03:00
Kartik Kathuria
9054d1f673 Added LOCK=NONE 
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2020-01-17 20:42:09 +05:30
Kartik Kathuria
a439082dba Change ALTER ONLINE to ALGORITHM=INPLACE at required position 
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2020-01-17 13:36:06 +05:30
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-14 18:54:02 -03:00
Jayati Shrivastava
f14d675308
revert change introduced by pr #15718 and fix #15718 
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
 2020-01-12 18:46:23 +01:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code 
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
cbce3a66e3 Remove the sql entry point file 
Directly calls the controller instead of including the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller 
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 15:02:28 -03:00
William Desportes
c14500f323
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-02 15:50:55 +01:00
Jayati Shrivastava
f428e4eeb7
Fixes #15717 - Warning popup not dissapearing 
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
 2020-01-02 15:44:37 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
7ac1d21c70 Fix some PHPStan level 2 errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-05 19:50:24 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
William Desportes
acba81e091
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-10 21:06:25 +01:00
William Desportes
bf8939add6
Merge branch 'QA_4_9' into QA_5_0 
Fixes the merge mitake done in df0543694c
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-10 21:02:57 +01:00
William Desportes
df0543694c
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-10 20:54:15 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
William Desportes
f3bdd3521d
Merge branch 'QA_5_0' into master 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-29 22:43:40 +02:00
William Desportes
2f2c942282
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-29 22:42:33 +02:00
Maurício Meneghini Fauth
d01e1c26b9 Fix active page on navigation bar 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-26 15:14:17 -03:00
Maurício Meneghini Fauth
ba6bad9533 Use the router for view_create.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-21 00:11:04 -03:00