createDatabaseInterface(); $config = Config::getInstance(); $config->selectedServer['DisableIS'] = false; $config->settings['ActionLinksMode'] = 'icons'; $GLOBALS['server'] = 0; $GLOBALS['db'] = 'db'; $GLOBALS['table'] = 'table'; $GLOBALS['text_dir'] = 'ltr'; $GLOBALS['proc_priv'] = false; $GLOBALS['is_reload_priv'] = false; $GLOBALS['errors'] = []; $this->routines = new Routines(DatabaseInterface::getInstance()); } /** * Test for getDataFromRequest * * @param array $in Input * @param array $out Expected output */ #[DataProvider('providerGetDataFromRequest')] public function testGetDataFromRequest(array $in, array $out): void { unset($_POST); unset($_REQUEST); foreach ($in as $key => $value) { if ($value === '') { continue; } $_POST[$key] = $value; $_REQUEST[$key] = $value; } $this->assertEquals($out, $this->routines->getDataFromRequest()); } /** * Data provider for testGetDataFromRequest * * @return array, array}> */ public static function providerGetDataFromRequest(): array { return [ [ [ 'item_name' => '', 'item_original_name' => '', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => '', 'item_comment' => '', 'item_definer' => '', 'item_type' => '', 'item_type_toggle' => '', 'item_original_type' => '', 'item_param_dir' => '', 'item_param_name' => '', 'item_param_type' => '', 'item_param_length' => '', 'item_param_opts_num' => '', 'item_param_opts_text' => '', 'item_returntype' => '', 'item_isdeterministic' => '', 'item_securitytype' => '', 'item_sqldataaccess' => '', ], [ 'item_name' => '', 'item_original_name' => '', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => '', 'item_comment' => '', 'item_definer' => '', 'item_type' => 'PROCEDURE', 'item_type_toggle' => 'FUNCTION', 'item_original_type' => 'PROCEDURE', 'item_num_params' => 0, 'item_param_dir' => [], 'item_param_name' => [], 'item_param_type' => [], 'item_param_length' => [], 'item_param_opts_num' => [], 'item_param_opts_text' => [], 'item_returntype' => '', 'item_isdeterministic' => '', 'item_securitytype_definer' => '', 'item_securitytype_invoker' => '', 'item_sqldataaccess' => '', ], ], [ [ 'item_name' => 'proc2', 'item_original_name' => 'proc', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT NULL', 'item_comment' => 'some text', 'item_definer' => 'root@localhost', 'item_type' => 'PROCEDURE', 'item_type_toggle' => 'FUNCTION', 'item_original_type' => 'PROCEDURE', 'item_param_dir' => [0 => 'IN', 1 => 'FAIL'], 'item_param_name' => [0 => 'bar', 1 => 'baz'], 'item_param_type' => [0 => 'INT', 1 => 'FAIL'], 'item_param_length' => [0 => '20', 1 => ''], 'item_param_opts_num' => [0 => 'UNSIGNED', 1 => ''], 'item_param_opts_text' => [0 => '', 1 => 'latin1'], 'item_returntype' => '', 'item_isdeterministic' => 'ON', 'item_securitytype' => 'INVOKER', 'item_sqldataaccess' => 'NO SQL', ], [ 'item_name' => 'proc2', 'item_original_name' => 'proc', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT NULL', 'item_comment' => 'some text', 'item_definer' => 'root@localhost', 'item_type' => 'PROCEDURE', 'item_type_toggle' => 'FUNCTION', 'item_original_type' => 'PROCEDURE', 'item_num_params' => 2, 'item_param_dir' => [0 => 'IN', 1 => ''], 'item_param_name' => [0 => 'bar', 1 => 'baz'], 'item_param_type' => [0 => 'INT', 1 => ''], 'item_param_length' => [0 => '20', 1 => ''], 'item_param_opts_num' => [0 => 'UNSIGNED', 1 => ''], 'item_param_opts_text' => [0 => '', 1 => 'latin1'], 'item_returntype' => '', 'item_isdeterministic' => ' checked=\'checked\'', 'item_securitytype_definer' => '', 'item_securitytype_invoker' => ' selected=\'selected\'', 'item_sqldataaccess' => 'NO SQL', ], ], [ [ 'item_name' => 'func2', 'item_original_name' => 'func', 'item_returnlength' => '20', 'item_returnopts_num' => '', 'item_returnopts_text' => 'CHARSET utf8', 'item_definition' => 'SELECT NULL', 'item_comment' => 'some text', 'item_definer' => 'root@localhost', 'item_type' => 'FUNCTION', 'item_type_toggle' => 'PROCEDURE', 'item_original_type' => 'FUNCTION', 'item_param_dir' => [0 => '', 1 => ''], 'item_param_name' => [0 => 'bar', 1 => 'baz'], 'item_param_type' => [0 => 'XSS', 1 => 'TEXT'], 'item_param_length' => [0 => '10,10', 1 => ''], 'item_param_opts_num' => [0 => 'UNSIGNED', 1 => ''], 'item_param_opts_text' => [0 => '', 1 => 'utf8'], 'item_returntype' => 'VARCHAR', 'item_isdeterministic' => '', 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => '', ], [ 'item_name' => 'func2', 'item_original_name' => 'func', 'item_returnlength' => '20', 'item_returnopts_num' => '', 'item_returnopts_text' => 'CHARSET utf8', 'item_definition' => 'SELECT NULL', 'item_comment' => 'some text', 'item_definer' => 'root@localhost', 'item_type' => 'FUNCTION', 'item_type_toggle' => 'PROCEDURE', 'item_original_type' => 'FUNCTION', 'item_num_params' => '2', 'item_param_dir' => [], 'item_param_name' => [0 => 'bar', 1 => 'baz'], 'item_param_type' => [0 => '', 1 => 'TEXT'], 'item_param_length' => [0 => '10,10', 1 => ''], 'item_param_opts_num' => [0 => 'UNSIGNED', 1 => ''], 'item_param_opts_text' => [0 => '', 1 => 'utf8'], 'item_returntype' => 'VARCHAR', 'item_isdeterministic' => '', 'item_securitytype_definer' => ' selected=\'selected\'', 'item_securitytype_invoker' => '', 'item_sqldataaccess' => '', ], ], ]; } /** * Test for getQueryFromRequest * * @param array> $request Request * @param string $query Query * @param int $numErr Error number */ #[DataProvider('providerGetQueryFromRequest')] public function testGetQueryFromRequest(array $request, string $query, int $numErr): void { Config::getInstance()->settings['ShowFunctionFields'] = false; $GLOBALS['errors'] = []; $oldDbi = DatabaseInterface::getInstance(); $dbi = $this->getMockBuilder(DatabaseInterface::class) ->disableOriginalConstructor() ->getMock(); $dbi->types = new Types($dbi); $dbi->expects($this->any()) ->method('quoteString') ->willReturnMap([ ['foo', Connection::TYPE_USER, "'foo'"], ["foo's bar", Connection::TYPE_USER, "'foo\'s bar'"], ]); DatabaseInterface::$instance = $dbi; $routines = new Routines($dbi); unset($_POST); $_POST = $request; $this->assertEquals($query, $routines->getQueryFromRequest()); $this->assertCount($numErr, $GLOBALS['errors']); // reset DatabaseInterface::$instance = $oldDbi; } /** * Data provider for testGetQueryFromRequest * * @return array>, string, int}> */ public static function providerGetQueryFromRequest(): array { return [ // Testing success [ [ 'item_name' => 'p r o c', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT 0;', 'item_comment' => 'foo', 'item_definer' => 'me@home', 'item_type' => 'PROCEDURE', 'item_num_params' => '0', 'item_param_dir' => [], 'item_param_name' => '', 'item_param_type' => '', 'item_param_length' => '', 'item_param_opts_num' => '', 'item_param_opts_text' => '', 'item_returntype' => '', 'item_isdeterministic' => '', 'item_securitytype' => 'INVOKER', 'item_sqldataaccess' => 'NO SQL', ], 'CREATE DEFINER=`me`@`home` PROCEDURE `p r o c`() COMMENT \'foo\' ' . 'DETERMINISTIC NO SQL SQL SECURITY INVOKER SELECT 0;', 0, ], [ [ 'item_name' => 'pr``oc', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT \'foobar\';', 'item_comment' => '', 'item_definer' => 'someuser@somehost', 'item_type' => 'PROCEDURE', 'item_num_params' => '2', 'item_param_dir' => ['IN', 'INOUT'], 'item_param_name' => ['pa`ram', 'par 2'], 'item_param_type' => ['INT', 'ENUM'], 'item_param_length' => ['10', '\'a\', \'b\''], 'item_param_opts_num' => ['ZEROFILL', ''], 'item_param_opts_text' => ['utf8', 'latin1'], 'item_returntype' => '', 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => 'foobar', ], 'CREATE DEFINER=`someuser`@`somehost` PROCEDURE `pr````oc`' . '(IN `pa``ram` INT(10) ZEROFILL, INOUT `par 2` ENUM(\'a\', \'b\')' . ' CHARSET latin1) NOT DETERMINISTIC SQL SECURITY DEFINER SELECT ' . '\'foobar\';', 0, ], [ [ 'item_name' => 'func\\', 'item_returnlength' => '5,5', 'item_returnopts_num' => 'UNSIGNED ZEROFILL', 'item_returnopts_text' => '', 'item_definition' => 'SELECT \'foobar\';', 'item_comment' => 'foo\'s bar', 'item_definer' => '', 'item_type' => 'FUNCTION', 'item_num_params' => '1', 'item_param_dir' => [], 'item_param_name' => ['pa`ram'], 'item_param_type' => ['VARCHAR'], 'item_param_length' => ['45'], 'item_param_opts_num' => [''], 'item_param_opts_text' => ['latin1'], 'item_returntype' => 'DECIMAL', 'item_isdeterministic' => 'ON', 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => 'READ SQL DATA', ], 'CREATE FUNCTION `func\\`(`pa``ram` VARCHAR(45) CHARSET latin1) ' . 'RETURNS DECIMAL(5,5) UNSIGNED ZEROFILL COMMENT \'foo\\\'s bar\' ' . 'DETERMINISTIC SQL SECURITY DEFINER SELECT \'foobar\';', 0, ], [ [ 'item_name' => 'func', 'item_returnlength' => '20', 'item_returnopts_num' => '', 'item_returnopts_text' => 'utf8', 'item_definition' => 'SELECT 0;', 'item_comment' => '', 'item_definer' => '', 'item_type' => 'FUNCTION', 'item_num_params' => '1', 'item_returntype' => 'VARCHAR', 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => 'READ SQL DATA', ], 'CREATE FUNCTION `func`() RETURNS VARCHAR(20) CHARSET utf8 NOT ' . 'DETERMINISTIC SQL SECURITY DEFINER SELECT 0;', 0, ], // Testing failures [ [], 'CREATE () NOT DETERMINISTIC ', // invalid query 3, ], [ [ 'item_name' => 'proc', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT 0;', 'item_comment' => 'foo', 'item_definer' => 'mehome', // invalid definer format 'item_type' => 'PROCEDURE', 'item_num_params' => '0', 'item_param_dir' => '', 'item_param_name' => '', 'item_param_type' => '', 'item_param_length' => '', 'item_param_opts_num' => '', 'item_param_opts_text' => '', 'item_returntype' => '', 'item_isdeterministic' => '', 'item_securitytype' => 'INVOKER', 'item_sqldataaccess' => 'NO SQL', ], // valid query 'CREATE PROCEDURE `proc`() COMMENT \'foo\' DETERMINISTIC NO SQL SQL SECURITY INVOKER SELECT 0;', 1, ], [ [ 'item_name' => 'proc', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT 0;', 'item_comment' => '', 'item_definer' => '', 'item_type' => 'PROCEDURE', 'item_num_params' => '2', 'item_param_dir' => ['FAIL', 'INOUT'], // invalid direction 'item_param_name' => ['pa`ram', 'goo'], 'item_param_type' => ['INT', 'ENUM'], 'item_param_length' => ['10', ''], // missing ENUM values 'item_param_opts_num' => ['ZEROFILL', ''], 'item_param_opts_text' => ['utf8', 'latin1'], 'item_returntype' => '', 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => 'foobar', // invalid, will just be ignored without throwing errors ], 'CREATE PROCEDURE `proc`((10) ZEROFILL, ' . 'INOUT `goo` ENUM CHARSET latin1) NOT DETERMINISTIC ' . 'SQL SECURITY DEFINER SELECT 0;', // invalid query 2, ], [ [ 'item_name' => 'func', 'item_returnlength' => '', // missing length for VARCHAR 'item_returnopts_num' => '', 'item_returnopts_text' => 'utf8', 'item_definition' => 'SELECT 0;', 'item_comment' => '', 'item_definer' => '', 'item_type' => 'FUNCTION', 'item_num_params' => '2', 'item_param_dir' => ['IN'], 'item_param_name' => [''], // missing name 'item_param_type' => ['INT'], 'item_param_length' => ['10'], 'item_param_opts_num' => ['ZEROFILL'], 'item_param_opts_text' => ['latin1'], 'item_returntype' => 'VARCHAR', 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => '', ], 'CREATE FUNCTION `func`() RETURNS VARCHAR CHARSET utf8 NOT ' . 'DETERMINISTIC SQL SECURITY DEFINER SELECT 0;', // invalid query 2, ], [ [ 'item_name' => 'func', 'item_returnlength' => '', 'item_returnopts_num' => '', 'item_returnopts_text' => '', 'item_definition' => 'SELECT 0;', 'item_comment' => '', 'item_definer' => '', 'item_type' => 'FUNCTION', 'item_num_params' => '0', 'item_returntype' => 'FAIL', // invalid return type 'item_securitytype' => 'DEFINER', 'item_sqldataaccess' => '', ], 'CREATE FUNCTION `func`() NOT DETERMINISTIC SQL SECURITY DEFINER SELECT 0;', // invalid query 1, ], ]; } public function testGetFunctionNames(): void { $dbiDummy = $this->createDbiDummy(); $dbiDummy->addResult( 'SHOW FUNCTION STATUS;', [ ['db_test', 'test_func', 'FUNCTION'], ['test_db', 'test_func1', 'FUNCTION'], ['test_db', '', 'FUNCTION'], ['test_db', 'test_func2', 'FUNCTION'], ['test_db', 'test_func', 'PROCEDURE'], ], ['Db', 'Name', 'Type'], ); $names = Routines::getFunctionNames($this->createDatabaseInterface($dbiDummy), 'test_db'); $this->assertSame(['test_func1', 'test_func2'], $names); $dbiDummy->assertAllQueriesConsumed(); } public function testGetFunctionNamesWithEmptyReturn(): void { $dbiDummy = $this->createDbiDummy(); $dbiDummy->addResult( 'SHOW FUNCTION STATUS;', [['db_test', 'test_func', 'FUNCTION'], ['test_db', '', 'FUNCTION'], ['test_db', 'test_func', 'PROCEDURE']], ['Db', 'Name', 'Type'], ); $names = Routines::getFunctionNames($this->createDatabaseInterface($dbiDummy), 'test_db'); $this->assertSame([], $names); $dbiDummy->assertAllQueriesConsumed(); } public function testGetProcedureNames(): void { $dbiDummy = $this->createDbiDummy(); $dbiDummy->addResult( 'SHOW PROCEDURE STATUS;', [ ['db_test', 'test_proc', 'PROCEDURE'], ['test_db', 'test_proc1', 'PROCEDURE'], ['test_db', '', 'PROCEDURE'], ['test_db', 'test_proc2', 'PROCEDURE'], ['test_db', 'test_proc', 'FUNCTION'], ], ['Db', 'Name', 'Type'], ); $names = Routines::getProcedureNames($this->createDatabaseInterface($dbiDummy), 'test_db'); $this->assertSame(['test_proc1', 'test_proc2'], $names); $dbiDummy->assertAllQueriesConsumed(); } public function testGetProcedureNamesWithEmptyReturn(): void { $dbiDummy = $this->createDbiDummy(); $dbiDummy->addResult( 'SHOW PROCEDURE STATUS;', [ ['db_test', 'test_proc', 'PROCEDURE'], ['test_db', '', 'PROCEDURE'], ['test_db', 'test_proc', 'FUNCTION'], ], ['Db', 'Name', 'Type'], ); $names = Routines::getProcedureNames($this->createDatabaseInterface($dbiDummy), 'test_db'); $this->assertSame([], $names); $dbiDummy->assertAllQueriesConsumed(); } }