phpmyadmin/libraries/classes/Controllers/Table/Structure/SaveController.php
Maurício Meneghini Fauth 22c6a2f9d8
Add a wrapper around the exit language construct
Creates the PhpMyAdmin\ResponseRenderer::callExit() method as a wrapper
to the exit language construct. That makes the tests more correct as the
method will always stop the code execution.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-06 21:54:07 -03:00

383 lines
14 KiB
PHP

<?php
declare(strict_types=1);
namespace PhpMyAdmin\Controllers\Table\Structure;
use PhpMyAdmin\ConfigStorage\Relation;
use PhpMyAdmin\Controllers\AbstractController;
use PhpMyAdmin\Controllers\Table\StructureController;
use PhpMyAdmin\Core;
use PhpMyAdmin\DatabaseInterface;
use PhpMyAdmin\Html\Generator;
use PhpMyAdmin\Http\ServerRequest;
use PhpMyAdmin\Index;
use PhpMyAdmin\Message;
use PhpMyAdmin\ResponseRenderer;
use PhpMyAdmin\Table;
use PhpMyAdmin\Template;
use PhpMyAdmin\Transformations;
use PhpMyAdmin\Url;
use PhpMyAdmin\Util;
use function __;
use function count;
use function implode;
use function in_array;
use function is_array;
use function mb_strpos;
use function sprintf;
use function strlen;
final class SaveController extends AbstractController
{
private Table $tableObj;
public function __construct(
ResponseRenderer $response,
Template $template,
private Relation $relation,
private Transformations $transformations,
private DatabaseInterface $dbi,
private StructureController $structureController,
) {
parent::__construct($response, $template);
$this->tableObj = $this->dbi->getTable($GLOBALS['db'], $GLOBALS['table']);
}
public function __invoke(ServerRequest $request): void
{
$regenerate = $this->updateColumns();
if (! $regenerate) {
// continue to show the table's structure
unset($_POST['selected']);
}
($this->structureController)($request);
}
/**
* Update the table's structure based on $_REQUEST
*
* @return bool true if error occurred
*/
private function updateColumns(): bool
{
$errUrl = Url::getFromRoute('/table/structure', ['db' => $GLOBALS['db'], 'table' => $GLOBALS['table']]);
$regenerate = false;
$fieldCnt = count($_POST['field_name'] ?? []);
$changes = [];
$adjustPrivileges = [];
$columnsWithIndex = $this->dbi
->getTable($GLOBALS['db'], $GLOBALS['table'])
->getColumnsWithIndex(Index::PRIMARY | Index::UNIQUE);
for ($i = 0; $i < $fieldCnt; $i++) {
if (! $this->columnNeedsAlterTable($i)) {
continue;
}
$changes[] = 'CHANGE ' . Table::generateAlter(
Util::getValueByKey($_POST, 'field_orig.' . $i, ''),
$_POST['field_name'][$i],
$_POST['field_type'][$i],
$_POST['field_length'][$i],
$_POST['field_attribute'][$i],
Util::getValueByKey($_POST, 'field_collation.' . $i, ''),
Util::getValueByKey($_POST, 'field_null.' . $i, 'NO'),
$_POST['field_default_type'][$i],
$_POST['field_default_value'][$i],
Util::getValueByKey($_POST, 'field_extra.' . $i, ''),
Util::getValueByKey($_POST, 'field_comments.' . $i, ''),
Util::getValueByKey($_POST, 'field_virtuality.' . $i, ''),
Util::getValueByKey($_POST, 'field_expression.' . $i, ''),
Util::getValueByKey($_POST, 'field_move_to.' . $i, ''),
$columnsWithIndex,
);
// find the remembered sort expression
$sortedCol = $this->tableObj->getUiProp(Table::PROP_SORTED_COLUMN);
// if the old column name is part of the remembered sort expression
if (mb_strpos((string) $sortedCol, Util::backquote($_POST['field_orig'][$i])) !== false) {
// delete the whole remembered sort expression
$this->tableObj->removeUiProp(Table::PROP_SORTED_COLUMN);
}
if (
empty($_POST['field_adjust_privileges'][$i])
|| $_POST['field_orig'][$i] == $_POST['field_name'][$i]
) {
continue;
}
$adjustPrivileges[$_POST['field_orig'][$i]] = $_POST['field_name'][$i];
}
if ($changes !== [] || isset($_POST['preview_sql'])) {
// Builds the primary keys statements and updates the table
$keyQuery = '';
/**
* this is a little bit more complex
*
* @todo if someone selects A_I when altering a column we need to check:
* - no other column with A_I
* - the column has an index, if not create one
*/
// To allow replication, we first select the db to use
// and then run queries on this db.
if (! $this->dbi->selectDb($GLOBALS['db'])) {
Generator::mysqlDie(
$this->dbi->getError(),
'USE ' . Util::backquote($GLOBALS['db']) . ';',
false,
$errUrl,
);
}
$sqlQuery = 'ALTER TABLE ' . Util::backquote($GLOBALS['table']) . ' ';
$sqlQuery .= implode(', ', $changes) . $keyQuery;
if (isset($_POST['online_transaction'])) {
$sqlQuery .= ', ALGORITHM=INPLACE, LOCK=NONE';
}
$sqlQuery .= ';';
// If there is a request for SQL previewing.
if (isset($_POST['preview_sql'])) {
Core::previewSQL($changes !== [] ? $sqlQuery : '');
$this->response->callExit();
}
$columnsWithIndex = $this->dbi
->getTable($GLOBALS['db'], $GLOBALS['table'])
->getColumnsWithIndex(Index::PRIMARY | Index::UNIQUE | Index::INDEX | Index::SPATIAL | Index::FULLTEXT);
$changedToBlob = [];
// While changing the Column Collation
// First change to BLOB
for ($i = 0; $i < $fieldCnt; $i++) {
if (
isset($_POST['field_collation'][$i], $_POST['field_collation_orig'][$i])
&& $_POST['field_collation'][$i] !== $_POST['field_collation_orig'][$i]
&& ! in_array($_POST['field_orig'][$i], $columnsWithIndex)
) {
$secondaryQuery = 'ALTER TABLE ' . Util::backquote($GLOBALS['table'])
. ' CHANGE ' . Util::backquote($_POST['field_orig'][$i])
. ' ' . Util::backquote($_POST['field_orig'][$i])
. ' BLOB';
if (isset($_POST['field_virtuality'][$i], $_POST['field_expression'][$i])) {
if ($_POST['field_virtuality'][$i]) {
$secondaryQuery .= ' AS (' . $_POST['field_expression'][$i] . ') '
. $_POST['field_virtuality'][$i];
}
}
$secondaryQuery .= ';';
$this->dbi->query($secondaryQuery);
$changedToBlob[$i] = true;
} else {
$changedToBlob[$i] = false;
}
}
// Then make the requested changes
$result = $this->dbi->tryQuery($sqlQuery);
if ($result !== false) {
$changedPrivileges = $this->adjustColumnPrivileges($adjustPrivileges);
if ($changedPrivileges) {
$message = Message::success(
__(
'Table %1$s has been altered successfully. Privileges have been adjusted.',
),
);
} else {
$message = Message::success(
__('Table %1$s has been altered successfully.'),
);
}
$message->addParam($GLOBALS['table']);
$this->response->addHTML(
Generator::getMessage($message, $sqlQuery, 'success'),
);
} else {
// An error happened while inserting/updating a table definition
// Save the Original Error
$origError = $this->dbi->getError();
$changesRevert = [];
// Change back to Original Collation and data type
for ($i = 0; $i < $fieldCnt; $i++) {
if (! $changedToBlob[$i]) {
continue;
}
$changesRevert[] = 'CHANGE ' . Table::generateAlter(
Util::getValueByKey($_POST, 'field_orig.' . $i, ''),
$_POST['field_name'][$i],
$_POST['field_type_orig'][$i],
$_POST['field_length_orig'][$i],
$_POST['field_attribute_orig'][$i],
Util::getValueByKey($_POST, 'field_collation_orig.' . $i, ''),
Util::getValueByKey($_POST, 'field_null_orig.' . $i, 'NO'),
$_POST['field_default_type_orig'][$i],
$_POST['field_default_value_orig'][$i],
Util::getValueByKey($_POST, 'field_extra_orig.' . $i, ''),
Util::getValueByKey($_POST, 'field_comments_orig.' . $i, ''),
Util::getValueByKey($_POST, 'field_virtuality_orig.' . $i, ''),
Util::getValueByKey($_POST, 'field_expression_orig.' . $i, ''),
Util::getValueByKey($_POST, 'field_move_to_orig.' . $i, ''),
);
}
$revertQuery = 'ALTER TABLE ' . Util::backquote($GLOBALS['table'])
. ' ';
$revertQuery .= implode(', ', $changesRevert);
$revertQuery .= ';';
// Column reverted back to original
$this->dbi->query($revertQuery);
$this->response->setRequestStatus(false);
$message = Message::rawError(
__('Query error') . ':<br>' . $origError,
);
$this->response->addHTML(
Generator::getMessage($message, $sqlQuery, 'error'),
);
$regenerate = true;
}
}
// update field names in relation
if (isset($_POST['field_orig']) && is_array($_POST['field_orig'])) {
foreach ($_POST['field_orig'] as $fieldindex => $fieldcontent) {
if ($_POST['field_name'][$fieldindex] == $fieldcontent) {
continue;
}
$this->relation->renameField(
$GLOBALS['db'],
$GLOBALS['table'],
$fieldcontent,
$_POST['field_name'][$fieldindex],
);
}
}
// update mime types
if (isset($_POST['field_mimetype']) && is_array($_POST['field_mimetype']) && $GLOBALS['cfg']['BrowseMIME']) {
foreach ($_POST['field_mimetype'] as $fieldindex => $mimetype) {
if (! isset($_POST['field_name'][$fieldindex]) || strlen($_POST['field_name'][$fieldindex]) <= 0) {
continue;
}
$this->transformations->setMime(
$GLOBALS['db'],
$GLOBALS['table'],
$_POST['field_name'][$fieldindex],
$mimetype,
$_POST['field_transformation'][$fieldindex],
$_POST['field_transformation_options'][$fieldindex],
$_POST['field_input_transformation'][$fieldindex],
$_POST['field_input_transformation_options'][$fieldindex],
);
}
}
return $regenerate;
}
/**
* Verifies if some elements of a column have changed
*
* @param int $i column index in the request
*/
private function columnNeedsAlterTable(int $i): bool
{
// these two fields are checkboxes so might not be part of the
// request; therefore we define them to avoid notices below
if (! isset($_POST['field_null'][$i])) {
$_POST['field_null'][$i] = 'NO';
}
if (! isset($_POST['field_extra'][$i])) {
$_POST['field_extra'][$i] = '';
}
// field_name does not follow the convention (corresponds to field_orig)
if ($_POST['field_name'][$i] != $_POST['field_orig'][$i]) {
return true;
}
$fields = [
'field_attribute',
'field_collation',
'field_comments',
'field_default_value',
'field_default_type',
'field_extra',
'field_length',
'field_null',
'field_type',
];
foreach ($fields as $field) {
if ($_POST[$field][$i] != $_POST[$field . '_orig'][$i]) {
return true;
}
}
return ! empty($_POST['field_move_to'][$i]);
}
/**
* Adjusts the Privileges for all the columns whose names have changed
*
* @param mixed[] $adjustPrivileges assoc array of old col names mapped to new
* cols
*/
private function adjustColumnPrivileges(array $adjustPrivileges): bool
{
$changed = false;
if (($GLOBALS['col_priv'] ?? false) && ($GLOBALS['is_reload_priv'] ?? false)) {
$this->dbi->selectDb('mysql');
// For Column specific privileges
foreach ($adjustPrivileges as $oldCol => $newCol) {
$this->dbi->query(
sprintf(
'UPDATE %s SET Column_name = "%s"
WHERE Db = "%s"
AND Table_name = "%s"
AND Column_name = "%s";',
Util::backquote('columns_priv'),
$newCol,
$GLOBALS['db'],
$GLOBALS['table'],
$oldCol,
),
);
// i.e. if atleast one column privileges adjusted
$changed = true;
}
if ($changed) {
// Finally FLUSH the new privileges
$this->dbi->query('FLUSH PRIVILEGES;');
}
}
return $changed;
}
}