phpmyadmin/tests/unit/LinterTest.php
Kamil Tekiela 82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00

130 lines
3.6 KiB
PHP

<?php
declare(strict_types=1);
namespace PhpMyAdmin\Tests;
use PhpMyAdmin\Linter;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\DataProvider;
use function str_repeat;
#[CoversClass(Linter::class)]
class LinterTest extends AbstractTestCase
{
/**
* Sets up the fixture, for example, opens a network connection.
* This method is called before a test is executed.
*/
protected function setUp(): void
{
parent::setUp();
$this->setLanguage();
}
/**
* Test for Linter::getLines
*/
public function testGetLines(): void
{
self::assertSame([0], Linter::getLines(''));
self::assertSame([0, 2], Linter::getLines("a\nb"));
self::assertSame([0, 4, 7], Linter::getLines("abc\nde\n"));
}
/**
* Test for Linter::findLineNumberAndColumn
*/
public function testFindLineNumberAndColumn(): void
{
// Let the analyzed string be:
// ^abc$
// ^de$
// ^$
//
// Where `^` is the beginning of the line and `$` the end of the line.
//
// Positions of each character (by line):
// ( a, 0), ( b, 1), ( c, 2), (\n, 3),
// ( d, 4), ( e, 5), (\n, 6),
// (\n, 7).
self::assertSame(
[1, 0],
Linter::findLineNumberAndColumn([0, 4, 7], 4),
);
self::assertSame(
[1, 1],
Linter::findLineNumberAndColumn([0, 4, 7], 5),
);
self::assertSame(
[1, 2],
Linter::findLineNumberAndColumn([0, 4, 7], 6),
);
self::assertSame(
[2, 0],
Linter::findLineNumberAndColumn([0, 4, 7], 7),
);
}
/**
* Test for Linter::lint
*
* @param mixed[] $expected The expected result.
* @param string $query The query to be analyzed.
*/
#[DataProvider('lintProvider')]
public function testLint(array $expected, string $query): void
{
self::assertSame($expected, Linter::lint($query));
}
/**
* Provides data for `testLint`.
*
* @return array<array{mixed[], string}>
*/
public static function lintProvider(): array
{
return [
[[], ''],
[[], 'SELECT * FROM tbl'],
[
[
[
'message' => 'Unrecognized data type. (near <code>IN</code>)',
'fromLine' => 0,
'fromColumn' => 22,
'toLine' => 0,
'toColumn' => 24,
'severity' => 'error',
],
[
'message' => 'A closing bracket was expected. (near <code>IN</code>)',
'fromLine' => 0,
'fromColumn' => 22,
'toLine' => 0,
'toColumn' => 24,
'severity' => 'error',
],
],
'CREATE TABLE tbl ( id IN',
],
[
[
[
'message' => 'Linting is disabled for this query because it exceeds the maximum length.',
'fromLine' => 0,
'fromColumn' => 0,
'toLine' => 0,
'toColumn' => 0,
'severity' => 'warning',
],
],
str_repeat(';', 10001),
],
];
}
}