phpmyadmin/libraries/classes/Controllers/Table/Structure/ChangeController.php
Maurício Meneghini Fauth 5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00

113 lines
3.1 KiB
PHP

<?php
declare(strict_types=1);
namespace PhpMyAdmin\Controllers\Table\Structure;
use PhpMyAdmin\CheckUserPrivileges;
use PhpMyAdmin\Controllers\AbstractController;
use PhpMyAdmin\DatabaseInterface;
use PhpMyAdmin\Message;
use PhpMyAdmin\ResponseRenderer;
use PhpMyAdmin\Table\ColumnsDefinition;
use PhpMyAdmin\Template;
use function __;
use function count;
final class ChangeController extends AbstractController
{
/** @var DatabaseInterface */
private $dbi;
/** @var ColumnsDefinition */
private $columnsDefinition;
public function __construct(
ResponseRenderer $response,
Template $template,
DatabaseInterface $dbi,
ColumnsDefinition $columnsDefinition
) {
parent::__construct($response, $template);
$this->dbi = $dbi;
$this->columnsDefinition = $columnsDefinition;
}
public function __invoke(): void
{
if (isset($_GET['change_column'])) {
$this->displayHtmlForColumnChange(null);
return;
}
$selected = $_POST['selected_fld'] ?? [];
if (empty($selected)) {
$this->response->setRequestStatus(false);
$this->response->addJSON('message', __('No column selected.'));
return;
}
$this->displayHtmlForColumnChange($selected);
}
/**
* Displays HTML for changing one or more columns
*
* @param array|null $selected the selected columns
*/
private function displayHtmlForColumnChange(?array $selected): void
{
$GLOBALS['num_fields'] = $GLOBALS['num_fields'] ?? null;
if (empty($selected)) {
$selected[] = $_REQUEST['field'];
$selected_cnt = 1;
} else { // from a multiple submit
$selected_cnt = count($selected);
}
/**
* @todo optimize in case of multiple fields to modify
*/
$fields_meta = [];
for ($i = 0; $i < $selected_cnt; $i++) {
$value = $this->dbi->getColumn($GLOBALS['db'], $GLOBALS['table'], $selected[$i], true);
if (count($value) === 0) {
$message = Message::error(
__('Failed to get description of column %s!')
);
$message->addParam($selected[$i]);
$this->response->addHTML($message->getDisplay());
} else {
$fields_meta[] = $value;
}
}
$GLOBALS['num_fields'] = count($fields_meta);
/**
* Form for changing properties.
*/
$checkUserPrivileges = new CheckUserPrivileges($this->dbi);
$checkUserPrivileges->getPrivileges();
$this->addScriptFiles(['vendor/jquery/jquery.uitablefilter.js', 'indexes.js']);
$this->checkParameters(['server', 'db', 'table', 'num_fields']);
$templateData = $this->columnsDefinition->displayForm(
'/table/structure/save',
$GLOBALS['num_fields'],
null,
$selected,
$fields_meta
);
$this->render('columns_definitions/column_definitions_form', $templateData);
}
}