phpmyadmin/libraries
Jeff Chan 896fe8169a Fix PMA_arrayWalkRecursive to ensure single pass thru keys
Fix a bug with PMA_arrayWalkRecursive that causes it to apply a function
to its keys/values more than once. A previously incorrect test is fixed
as well.

The bug happens because when keys are modified, PHP's foreach loops
through the new keys again. This does not usually happen unless the
iterating array is passed through by reference (or has refcount=1).
See: http://stackoverflow.com/a/14854568/791890

Please see #936 for full explanation.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-02-17 03:09:34 +00:00
..
bfShapeFiles Correct and complete license notices for bfShapeFiles. 2013-10-01 12:10:29 -04:00
config Rearange the order of export sql related user preferences 2014-02-08 17:25:36 +05:30
dbi Don't use function in for loop test. 2013-12-18 21:29:34 +01:00
engines Fix coding style 2014-01-28 10:12:30 -05:00
gis Suffix files containing classes with .class.php file extension 2014-01-22 18:19:48 +05:30
navigation Fix merge conflict 2014-02-09 07:13:36 -05:00
php-gettext Revert the commit 7c971c0 2013-12-20 22:47:20 +05:30
phpseclib/Crypt Convert end of lines 2013-08-06 13:01:37 -04:00
plugins Merge branch 'QA_4_1' 2014-02-08 13:06:10 +05:30
properties Use stable sort for removeProperty of OptionsPropertyGroup. 2014-02-12 03:07:27 +00:00
rte Merge commit '27f616e' 2014-02-12 08:15:54 -05:00
schema Spaces around . operator 2014-01-08 18:06:02 +05:30
tcpdf Update TCPDF to version 6.0.055 2014-01-22 17:10:05 +05:30
.gitignore
Advisor.class.php PHPCS update. 2013-12-17 18:53:14 +01:00
advisory_rules.txt bug #4244 Advisor complaints about MariaDB 10.x is version less than 5.1 2014-01-23 13:09:33 -05:00
bookmark.lib.php Spaces around . operator 2014-01-08 18:06:02 +05:30
browse_foreigners.lib.php Refactor: new PMA_getDescriptionAndTitle() 2014-01-09 06:39:40 -05:00
build_html_for_db.lib.php Do not use HTML entities for quotes inside translatable messages 2014-02-02 10:06:23 +01:00
charset_conversion.lib.php Fix PMA_convertString which use a wrong variable. 2013-11-05 20:51:49 +01:00
check_user_privileges.lib.php Fix coding style 2013-09-23 08:13:56 -04:00
cleanup.lib.php Better function names 2013-05-02 15:01:11 +02:00
common.inc.php Fix for bug#4237. 2014-02-07 11:56:46 +05:30
Config.class.php 4.1.8-dev 2014-02-09 07:27:50 -05:00
config.default.php Support for export server/db/table without views 2014-02-06 23:03:04 +05:30
config.values.php Fix merge conflicts 2014-01-15 08:53:00 -05:00
core.lib.php Fix PMA_arrayWalkRecursive to ensure single pass thru keys 2014-02-17 03:09:34 +00:00
create_addfield.lib.php Fix coding style 2014-01-08 14:35:15 +05:30
data_dictionary_relations.lib.php Various coding style fixes 2013-08-07 11:59:01 +02:00
database_interface.inc.php Fix coding style 2013-12-18 11:22:58 +05:30
DatabaseInterface.class.php Minor PHPCS corrections. 2014-02-01 17:30:13 +01:00
db_common.inc.php Rename variable to match current meaning 2014-01-06 11:11:34 +01:00
db_info.inc.php Merge branch 'QA_4_1' 2014-01-09 08:11:51 -05:00
db_table_exists.lib.php Better names for URL generating functions 2013-08-07 10:58:17 +02:00
DBQbe.class.php Merge branch 'QA_4_1' 2014-02-08 19:51:13 -05:00
DbSearch.class.php Spaces around . operator 2014-01-08 18:06:02 +05:30
display_change_password.lib.php [interface] Break "Edit privileges" with sub-menus 2014-01-06 21:22:31 +01:00
display_create_database.lib.php Spaces around . operator 2014-01-08 18:06:02 +05:30
display_create_table.lib.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
display_export.inc.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
display_export.lib.php Fix merge conflicts 2014-01-15 08:53:00 -05:00
display_git_revision.lib.php Consistently include colon in strings to translate 2013-04-25 14:22:31 +02:00
display_import_ajax.lib.php Remove compatibility code for PHP 5.2 2013-07-01 15:29:56 +02:00
display_import.inc.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
display_import.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
display_select_lang.lib.php Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
display_structure.inc.php Fix bug#4274 index_div was being added twice 2014-02-06 00:04:29 +05:30
DisplayResults.class.php Merge branch 'QA_4_1' 2014-02-16 12:57:37 -05:00
Error_Handler.class.php Fix typo 2013-12-15 14:12:35 -05:00
error_report.lib.php (Feature Request 1466) 2014-01-08 19:08:18 +05:30
Error.class.php bug #3889 When login fails and error display is active, login data is displayed (regression) 2014-01-24 10:53:53 -05:00
error.inc.php Disable response wrapper in fatal error path 2013-06-11 08:57:49 +02:00
export.lib.php Support for export server/db/table without views 2014-02-06 23:03:04 +05:30
file_listing.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
File.class.php Missing punctuation at the end of sentences 2014-01-29 15:21:02 +01:00
Font.class.php move charLists generation to seperate method 2013-09-30 13:34:22 +02:00
Footer.class.php Fix bug #4204 Reloading user privileges hides user groups submenu 2014-01-15 16:47:54 +01:00
Header.class.php Missing punctuation at the end of sentences 2014-01-29 15:21:02 +01:00
iconv_wrapper.lib.php Various coding style fixes 2013-08-07 11:59:01 +02:00
import.lib.php Add missing full stops at the end of a sentence 2014-02-02 11:19:15 +01:00
Index.class.php Spaces around . operator 2014-01-08 18:06:02 +05:30
index.lib.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
information_schema_relations.lib.php Merge branch 'QA_4_0' 2013-09-14 14:45:27 +05:30
insert_edit.lib.php Merge commit '2453a15' 2014-02-03 12:30:23 -05:00
ip_allow_deny.lib.php Rewrite to decrease number of nested levels. 2013-12-07 22:16:16 +01:00
js_escape.lib.php Rewrite to decrease number of nested levels. 2013-12-07 22:16:16 +01:00
kanji-encoding.lib.php Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
List_Database.class.php Update PHPDoc. 2013-11-10 10:28:05 +01:00
List.class.php Fix PHPCS errors. 2013-12-11 22:13:10 +01:00
logging.lib.php Better name for a function 2013-05-10 10:10:09 +02:00
Menu.class.php Rename variable to match current meaning 2014-01-06 11:11:34 +01:00
Message.class.php Correct punctuation for sentences 2014-02-02 11:19:15 +01:00
mime.lib.php Document parameter 2013-05-10 10:09:05 +02:00
mult_submits.inc.php bug #4083 row deleting isn't binlogs friendly 2013-11-19 12:55:56 -05:00
mult_submits.lib.php Remove unused local variables. 2013-12-21 23:19:26 +01:00
mysql_charsets.inc.php Various coding style fixes 2013-08-07 11:59:01 +02:00
mysql_charsets.lib.php Minor PHPDoc modifications. 2013-12-07 19:00:53 +01:00
opendocument.lib.php Spaces around . operator 2014-01-08 18:06:02 +05:30
operations.lib.php Merge branch 'QA_4_1' 2014-01-09 18:46:42 +05:30
OutputBuffering.class.php Update PHPDoc. 2013-11-10 10:28:05 +01:00
parse_analyze.inc.php Another case for bug #4239 2014-01-21 05:52:25 -05:00
Partition.class.php Convert database interface to a class 2013-05-24 17:30:59 +05:30
PDF.class.php Fix typos 2014-01-09 05:58:44 -05:00
plugin_interface.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
PMA.php Fix merge conflicts 2013-07-17 15:05:23 -04:00
pmd_common.php Spaces around . operator 2014-01-08 17:26:27 +05:30
RecentTable.class.php Correct punctuation for sentences 2014-02-02 11:38:49 +01:00
relation_cleanup.lib.php Wrap some long lines 2013-04-12 22:38:27 +05:30
relation.lib.php Rename too short variables. 2014-01-04 20:46:18 +01:00
replication_gui.lib.php Correct punctuation for sentences 2014-02-02 11:19:15 +01:00
replication.inc.php Fix undefined variable notice 2014-01-25 10:31:59 -05:00
Response.class.php Fix typo 2013-12-10 06:13:43 -05:00
sanitizing.lib.php Allow local links to documentation 2013-09-12 10:03:19 +02:00
Scripts.class.php Merge pull request #808 from Tithugues/nestedLevels 2013-12-27 05:33:10 -08:00
select_lang.lib.php Fix PHPCS errors. 2013-12-20 23:34:51 +01:00
select_server.lib.php Better names for URL generating functions 2013-08-07 10:58:17 +02:00
server_bin_log.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
server_collations.lib.php PHPDoc update. 2014-01-09 20:51:40 +01:00
server_common.inc.php Better names for URL generating functions 2013-08-07 10:58:17 +02:00
server_common.lib.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
server_databases.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
server_engines.lib.php Better names for URL generating functions 2013-08-07 10:58:17 +02:00
server_plugins.lib.php Don't use function in for loop test. 2013-12-18 21:29:34 +01:00
server_privileges.lib.php Correct punctuation for sentences 2014-02-02 11:19:15 +01:00
server_status_advisor.lib.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
server_status_monitor.lib.php Minor PHPCS corrections. 2014-02-01 17:30:13 +01:00
server_status_queries.lib.php Doc comment improvements 2013-11-29 23:23:19 +05:30
server_status_variables.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
server_status.lib.php Rename too short variables. 2014-01-04 20:46:18 +01:00
server_user_groups.lib.php Spaces around . operator 2014-01-08 18:06:02 +05:30
server_users.lib.php Move user group related functions to a lib file of its own 2013-09-09 07:10:06 +05:30
server_variables.lib.php Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
ServerStatusData.class.php Update PHPDoc. 2013-11-10 10:28:05 +01:00
session.inc.php Fix typos 2013-12-21 07:42:53 -05:00
special_schema_links.lib.php Merge branch 'QA_4_0' 2013-09-14 17:10:01 +05:30
sql_query_form.lib.php Correct punctuation for sentences 2014-02-02 11:19:15 +01:00
sql.lib.php Merge commit 'ac80367' 2014-02-16 06:49:53 -05:00
sqlparser.data.php Remove no longer needed doc name mappings 2013-08-07 08:11:32 +02:00
sqlparser.lib.php Merge commit 'cd46fbe' 2014-01-21 05:54:07 -05:00
sqlvalidator.class.php Fix PHPCS errors. 2013-12-11 22:13:10 +01:00
sqlvalidator.lib.php Fix PHPDoc. 2013-11-08 22:41:05 +01:00
StorageEngine.class.php Fix coding style 2014-01-08 14:35:15 +05:30
String.class.php Fix multibyte ord issue 2013-08-21 19:02:08 +05:30
string.inc.php Fix typo 2013-07-29 04:54:48 -04:00
StringAbstractType.class.php Move interfaces into files of their own 2013-07-28 00:04:12 +05:30
StringByte.int.php Add ord() method to the parent interface 2013-08-21 21:37:28 +05:30
StringCType.class.php Move interfaces into files of their own 2013-07-28 00:04:12 +05:30
StringMB.class.php Remove trailing white spaces 2013-10-19 14:29:05 +05:30
StringNative.class.php Fix multibyte ord issue 2013-08-21 19:02:08 +05:30
StringNativeType.class.php Use meaningful variable names 2014-01-21 18:34:17 +05:30
StringType.int.php Move interfaces into files of their own 2013-07-28 00:04:12 +05:30
structure.lib.php Merge branch 'QA_4_1' 2014-02-15 09:35:38 -05:00
sysinfo.lib.php Spaces around . operator 2014-01-08 18:06:02 +05:30
Table.class.php Correct punctuation for sentences 2014-02-02 11:38:49 +01:00
TableSearch.class.php Fix coding style 2014-01-08 14:35:15 +05:30
tbl_chart.lib.php Stacking only makes sense for some chart types 2013-12-25 09:12:01 +05:30
tbl_columns_definition_form.inc.php fixed bug #4181: set regenerate to save the state of filled columns 2013-12-13 21:43:05 +05:30
tbl_columns_definition_form.lib.php Better and more compact message for opening ENUM/SET editor 2014-02-02 11:19:15 +01:00
tbl_common.inc.php Rename variable to match current meaning 2014-01-06 11:11:34 +01:00
tbl_gis_visualization.lib.php Suffix files containing classes with .class.php file extension 2014-01-22 18:19:48 +05:30
tbl_indexes.lib.php Remove unused local variables. 2013-12-21 23:09:43 +01:00
tbl_info.inc.php Convert database interface to a class 2013-05-24 17:30:59 +05:30
tbl_printview.lib.php Fix coding style 2014-01-08 14:35:15 +05:30
tbl_relation.lib.php Correct punctuation for sentences 2014-02-02 11:19:15 +01:00
tbl_tracking.lib.php Fix spacing issue with tracking view 2014-01-17 11:22:25 -05:00
tbl_views.lib.php Don't use function in for loop test. 2013-12-18 22:18:02 +01:00
Theme_Manager.class.php Specify types 2013-11-11 07:14:37 +05:30
Theme.class.php Spaces around . operator 2014-01-08 18:06:02 +05:30
Tracker.class.php Fix coding style 2014-01-08 14:35:15 +05:30
transformations.lib.php Rename variable. 2014-01-05 15:21:27 +01:00
Types.class.php Fix coding style 2013-11-28 00:04:20 +05:30
url_generating.lib.php Spaces around . operator 2014-01-08 17:26:27 +05:30
user_preferences.inc.php Refactored ConfigFile class so that it is no longer a singleton 2013-11-03 12:54:20 +01:00
user_preferences.lib.php Fix PHPCS errors. 2013-12-11 20:44:12 +01:00
Util.class.php Cast unit size value for formatByteDown to float to avoid overflow. 2014-02-10 18:25:54 +00:00
vendor_config.php bug #4247 open_basedir warnings on export page 2014-01-24 13:34:39 -05:00
zip_extension.lib.php Fix wrong refactoring. 2013-12-21 22:10:06 +01:00
zip.lib.php Use pack instead of manual conversion using evil eval 2013-08-11 11:37:39 +02:00