gian/seaweedfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

review: share cache helper across misc tests; check io.ReadAll error

Browse Source 
Accelerate and Logging tests now run through newMiscTestServer like
the others so the checkBucket guard sees a cached bucket; the
ReadAll error is explicitly checked.
This commit is contained in:
Chris Lu 2026-05-19 15:20:51 -07:00
parent 377d151507
commit a82c5ce942
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
weed/s3api/s3api_bucket_handlers_misc_test.go
View File

@ -103,7 +103,7 @@ func TestPutBucketRequestPaymentRequesterRejected(t *testing.T) {
}
func TestGetBucketAccelerateConfiguration(t *testing.T) {
s3a := &S3ApiServer{}
s3a := newMiscTestServer(t, "b")
req := newBucketRequest(http.MethodGet, "b", "accelerate=", "")
rec := httptest.NewRecorder()
@ -112,7 +112,10 @@ func TestGetBucketAccelerateConfiguration(t *testing.T) {
if rec.Code != http.StatusOK {
t.Fatalf("status = %d, want %d", rec.Code, http.StatusOK)
}
body, _ := io.ReadAll(rec.Body)
body, err := io.ReadAll(rec.Body)
if err != nil {
t.Fatalf("read body: %v", err)
}
got := string(body)
if !strings.Contains(got, "<AccelerateConfiguration") {
t.Fatalf("missing root element: %s", got)
@ -126,7 +129,7 @@ func TestGetBucketAccelerateConfiguration(t *testing.T) {
}
func TestGetBucketLogging(t *testing.T) {
s3a := &S3ApiServer{}
s3a := newMiscTestServer(t, "b")
req := newBucketRequest(http.MethodGet, "b", "logging=", "")
rec := httptest.NewRecorder()