Commit Graph

162519 Commits

Author SHA1 Message Date
Igor Fedotov
df23e844bc kv/Rocksdbstore: change output format for short txc dump.
Plus refactors txc dumping  code to permit Unit Testing for it.

Here is the new output sample:
Short form:
 DF:D*3,DF:O,MF:A,PF:O*2,PF:P,...*2
Verbose form:
PutCF(prefix = O, key = 'key', val len = 5)
PutCF(prefix = P, key = 'key2', val len = 6)
PutCF(prefix = O, key = 'key3', val len = 6)
DeleteCF(prefix = O, key = 'A1')
DeleteCF(prefix = D, key = 'A1')
DeleteCF(prefix = D, key = 'A2')
DeleteCF(prefix = D, key = 'A3')
MergeCF(prefix = A, key = 'A5', val len = 6)
<...>*2

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2026-07-03 19:12:13 +03:00
Igor Fedotov
7dd1f39a70 os/bluestore: rename bluestore_log_op_verbose to
bluestore_log_op_verbose_kv_txc.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2026-07-03 19:12:03 +03:00
Igor Fedotov
ae39d63a93 kv/RocksdbKVStore: track max latencies for perf counters
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2026-07-01 16:19:11 +03:00
Igor Fedotov
1b443af34c os/bluesore,kv/rocksdbstore: dump KV txc ops when slow
Depending on bluestore_log_op_verbose parameter one can see either
short:
2026-05-20T19:45:05.792+0300 7f60980006c0  0
bluestore(/home/if/ceph.2/build/dev/osd0) log_latency_fn slow operation
observed for _txc_committed_kv, latency = 0.004759922s, txc =
0x55c357bde900, txc bytes = 2756989, txc ios = 43, txc cost = 31566989,
txc onodes = 1, DB ops = ' p:P, p:P, p:O, p:O, p:O, p:O, p:O, p:O, p:O,
p:O, p:O, p:L, m:b, m:b, m:b, m:b, m:b, m:b, m:b, m:b, m:b, m:b, m:b,
m:b', DB updates = 24, DB bytes = 8937, cost max = 95489052 on
2026-05-20T18:38:20.749901+0300, txc max = 100 on
2026-05-20T18:38:21.215016+0300

or verbose:
2026-05-20T18:42:01.551+0300 7f60980006c0  0
bluestore(/home/if/ceph.2/build/dev/osd0) log_latency_fn slow operation
observed for _txc_committe
d_kv, latency = 0.003735413s, txc = 0x55c356a35500, txc bytes = 2757061,
txc ios = 44, txc cost = 32237061, txc onodes = 1, DB ops = '
PutCF( prefix = P key =
0x0000000000000499'.0000000032.00000000000000000005' value size = 185)
PutCF( prefix = P key = 0x0000000000000499'._fastinfo' value size = 194)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F0000000078
value size = 453)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F0006000078
value size = 455)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F000C000078
value size = 455)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F0012000078
value size = 455)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F0018000078
value size = 455)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F001E000078
value size = 455)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F0024000078
value size = 455)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F002A000078
value size = 21)
PutCF( prefix = O key =
0x7F8000000000000002DB7D25F2'!c!='0xFFFFFFFFFFFFFFFEFFFFFFFFFFFFFFFF6F
value size = 388)
MergeCF( prefix = b key = 0x0000000019080000 value size = 16)
MergeCF( prefix = b key = 0x0000000019100000 value size = 16)
MergeCF( prefix = b key = 0x0000000019180000 value size = 16)
MergeCF( prefix = b key = 0x0000000019200000 value size = 16)
MergeCF( prefix = b key = 0x0000000019280000 value size = 16)
MergeCF( prefix = b key = 0x0000000019300000 value size = 16)
MergeCF( prefix = T key = 0x0000000000000002 value size = 40)', DB
updates = 18, DB bytes = 4668, cost max = 95489052 on
2026-05-20T18:38:20.74
9901+0300, txc max = 100 on 2026-05-20T18:38:21.215016+0300

operations list when BlueStore observes slow op on KV commit.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2026-07-01 16:19:11 +03:00
Kefu Chai
cc1f41c8d2
Merge pull request #69156 from sunyuechi/wip-riscv64-jsonnet-bundler-v0.6.0
monitoring/ceph-mixin: bump jsonnet-bundler to v0.6.0

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2026-07-01 18:57:00 +08:00
Afreen Misbah
cfe12305fb
Merge pull request #68180 from rhcs-dashboard/bug-13712
mgr/dashboard: Add option should be enabled even if allow all host access is enabled in nvme/tcp

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Abhishek Desai <abhishek.desai1@ibm.com>
Reviewed-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
Reviewed-by: Sagar Gopale <sagar.gopale@ibm.com>
2026-07-01 16:21:00 +05:30
Afreen Misbah
2538df0b13
Merge pull request #69241 from rhcs-dashboard/bug-3990-pr1
mgr/dashboard: NVMe Onboarding  Setup Cards
2026-07-01 15:47:44 +05:30
Venky Shankar
8b05b5da09
Merge pull request #69021 from salieri11/igolikov-bug-74625
client: keep dentry alive while unlinking trimmed cache entries

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2026-07-01 13:35:58 +05:30
bluikko
d821b2814f
Merge pull request #67007 from bluikko/wip-doc-radosgw-ref-links-split2
doc/radosgw: change all intra-docs links to use ref (3 of 6)
2026-07-01 13:07:28 +07:00
Venky Shankar
fc9f8642b2 Merge PR #66558 into main
* refs/pull/66558/head:
	qa/cephfs: minor fix in comment
	qa/cephfs: give more time to tests in test_clone_stats.py
	qa/cephfs: increase number of files to cloned in test_clone_stats.py
	volumes/stats_util: improve log messages

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2026-07-01 11:14:38 +05:30
Igor Golikov
ad95bb5450 client: fix Dentry UAF by holding DentryRef across unlink
Hold a function-scoped DentryRef in Client::unlink() to keep the dentry
alive through the entire teardown sequence.

Without the O_DIRECTORY dentry pin (PR #60909, merged after v19.2.1),
opening a directory does not call _ll_get(), so the dentry stays at
ref=1 while inode->dir is still active. When trim_cache() evicts this
dentry, Dentry::unlink() calls put() for the dir pin, ref drops to 0,
and the dentry is freed while Client::unlink() still needs it for
detach/lru_remove.

A function-scoped DentryRef guarantees the dentry survives until after
it has been properly removed from the dir and LRU, regardless of pin
state.

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/74625
2026-07-01 11:04:38 +05:30
Igor Golikov
227b558f20 client: add assert to catch dentry ref drop during unlink
Add ceph_assert(dn->ref > 0) after Dentry::unlink() in Client::unlink()
to catch the case where internal put() calls drop the dentry reference
to zero before we proceed to detach/lru_remove.

This turns a silent use-after-free into a clean assertion failure with
a full stack trace, making it possible to catch the exact conditions
in a test environment.

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/74625
2026-07-01 11:04:38 +05:30
Kefu Chai
94bf1d7087
Merge pull request #69851 from anthonymicmidd/foundation-members
doc/foundation: Removed members section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2026-07-01 10:00:55 +08:00
Anthony M
901a4944bb doc/foundation: Removed members section
These updates will allow us to update a single page rather than two. The detailed member lists and categories have been removed. I've added a redirect for visitors to this page to https://ceph.io/en/foundation/members/

Signed-off-by: Anthony M <amiddleton@linuxfoundation.org>
2026-07-01 09:44:27 +08:00
Yuri Weinstein
36ebea8177
Merge pull request #69440 from jdurgin/wip-release-notes-script
scripts/ceph-release-notes: use raw strings for escaped characters

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
2026-06-30 15:36:42 -07:00
Jesse Williamson
9922bd1096
Merge pull request #65535 from ceph/jfw-wip-rgw-libfdb
Add libfdb: Experimental FoundationDB support
2026-06-30 15:07:58 -07:00
Ilya Dryomov
97128d4d3b
Merge pull request #69836 from sunyuechi/wip-librbd-trash-purge-uaf
librbd: fix use-after-free in trash purge on image open error

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2026-06-30 21:34:36 +02:00
Sun Yuechi
f18247e32b librbd: fix use-after-free in trash purge on image open error
When ImageState::open() fails with an error other than -ENOENT, it
asynchronously deletes the ImageCtx before returning. The trash purge
loop only skipped the -ENOENT case and fell through on every other
error, dereferencing the already-freed ictx in diff_iterate() and
state->close(). Add the missing continue so a failed open is skipped.

The fall-through dates back to 504f4e78, which split `if (r < 0)
continue` to log non-ENOENT errors but dropped the continue.

Fixes: https://tracker.ceph.com/issues/77836
Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
2026-07-01 00:13:42 +08:00
Jesse F. Williamson
132c77376f Add FoundationDB client library "libfdb".
Assisted-by: Codex:GPT-5

Signed-off-by: Jesse F. Williamson <jfw@ibm.com>
2026-06-30 09:06:20 -07:00
Venky Shankar
1d7f80b43b
Merge pull request #69031 from neesingh-rh/wip-71795
qa: fixing failures in TestShellOpts

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2026-06-30 19:10:09 +05:30
Venky Shankar
084d84f3f9 Merge PR #69324 into main
* refs/pull/69324/head:
	libcephfs: increment extra version to indicate new flock functions
	libcephfs: add public api for ceph_ll_flock

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2026-06-30 19:09:27 +05:30
Venky Shankar
24a317bc3c
Merge pull request #66723 from rishabh-d-dave/snap-metadata-mutate
cephfs: allow snapshot metadata mutations

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2026-06-30 19:06:39 +05:30
Casey Bodley
283108e66b
Merge pull request #69371 from cbodley/wip-76961
qa/dnsmasq: use managed dnsmasq instead of editing resolv.conf

Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
2026-06-30 08:30:26 -04:00
Igor Fedotov
a65fd3baf3
Merge pull request #66344 from JoshuaGabriel/68797-bdev-expand-admin
os/bluestore: asok command to expand block device and Bluestore while OSD is running

Revewed-by: Igor Fedotov <igor.fedotov@croit.io>
2026-06-30 15:13:45 +03:00
Redouane Kachach
965ded5698
Merge pull request #69808 from rkachach/fix_issue_bump_python_version
mgr/cephadm: bump Python version path mapped in kcli dev env

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Kobi Ginon <kginon@redhat.com>
2026-06-30 14:09:48 +02:00
Igor Fedotov
0f23c68bf6
Merge pull request #69820 from sunyuechi/wip-blk-aio-fix-paren
blk/aio: fix mismatched parenthesis in POSIX AIO submit path

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
2026-06-30 15:06:20 +03:00
pujashahu
6182e67ea4 mgr/dashboard: NVMe Onboarding Setup Cards
Fixes: https://tracker.ceph.com/issues/77067

Signed-off-by: pujaoshahu <pshahu@redhat.com>
2026-06-30 17:32:06 +05:30
Ronen Friedman
5e9da92c17
Merge pull request #69711 from ronen-fr/wip-rf-mold3
cmake: implement WITH_MOLD option for Mold linker support

Reviewed-by: Mark Kogan <mkogan@redhat.com>
2026-06-30 14:49:36 +03:00
Redouane Kachach
32dccfab54
Merge pull request #66051 from ShwetaBhosale1/fix_issue_73633_haproxy_service_should_not_be_restart_on_nfs_updates
haproxy service should not be restart on nfs updates

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2026-06-30 13:43:52 +02:00
Redouane Kachach
b9fdd67b58
Merge pull request #66663 from Shubhaj1810/fix-issue-2384421
mgr/nfs: include placement details and active/passive roles in cluster info

Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
2026-06-30 13:42:16 +02:00
Redouane Kachach
9eb9e306d5
Merge pull request #67195 from kginonredhat/fix-ipv6-lo-routes
cephadm: allow lo routes on loopback interface, allow bgp-routes for list-networks

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2026-06-30 13:40:29 +02:00
Redouane Kachach
cc3f8a69b3
Merge pull request #69043 from yaelazulay-redhat/issue_76565_keep_mgr_ports_in_sync_when_modules_are_enabled_disabled
cephadm: keep mgr ports in sync when modules are enabled/disabled

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2026-06-30 13:36:34 +02:00
Redouane Kachach
fbdf45a6e3
Merge pull request #69192 from kginonredhat/issue-76981-Rocky10-failure-cause-by-Cannot-register-NFS-V3-on-TCP
cephadm: start rpcbind before NFS-Ganesha for NFSv3 TCP

Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
2026-06-30 13:34:28 +02:00
Redouane Kachach
ebbb3e19f1
Merge pull request #69283 from Shubhaj1810/node-exporter
cephadm: report intentionally stopped daemons as stopped

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2026-06-30 13:31:24 +02:00
pujaoshahu
fcac016ae4 mgr/dashboard: Add option should be enabled even if allow all host access is enabled in nvme/tcp
Fixes: https://tracker.ceph.com/issues/75509
Signed-off-by: pujaoshahu <pshahu@redhat.com>
2026-06-30 15:18:13 +05:30
Xuehan Xu
fd808e8453
Merge pull request #69301 from xxhdx1985126/wip-seastore-circular_bounded_journal-tail-fix
crimson/os/seastore/journal/circular_bounded_journal: find the real journal tail on startup

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
2026-06-30 13:58:38 +08:00
Sun Yuechi
832d6122e9 blk/aio: fix mismatched parenthesis in POSIX AIO submit path
The condition `if ((cur->n_aiocb == 1) {` has an unbalanced
parenthesis and fails to compile. This code is only built on the
HAVE_POSIXAIO (BSD) path, so the breakage is normally hidden.

Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
2026-06-29 21:07:56 -07:00
Xuehan Xu
c2a69f1663
Merge pull request #69615 from xxhdx1985126/wip-77548
crimson/osd/pg_backend: mark the omaps of the object dirty when removing omap keys

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2026-06-30 10:38:19 +08:00
Brad Hubbard
54de613cdd
Merge pull request #69278 from badone/wip-badone-tracker-76473-dont-inline-and-log-mem0ry-leak
common: Log when we leak and disallow inlining

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2026-06-30 11:26:16 +10:00
Kefu Chai
239be57c06
Merge pull request #69437 from tchaikov/wip-crimson-osd-coroutinize
crimson/osd: coroutinize and cleanups

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2026-06-30 08:18:33 +08:00
Kefu Chai
5220368596
Merge pull request #69537 from tchaikov/wip-crimson-compile-time-fmt-check
crimson: fix malformed logging message and enable compile-time fmt check

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2026-06-30 08:18:18 +08:00
Afreen Misbah
44b78ff004
Merge pull request #69070 from rhcs-dashboard/73367-carbonize-administration-module
mgr/dashboard : Carbonize configuration form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Devika Babrekar <devika.babrekar@ibm.com>
2026-06-30 01:35:54 +05:30
Nizamudeen A
7163b736cd
Merge pull request #69487 from rhcs-dashboard/fix-4878
mgr/dashboard : Implement dependent resource handling for gateway Deletion

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sagar Gopale <sagar.gopale@ibm.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
2026-06-29 18:03:12 +05:30
Redouane Kachach
0a528685d5
mgr/cephadm: bump Python version path mapped in kcli dev env
Bump Python version path mapped in kcli dev env from 3.9 to 3.12

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
2026-06-29 14:20:22 +02:00
Kefu Chai
b34429657e
Merge pull request #69794 from tchaikov/wip-crimson-test-thrash-teardown
crimson/test: stop the messenger-thrash config on every exit path

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2026-06-29 16:32:57 +08:00
Kefu Chai
66547e6c82
Merge pull request #69755 from tchaikov/wip-mgr-remote-pyunicode-leak
mgr: fix PyObject leak in the remote() pickle calls

Reviewed-by: Matthew N. Heler <matthew.heler@hotmail.com>
2026-06-29 16:29:57 +08:00
Nizamudeen A
748cbef07b
Merge pull request #69413 from rhcs-dashboard/fix-3958-autofetch
mgr/dashboard: Add auto-fetch listeners option in subsystem page

Reviewed-by: Sagar Gopale <sagar.gopale@ibm.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
2026-06-29 13:52:34 +05:30
Nizamudeen A
40a7245065
Merge pull request #69550 from rhcs-dashboard/fix-5059
mgr/dashboard: "Any" initiator entry appears in the Initiator table after selecting "All Hosts Allowed" during subsystem creation

Reviewed-by: Naman Munet <nmunet@redhat.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Sagar Gopale <sagar.gopale@ibm.com>
2026-06-29 13:37:10 +05:30
Nizamudeen A
4a7c4fb49c
Merge pull request #69424 from rhcs-dashboard/fix-4075
mgr/dashboard: NVME- Remove block pool from create gateway page

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Sagar Gopale <sagar.gopale@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2026-06-29 13:36:27 +05:30
NitzanMordhai
dd5cbcdf5c
Merge pull request #69675 from NitzanMordhai/wip-nitzan-config-trim-key-trail-lead-spaces
mon/config: trim whitespace in config target
2026-06-29 11:02:24 +03:00