gian/cloudstack-mirror
1
0
Fork 0
mirror of https://github.com/apache/cloudstack synced 2026-08-30 08:59:20 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
27,960 Commits 394 Branches 330 Tags 895 MiB
76a10351a5
Commit Graph

27960 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rohit Yadav
76a10351a5 CLOUDSTACK-8457: SAML UI enhancements 
Add option to authorize SAML SSO for user when adding user. Appends a domain to
user/account name if global setting is enabled, useful in case of multiple IDP
server. By default the setting is set to false (keep as it is).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #575

(cherry picked from commit 7d11c7bc70)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-07-14 10:20:30 +05:30
Wido den Hollander
63688e70a0 kvm: More verbose logging around storage pools in the Agent 2015-07-13 16:53:26 +02:00
Wido den Hollander
24f8e66e93 kvm: Write Libvirt instead of LibVirt 2015-07-13 16:22:33 +02:00
Wido den Hollander
7c37ba73a3 kvm: Add more verbose logging about what is happening with Libvirt connections 2015-07-13 16:21:41 +02:00
nitt10prashant
5a8648f958 CLOUDSTACK-8620 :skip test cases if rbd storage is not available in lxc setup 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #570
 2015-07-10 15:15:50 +02:00
nitt10prashant
efee194b91 CLOUDSTACK-8620 :skip test cases if rbd storage is not available in lxc setup 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-07-10 15:15:50 +02:00
Rohit Yadav
42940a8828 CLOUDSTACK-8622: Reinstate working sessions in browser 
- Login is based on sessionkey HttpOnly Cookie
- ApiServlet does login verification using sessionKey from both the request cookies
  and the API parameters. In both cases, if either or both are passed they should
  match the sessionKey stored in the current session of the HttpRequest
- UI: it no longer needs to read or set sessionkey cookie
- UI: it no longer needs to return g_sessionKey value in the API requests, though
  to support a sso mechanism g_sessionKey is still passed in the API is not null
- Secure jsessionid cookie is set to be HttpOnly and Secure
- SAML login should also set HttpOnly cookie before redirecting to UI
- SAML: listIdps & getSPMetadata APIs are readonly now, won't log out a logged in user

Performed tests (login, saml login if applicable, page refreshes, opening
multiple tabs, logout) with following combinations:
- SAML disabled, normal auth as admin, domain-admin and user
- SAML enabled, normal auth as admin, domain-admin and user; and saml sso as
  admin, domain-admin and user

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #574
This closes #308
 2015-07-10 17:25:07 +05:30
Jayapal
3df847dfbb CLOUDSTACK-8324: Added integration tests for dhcp dns offload feature 
This closes #568
 2015-07-10 09:49:32 +05:30
Jayapal
140cd7c227 CLOUDSTACK-8324: Fixed config key in multiple places 2015-07-10 09:47:09 +05:30
Jayapal
14d53634a8 CLOUDSTACK-8324: Removed using config drive label from the uservmservice 2015-07-10 09:47:03 +05:30
Jayapal
deb694c201 CLOUDSTACK-8324: Added migration changes for config drive 2015-07-10 09:39:27 +05:30
Ilya Musayev
469d9ebed4 CLOUDSTACK-8624: Added the support for mysql db port and lowered the requiremnts for available disk capacity to 2.1GB VS original 5GB as it was too excessive. 2015-07-10 07:24:41 +05:30
Daan Hoogland
b0136c56e7 coverity 1116564: complicated update of sequences fixed 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #564
 2015-07-09 21:30:24 +02:00
Daan Hoogland
0cd8c06f7d coverity 1116680: update datacentre for ip adresses these resources are created often and will create serious leakage if closing failes 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:24 +02:00
Daan Hoogland
bb2c02d144 coverity 1116693: properties template file creation unlikely but if repetitive, serious. 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:24 +02:00
Daan Hoogland
2c7e19faff coverity 1116544: a lot of the same (probably other coverity ids covered as well) 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:24 +02:00
Daan Hoogland
f8691b2c69 coverity 1116511 and 1116513: try-with-resource on old upgrade script three issues seen by coverity as two. only one occurence of leakage 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:24 +02:00
Daan Hoogland
3bedeeaacc coverity 1116509: heavy entanglement of prepared statements and result sets hope I got the logic right. this is for very old versions, might be worth phasing out unless someone still uses it. 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:23 +02:00
Daan Hoogland
79709cd490 coverity 1116507: one off old upgrade code trivial fix however 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:23 +02:00
Daan Hoogland
dae2e05f3c coverity 1291768: file input stream not severe unless repetitive (property file usually aren't) 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:23 +02:00
Daan Hoogland
803d6ed7df coverity 1296982: standard prepared statement and result set leakage 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:23 +02:00
Daan Hoogland
6376503fe3 coverity 1308118: more resources being opened only one closed on exception nothing was closed 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:23 +02:00
Daan Hoogland
bcc8182f2f findbugs: write to static from instance these are the trivial cases of ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD as reported by findbugs 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #539
 2015-07-09 15:01:58 +02:00
weingartner
25e9918c57 Amend last commit, used 4 spaces in code formatting instead of 1 tab character. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #560
 2015-07-09 13:37:59 +02:00
weingartner
50c4836c9f Cleaned class โ€œcom.cloud.hypervisor.xenserver.resource.XcpOssResourceโ€ that seemed to be forgotten during the evolution of the ACS. It was removed a few methods that were already coded properly in its parent class โ€œcom.cloud.hypervisor.xenserver.resource.CitrixResourceBaseโ€. It was also removed some methods that seemed to cause weird behaviors. The methods removed/fixed are detailed as follows: โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.fillHostInfo(Connection, StartupRoutingCommand) โ€“ it was removed, because it always added the string โ€œ, hvmโ€ to the host capabilities. Therefore, if one uses XCP hypervisor it could cause a lot of trouble when deploying HVM virtual machines in an environment that has PV and HVM clusters. The method is already properly coded in parent class. โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.launchHeartBeat(Connection) โ€“ It was removed. It was not performing anything and always returns a true value. The method of parent class is properly coded and works for XCP environments. The heartbeat plugin exists in XCP environment. โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.initializeLocalSR(Connection) โ€“ it was removed. The method of the parent class works properly for XCP environments. โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.createPatchVbd(Connection, String, VM) โ€“ It was removed. This method causes a bug in XCP environments, because of its half-implementation, it was not possible to migrate system VMs. The parent class implementation works properly for XCP. โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.execute(NetworkUsageCommand) โ€“ removed, hence it was already coded into parent class and its respective wrappers (โ€œcom.cloud.hypervisor.xenserver.resource.wrapper.xcp.XcpServerNetworkUsageCommandWrapperโ€). BTW: I noticed that the class XcpServerNetworkUsageCommandWrapper and XenServer56NetworkUsageCommandWrapper are almost the same, with the exception that XenServer56NetworkUsageCommandWrapper deals with VPC. I believe that those wrappers could be converted into one, and moved to parent. I am not doing that here because I do not have a XCP environment with advanced networking to test it. โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.executeRequest(Command) โ€“ removed, hence it is not needed anymor. โ€ข com.cloud.hypervisor.xenserver.resource.XcpOssResource.execute(StopCommand) โ€“ I did not understand that method. It seemed weird and its removal did not change any behavior of the environment I tested it with. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
 2015-07-09 13:37:59 +02:00
pavan018
97ed8c3af5 Handling Basic zone failures in startVM with false condition 
This closes #569
 2015-07-09 15:54:35 +05:30
pavan018
874445dae3 Changes for Regression failures 2015-07-09 15:54:23 +05:30
Rohit Yadav
7c206c30a5 CLOUDSTACK-8621: Allow UI plugins to be shown on navigation bar 
Introduces a boolean option in UI plugins setting it to 'true' would display
the UI plugin on the left navigation bar.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #563
 2015-07-09 15:25:13 +05:30
nitt10prashant
616b0117cf CLOUDSTACK-8583 : fixing issue related to script test/integration/component/test_stopped_vm.py 
This closes #567
 2015-07-08 16:08:14 +05:30
Ian Southam
820a406d0f Forgot to activate teardown 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #558
 2015-07-08 11:19:13 +02:00
Ian Southam
b7b54f1680 Fixes to enable test to succeed. Small change to Marvin to be able to override retries 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
 2015-07-08 11:19:12 +02:00
Ian Southam
1a93d700dd New test and fixes for vpcr code in 4.6 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
 2015-07-08 11:19:12 +02:00
nitt10prashant
45781b95b9 CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc 
CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc
This closes #565
 2015-07-08 11:54:47 +05:30
Daan Hoogland
4ad178e4b1 rats: licenses added 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #535
 2015-07-07 13:48:20 +02:00
Daan Hoogland
d8ab5f3ab8 findbugs: equals unit tests 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-07 13:48:19 +02:00
Daan Hoogland
34629446b6 findbugs equals(obj) implementations go against the contract these are removed from the call into separate calls 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-07 13:48:19 +02:00
Daan Hoogland
4bba499412 rats: licenses missing 2015-07-06 17:04:26 +02:00
Daan Hoogland
a71c985223 findbugs: added test for getServiceProvider of CreateVpcOffering api 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #538
 2015-07-06 16:22:19 +02:00
Daan Hoogland
e34389a612 findbugs: impossible cast(s) fixed by changing field types 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-07-06 16:22:19 +02:00
Daan Hoogland
31c6b14dd4 Merge branch 'improvement/CLOUDSTACK-8607' change the host password on the host itself via the updateHostPassword API 
- Make sure the new password replaces the old one in the queue
    - Updated the patch files for XenServer
    - Updated the script path on LibvirtComputing class
    - Adding update_host_passwd to VRScripts
    - Add implementation to CitrixUpdateHostPasswordCommandWrapper
    - Improve testUpdateHostPasswordCommand() unit test on CitrixRequestWrapperTest
    - Adding update_host_passwd.sh script
    - Adding the host IP address as an instance variable on UpdateHostPasswordCommand
    - Improving the Unit Test (LibvirtComputingResourceTest) to get it covering the new code
    - Make sure doUpdateHostPassword() doesn't get called if flag is set to false
    - Do not update XenServer hosts if the cluster ID is not informed

    This closes #559
 2015-07-06 16:15:22 +02:00
wilderrodrigues
e348e76eee CLOUDSTACK-8607 - Improving unit tests 
- Adding more unit tests as suggested by Daan and Rajani.
   - Mocking SshHelper and the Script classes, used by Citrix and Libvirt resources respectively.
 2015-07-06 14:58:17 +02:00
Rajani Karuturi
f1a64902cc Merge branch 'PR-REVIEW-335' 
This closes #335
 2015-07-06 11:48:38 +05:30
nitt10prashant
896f6b1e5e CLOUDSTACK-8439:Automation for feature CPU/Memory overcommit 
CLOUDSTACK-8439:Automation for feature CPU/Memory overcommit
This closes #226
 2015-07-06 09:45:26 +05:30
wilderrodrigues
86297e70be CLOUDSTACK-8607 - Make sure the new password replaces the old one in the queue 
- Added log info to show details of the operation
   - Renamed the addPwdToQueue to replaceOldPasswdInQueue
 2015-07-04 11:33:52 +02:00
wilderrodrigues
efa34361df CLOUDSTACK-8607 - Changed update script to return exit code based on the result 
- Changed location of the update_host_passwd script
   - Updated the patch files for XenServer
   - Updated the script path on LibvirtComputing class
   - Removed the hostIP from the LibvirtUpdateHostPasswordCommandWrapper execute() method
 2015-07-03 14:29:57 +02:00
Sudhansu
510fc11319 BUG-ID: CLOUDSTACK-8484 - Hosts without tag are not listed while 
listing the hosts for migration for instance with tag
Added marvin test for this issue.
Steps
         1. Create a Compute service offering with the tag.
         2. Create a Guest VM with the compute service offering
            created above.
         3. find hosts to migrate the vm crated above

Validations
         1. Ensure that the offering is created with the
            tag.The listServiceOffering API should list show tag
         2. findHostsForMigration cmd should list both suitable
            and not-suitable hosts
 2015-07-03 17:36:54 +05:30
Koushik Das
5d9f851deb CLOUDSTACK-8603: Random list VM failures at scale (more than 1000 VMs) when VM has resource tags There is no 'removed' field on the resource_tags table. So 'id' based search may return a record or null in case record is deleted. Added a check for null or empty in search resource tags based on 'id'. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #551
 2015-07-03 15:25:11 +05:30
Kishan Kavala
3a19a8916e BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #557
 2015-07-03 15:21:18 +05:30
wilderrodrigues
6c92ccf8d1 CLOUDSTACK-8607 - Refactoring attribute name 
- Refactoring attribute name from shouldUpdateHost to updatePasswdOnHost
   - Fixing ApiConstants class because it had an error in the constant name
 2015-07-03 11:43:56 +02:00
wilderrodrigues
0dd02ce043 CLOUDSTACK-8607 - Adding support to update host passwd on XenServer hypervisors 
- Adding update_host_passwd to VRScripts
   - Add accessor method to host password on CitrixResourceBase
   - Add implementation to CitrixUpdateHostPasswordCommandWrapper
   - Improve testUpdateHostPasswordCommand() unit test on CitrixRequestWrapperTest
   - Add line to patch files on xenserver directory

Concerning the LibVirt change:

   - I forgot to assing the return of the getDefaultHypervisorScriptsDir() method to the hypervisorScriptsDir variable
 2015-07-03 10:24:44 +02:00