gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove a db global in FavoriteTableController

Browse Source 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
This commit is contained in:
Maurício Meneghini Fauth 2023-12-15 00:48:34 -03:00
parent 17ac066804
commit 4a67d88e1d
No known key found for this signature in database
GPG Key ID: 6A16FD38AFC89CC8
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Controllers/Database/Structure/FavoriteTableController.php
View File

@ -87,11 +87,7 @@ final class FavoriteTableController extends AbstractController
$changes = true;
/** @var string $favoriteTableName */
$favoriteTableName = $request->getParam('favorite_table', '');
// TODO: Why is this $GLOBALS['db'] instead of $databaseName
$favoriteTable = new RecentFavoriteTable(
DatabaseName::from($GLOBALS['db']),
TableName::from($favoriteTableName),
);
$favoriteTable = new RecentFavoriteTable($databaseName, TableName::from($favoriteTableName));
$alreadyFavorite = $favoriteInstance->contains($favoriteTable);
if (isset($_REQUEST['remove_favorite'])) {