gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HTML attributes have to be enclosed with double-quotes

Browse Source 
This caused also a problem when the title contains a single-quote
This commit is contained in:
Marc Delisle 2012-04-27 12:54:36 -04:00
parent 623c89fce7
commit 4c768d41c4
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libraries/common.lib.php
View File

@ -3435,17 +3435,17 @@ function PMA_getSupportedDatatypes($html = false, $selected = '')
foreach ($value as $subvalue) {
if ($subvalue == $selected) {
$retval .= sprintf(
"<option selected='selected' title='%s'>%s</option>",
'<option selected="selected" title="%s">%s</option>',
$GLOBALS['PMA_Types']->getTypeDescription($subvalue),
$subvalue
);
} else if ($subvalue === '-') {
$retval .= "<option disabled='disabled'>";
$retval .= '<option disabled="disabled">';
$retval .= $subvalue;
$retval .= "</option>";
$retval .= '</option>';
} else {
$retval .= sprintf(
"<option title='%s'>%s</option>",
'<option title="%s">%s</option>',
$GLOBALS['PMA_Types']->getTypeDescription($subvalue),
$subvalue
);
@ -3455,13 +3455,13 @@ function PMA_getSupportedDatatypes($html = false, $selected = '')
} else {
if ($selected == $value) {
$retval .= sprintf(
"<option selected='selected' title='%s'>%s</option>",
'<option selected="selected" title="%s">%s</option>',
$GLOBALS['PMA_Types']->getTypeDescription($value),
$value
);
} else {
$retval .= sprintf(
"<option title='%s'>%s</option>",
'<option title="%s">%s</option>',
$GLOBALS['PMA_Types']->getTypeDescription($value),
$value
);