RedundantCastGivenDocblockType

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

libraries/classes/Display/Results.php

@@ -871,9 +871,9 @@ class Results
                 $displayParams['desc'][] = '    <th '
                     . 'class="draggable'
                     . ($conditionField ? ' condition"' : '')
-                    . '" data-column="' . htmlspecialchars((string) $fieldsMeta[$i]->name)
+                    . '" data-column="' . htmlspecialchars($fieldsMeta[$i]->name)
                     . '">        '
-                    . htmlspecialchars((string) $fieldsMeta[$i]->name)
+                    . htmlspecialchars($fieldsMeta[$i]->name)
                     . $comments . '    </th>';
             }
 

phpstan-baseline.neon

@@ -2895,11 +2895,6 @@ parameters:
 			count: 2
 			path: libraries/classes/Display/Results.php
 
-		-
-			message: "#^Casting to string something that's already string\\.$#"
-			count: 2
-			path: libraries/classes/Display/Results.php
-
 		-
 			message: "#^Method PhpMyAdmin\\\\Display\\\\Results\\:\\:getCommentForRow\\(\\) has parameter \\$commentsMap with no value type specified in iterable type array\\.$#"
 			count: 1

psalm-baseline.xml

@@ -6463,10 +6463,6 @@
       <code>(int) $GLOBALS['cfg']['LimitChars']</code>
       <code>(int) $GLOBALS['cfg']['LimitChars']</code>
     </RedundantCast>
-    <RedundantCastGivenDocblockType occurrences="2">
-      <code>(string) $fieldsMeta[$i]-&gt;name</code>
-      <code>(string) $fieldsMeta[$i]-&gt;name</code>
-    </RedundantCastGivenDocblockType>
     <RedundantCondition occurrences="2">
       <code>empty($statementInfo-&gt;statement-&gt;from)</code>
       <code>isset($sessionMaxRows)</code>