Commit Graph

124811 Commits

Author SHA1 Message Date
William Desportes
110b609e92
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-03 20:35:10 +01:00
William Desportes
296e6b62ce
Update phpstan and psalm baseline
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-03 20:29:19 +01:00
William Desportes
5e1ff822f3
Merge #17860 - Fix #17793 - insert record - fix null not selected if nullable UUID & insert error
Pull-request: #17860
Fixes: #17793

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-03 20:24:12 +01:00
Maurício Meneghini Fauth
efbd8d835a
Merge pull request #17855 from kamil-tekiela/globals-DBI
Reduce usage of $GLOBALS['dbi']
2022-11-03 15:48:20 -03:00
Mo Sureerat
a36ee101e7 [ISSUE-17793] Remove unreachable condition
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-11-04 01:23:33 +07:00
Mo Sureerat
8929288efd [ISSUE-17793] Add more test for coverage
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-11-04 00:33:41 +07:00
Mo Sureerat
250be6adbc [ISSUE-17793] Fix static analysis warning
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-11-03 22:57:07 +07:00
Mo Sureerat
afd568e889 [ISSUE-17793] Revert previous change + Fix default selection of uuid in alter table
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-11-03 05:11:19 +07:00
Mo Sureerat
7615c7e780 [ISSUE-17793] Insert record - fix null not selected if nullable UUID + insert error
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-11-03 03:01:38 +07:00
Kamil Tekiela
a5a81d159f Send DBI to Data using DI
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
15915a45e0 Send DBI to SqlQueryForm using DI
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
828a5f7137 Update Privileges.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
e62241b079 Update Routines.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
98902c87a8 Update Designer.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
8caf17b0ac SystemDatabase
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-01 16:33:03 +00:00
Maurício Meneghini Fauth
bfe59e6e41
Merge pull request #17837 from MauricioFauth/core-fatal-error-removal
Replace `PhpMyAdmin\Core::fatalError()` method calls
2022-10-31 22:37:03 -03:00
Maurício Meneghini Fauth
c88152cf59
Use more specific exceptions for some errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 22:32:12 -03:00
Maurício Meneghini Fauth
de03f00cae
Remove Core::fatalError method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 22:18:47 -03:00
Maurício Meneghini Fauth
640ecc5c08
Remove $message_args param from Core::fatalError()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 21:49:54 -03:00
Maurício Meneghini Fauth
66e2650e06
Replace Core::fatalError() calls in controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
103968f352
Replace fatalError() with exception in Core::warnMissingExtension()
Also moves some other calls to Core::warnMissingExtension() to the
Common::checkRequiredPhpExtensions() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
3121dae621
Replace Core::fatalError() calls from the Common class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:54 -03:00
Maurício Meneghini Fauth
62530b48a5
Replace Core::fatalError with an exception in Export::processExportSchema()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:51 -03:00
Maurício Meneghini Fauth
128211ccc9
Remove Core::fatalError call from SchemaExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:24:20 -03:00
Maurício Meneghini Fauth
25fe766a26
Fix tests marked as incomplete
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:22:54 -03:00
William Desportes
bff74dc588
Fix #17705 - CodeMirror query box has overflow preventing click
Fixes: #17705

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-01 00:21:30 +01:00
Maurício Meneghini Fauth
91403fc519
Update Psalm baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 19:59:54 -03:00
pistej
1d619c11ad
Ref #17769 - ServerRequest Object instead superglobals - DB controllers (#17854)
* Use ServerRequest Object instead superglobals - DB controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

* fixed phpstan

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-31 19:51:28 -03:00
Maurício Meneghini Fauth
40c6614c3a
Merge pull request #17853 from pistej/globals-to-req-db-structure-1
Ref #17769 - Use ServerRequest Object instead superglobals - DB/structure controllers
2022-10-31 19:50:04 -03:00
William Desportes
10b2cbfd0a
Add a ChangeLog entry for #17705
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 23:44:54 +01:00
William Desportes
6dd05c51ad
Fix #17705 - Inline SQL query edit FK checkbox preventing submit buttons from working
Fixes: #17705

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 23:43:40 +01:00
William Desportes
75a5fbf6c0
Translated using Weblate (Macedonian)
Currently translated at 18.7% (642 of 3431 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:44:53 +01:00
William Desportes
d98569bf28
Translated using Weblate (Macedonian)
Currently translated at 18.7% (642 of 3418 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:40:59 +01:00
William Desportes
79d447be16
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:32:58 +01:00
William Desportes
2eab183f5a
Merge branch 'Weblate/QA_5_2' into QA_5_2
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:25:53 +01:00
William Desportes
472391794f
Add a ChangeLog entry for #16042
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:24:50 +01:00
William Desportes
dca4119c1f
Merge #17844 - Fix #16042 - Gzip encoding in Firefox - Exported gzip file of database has first ~73 kB uncompressed and rest is gzip compressed
Pull-request: #16042
Fixes #17842

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:22:19 +01:00
Jozef Pistej
f089b5ae3d Use ServerRequest Object instead superglobals - DB/structure controllers
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-31 19:05:44 +01:00
Maurício Meneghini Fauth
833b4bc535
Merge pull request #17850 from OliverMensahDev/Using_ServerRequest_Object_In_SQL_Controllers
Ref #17769 - Using Server request object in SQL controllers
2022-10-31 14:31:33 -03:00
Kristijan Fremen Velkovski
897c6c42fa
Translated using Weblate (Macedonian)
Currently translated at 18.7% (642 of 3431 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-10-31 18:03:05 +01:00
Kristijan Fremen Velkovski
ee3cca816a
Translated using Weblate (Macedonian)
Currently translated at 18.7% (642 of 3418 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-10-31 18:01:33 +01:00
Oliver Mensah
21ae746b68 linting and analysing fixes
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-31 15:56:25 +00:00
Maurício Meneghini Fauth
b6fdc9fb80
Merge pull request #17846 from MauricioFauth/node-14
Bump Node version to from 12 to 14
2022-10-31 12:06:34 -03:00
Maurício Meneghini Fauth
fc31d21338
Bump Node version to from 12 to 14
- Removes the phpMyAdmin 5.1 snapshot build

See:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 12:05:49 -03:00
William Desportes
e51e3fa71f
Fix typo in test data
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 14:54:53 +01:00
Oliver Mensah
0bf2d2ea69 Using Server request onject in SQL controllers
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-31 13:21:23 +00:00
William Desportes
455016557e
Ref #17028 - Add test cases for queries
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 13:38:07 +01:00
William Desportes
32de166f03
Fix #17812 - Add missing close button style on pick from central column modal on table structure
Fixes: #17812

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 12:42:37 +01:00
William Desportes
b033099d1e
Add a ChangeLog entry for #17842
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 11:00:47 +01:00
William Desportes
00452af4dc
Merge #17845 - Fix #17842 - Change js.cookie.js to js.cookie.min.js
Pull-request: #17845
Fixes #17842
Fixes: #17847

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 10:59:14 +01:00