Commit Graph

115489 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
14da395f75
Merge pull request #15241 from Tithugues/feature/change-user-preferences-include-as-a-class
Change "user_preferences.inc.php" file as a class
2019-05-05 08:17:48 -03:00
Maurício Meneghini Fauth
8112dc8bc7 Add ChangeLog entry for #15072
Fixes #15072
Closes #15114
Closes #15073

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 22:58:42 -03:00
Anton Mokrousov
1bf8123b88 Issue #15072 fix (added button)
Added button "Close" at the bottom of "Monitor instructions" window to make it similar to other dialog windows

Signed-off-by: Anton Mokrousov <settingx@mail.ru>
2019-05-04 22:54:30 -03:00
Maurício Meneghini Fauth
3ec6d02578
Merge pull request #15244 from Tithugues/feature/minor-improvements-on-message-class
Minor improvements in Message class
2019-05-04 19:00:16 -03:00
Maurício Meneghini Fauth
0ccae90725
Merge pull request #15243 from Tithugues/feature/message-in-message-is-self
Message in Message class is self
2019-05-04 18:25:26 -03:00
Hugues Peccatte
d8f9695830 Minor improvements in Message class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:26:26 +02:00
Hugues Peccatte
fb78fa6fc0 Message in Message class is self
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:09:11 +02:00
Maurício Meneghini Fauth
8261661258 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 17:02:46 -03:00
Hugues Peccatte
f5b475fdbd Add UserPreferencesTest
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:02:10 +02:00
Hugues Peccatte
fdfff01083 Change "user_preferences.inc.php" file as a class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:02:10 +02:00
Maurício Meneghini Fauth
9de453fa31 Add ChangeLog entry for #14934
Fixed all fields readonly on Edit/Insert screens

- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 17:00:48 -03:00
Maurício Meneghini Fauth
b30555f887
Merge pull request #14993 from bahl24/fix-#14934
removed readonly cond as its redundant
2019-05-04 16:57:15 -03:00
William Desportes
175133d47b
Merge branch 'QA_4_8'
Closes: #15158
Signed-off-by: Agha Saad Fraz agha.saad04@gmail.com
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 20:31:02 +02:00
William Desportes
20227b058d
Add ChangeLog entry for #15157
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 20:28:33 +02:00
William Desportes
97ab2953a9
Fixes #15157 - 'Settings' not marked as active when browsing 2FA settings
Fixes: #15157
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 20:27:35 +02:00
Maurício Meneghini Fauth
ce22214f87 Add ChangeLog entry for #14927
Show InnoDB table overhead (free space)

Closes #14970
Closes #14927

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 14:50:51 -03:00
Nitish Bahl
8d875747c7 added optimize for innodb engine
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 14:49:07 -03:00
Maurício Meneghini Fauth
eeb0034848 Fix ESLint error
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 14:27:43 -03:00
William Desportes
62ad886718
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 18:08:06 +02:00
William Desportes
14ddb9a430
Add ChangeLog entry for #15240 #15043 and #15037
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 16:44:28 +02:00
William Desportes
191a81c9b6
Fix #15037 - Unexpected behavior of reset button
Fixes: #15037
Pull-request: #15045
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 16:40:55 +02:00
William Desportes
8e20d8cf25
Fix #15043 - Multiple errors printing on Settings page
Fixes: #15043
Pull-request: #15054
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 16:34:31 +02:00
William Desportes
6cc7b0f170
Fix #15240 - Apply a Settings form with errors shows a JSON response after using return back
Fixes: #15240
Fixes: 'Warning - htmlspecialchars() expects parameter 1 to be string, array given'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 16:30:50 +02:00
William Desportes
2ec96f829c
Use [] instead of array()
See: b851f9d1fc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:43:02 +02:00
William Desportes
b851f9d1fc
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:41:45 +02:00
William Desportes
67c647eb95
Add ChangeLog entry for #14301
Duplicate: #14699
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:37:25 +02:00
William Desportes
821dce6c80
Fix #14301 - Javascript error when editing a JSON data type column
Fixes: #14699
Fixes: #14301
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:34:30 +02:00
William Desportes
c3ed3852bc
Add ChangeLog entry for #15239
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 13:39:12 +02:00
William Desportes
69e7e59d9b
Fix #15239 - TypeError - Cannot read property 'textContent' of undefined
Fixes: #15239
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 13:35:36 +02:00
William Desportes
42f690455c
Add ChangeLog entry for #13726
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 11:20:47 +02:00
William Desportes
3027f0ef49
Fix #13726 - Can not copy user on Percona Server 5.7 (password copy)
Fixes: #13726
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 11:03:39 +02:00
William Desportes
1f0e34ad07
Add ; at the end of SET old_passwords
Why ? : because all other queries have ; at the end.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 09:54:42 +02:00
William Desportes
49874c4e28
Fix #13726 - Can not copy user on Percona Server 5.7
Fixes: #13726
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 09:53:57 +02:00
Nitish Bahl
6a43cccf20 Add title for group in navigation bar
Closes: #14977

Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-03 21:39:18 -03:00
Maurício Meneghini Fauth
a52c35f444
Merge pull request #14965 from bahl24/fix#14958
Modified rule for InnoDB log size warning in libraries/advisory_rules.txt
2019-05-03 12:57:01 -03:00
William Desportes
bb66711c6b
Merge branch 'QA_4_8'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-02 21:00:00 +02:00
William Desportes
8f7a917f11
Fix #15237 - [UI] Alignment on login form since merge or #15178
Fixes: #15237
Introduced-by-pull-request: #15178
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-02 20:49:48 +02:00
Allan Nordhøy
dbbe08ffd6
Translated using Weblate (Norwegian Bokmål)
Currently translated at 59.8% (1985 of 3321 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/nb_NO/
Signed-off-by: Allan Nordhøy <epost@anotheragency.no>
2019-05-02 20:49:08 +02:00
Allan Nordhøy
5aa5d463cd
Translated using Weblate (Norwegian Bokmål)
Currently translated at 60.5% (1997 of 3300 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/nb_NO/
Signed-off-by: Allan Nordhøy <epost@anotheragency.no>
2019-05-02 20:49:05 +02:00
William Desportes
c0d56fa54c
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-02 12:16:45 +02:00
William Desportes
d6180da08c
Add ChangeLog entry for #15238
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-02 12:09:33 +02:00
William Desportes
d70d9ecef1
Fix #15238 - phpMyAdmin 4.8.5 doesn't show privileges of procedures
Fixes: #15238
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-02 12:07:50 +02:00
William Desportes
c94aec8695
Fix coding standard warning and removed typehint
Fix 'Usage of ELSE IF is discouraged; use ELSEIF'

Removed typehint because it creates an exception because sending functions return mixed and not string
You can see this was expected on error_report.php 'if ($server_response === false) {'

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:54:13 +02:00
William Desportes
0bdf3486f3
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:34:05 +02:00
William Desportes
07389d12aa
Fixed error reporting (current web page url, JS file name sanitization)
- Added tests on master branch
- Added support for js/*.js files
- Added support for slashes and dots in file paths
- Added back support for 'url' (the current webpage)

All js files where reported as 'index.php' now they are reported as their real name

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:31:11 +02:00
William Desportes
a0d091e1f8
Add test for sanitizeUrl and improve testGetForm with real data
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:19:25 +02:00
Maurício Meneghini Fauth
defd6761ba Add ChangeLog entry for #14890
Display column details in navigation bar

- Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 15:20:55 -03:00
Saurabh Srivastava
b2bfebd709 Add icon and details only to column view in navigation tree (#14910)
Fixes #14890

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-05-01 15:15:49 -03:00
Maurício Meneghini Fauth
f66841d8ef Fix coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 14:47:27 -03:00
William Desportes
fbd89fb882
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 17:53:24 +02:00