Kamil Tekiela
32d93281bb
Make alias merging cleaner
...
No useless globals, no overwriting of the same value. The values seem to always be string|null so let's check explicitly for that.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
1e7997b761
Set property type to string
...
It must be string as it's used only in string context.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
53b832211c
Make the condition clearer
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
fd5c96e250
This should only check for empty string
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
2d3c4bf749
Minor code simplifications
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
8d8eced452
Remove redundant empty()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:37:30 +01:00
Maurício Meneghini Fauth
e641c70110
Refactor the NodeColumn::getTruncateValue method
...
Removes the unnecessary switch construct.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:29:09 -03:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:41:31 -03:00
Maurício Meneghini Fauth
fd4cedd4f9
Merge pull request #17802 from kamil-tekiela/indent2
...
Fix indentation again
2022-10-16 12:01:05 -03:00
phpMyAdmin bot
335ba2e1b1
Update po files
...
[ci skip]
Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2022-10-16 00:30:21 +00:00
Kamil Tekiela
1650818966
Fix indentation again
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-15 23:20:38 +01:00
Maurício Meneghini Fauth
d01ec6b0b9
Merge pull request #17776 from kamil-tekiela/Fix-PHPStan-issues
...
Fix PHPStan issues
2022-10-15 16:05:50 -03:00
Maurício Meneghini Fauth
f3e31dfdd1
Merge branch 'pokemaobr-push'
...
Closes https://github.com/phpmyadmin/phpmyadmin/pull/17791
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:57:29 -03:00
Rodrigo Pokemaobr
0bd4711eb5
Changing parameters to Parser
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:52:12 -03:00
Maurício Meneghini Fauth
d6c3bc7204
Add basic test for Util::getDbInfo method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 20:28:20 -03:00
Kamil Tekiela
594454eff2
Replace for loop with foreach
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Kamil Tekiela
3baa9b0fde
NonInvariantDocblockPropertyType
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Kamil Tekiela
aeefbf8f3e
Voidify methods with no side effects
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Kamil Tekiela
af9d68a58b
Casting to int something that's already int
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
William Desportes
c92621d023
Merge #17788 - Ref #12262 - Remove inline styles
...
Pull-request: #17788
Ref: #12262
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-14 21:24:12 +02:00
William Desportes
12c94e9b70
Merge remote-tracking branch 'origin/master'
2022-10-14 21:11:16 +02:00
William Desportes
f74c9a21fe
Fix InsertEditTest after pull-request #17767
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-14 21:00:20 +02:00
William Desportes
578c001a03
Update phpstan and psalm baselines
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-14 20:56:06 +02:00
William Desportes
007915bc0a
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-14 20:49:18 +02:00
Kamil Tekiela
dcdbcc019b
Fix method casing
...
Ref: https://github.com/tecnickcom/TCPDF/pull/462
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:44:26 +02:00
Maurício Meneghini Fauth
4bda7899ab
Fix coding standard issues after #17794 merge
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 08:44:52 -03:00
Luca Perna
40adf927c5
Move superglobals access to controllers ( #17794 )
...
Related to #16276
Signed-off-by: Luca Perna <luca@perna.rocks>
2022-10-14 08:34:42 -03:00
Arpit-Gulgulia
6ab77c26e3
Fix:12262 Remove inline styles Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>
...
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
2022-10-14 08:23:06 +00:00
William Desportes
09259eb1a1
Merge #17775 - Fix #17248 - search UUID data type error
...
Pull-request: #17775
Fixes : #17428
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:57:41 +02:00
William Desportes
fbdca09dd0
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:54:04 +02:00
William Desportes
e76f0d3a61
Add a ChangeLog entry for #17656
...
Pull-request: #17741
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:49:49 +02:00
William Desportes
1bce6dcb9b
Merge #17741 - Fix #17656 - Replace/Change/Set table prefix is not working
...
Pull-request: #17741
Fixes : #17656
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:48:29 +02:00
William Desportes
db3b8e0a0e
Merge #17789 - Ref #17769 - Request superglobals in controllers should be replaced with ServerRequest object
...
Pull-request: #17789
Ref: #17769
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:41:51 +02:00
William Desportes
d82b43c5ff
Fixup testGetMySQLDocuURL after changing setVersion() in DBI
...
and fix a phpc issue
See: cac09436c9
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:38:12 +02:00
William Desportes
3c0f662ea6
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:32:16 +02:00
William Desportes
2d3bfe3fb4
Fix casing of isMariaDb on DatabaseInterfaceTest class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:30:55 +02:00
William Desportes
fd13e506d0
Fixup tests and DBI after changing setVersion() in DBI
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
See: cac09436c9
2022-10-13 20:28:32 +02:00
William Desportes
6da193304f
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:13:48 +02:00
William Desportes
eec023abe1
Merge #17780 - Fix #17773 - demo footer links should be clickable
...
Pull-request: #17780
Fixes : #17773
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 19:59:19 +02:00
Arpit-Gulgulia
4302745a74
Fix:#17769 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>
...
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
2022-10-13 17:36:20 +00:00
Arpit-Gulgulia
dc825e0464
Fix:#17773 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>
...
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
2022-10-13 17:15:09 +00:00
Michael Steininger
24066609b7
move bulkActionModal out of template because of failing tests
...
Signed-off-by: Michael Steininger <michael.steininger@world4you.com>
2022-10-13 14:48:28 +02:00
Arpit-Gulgulia
77b7accb89
Fix:#17773 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>
...
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
2022-10-13 08:54:50 +00:00
Maurício Meneghini Fauth
ca5d7602e5
Fix failing ExportTest on PHP 8.1
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 21:14:50 -03:00
Maurício Meneghini Fauth
8da8d3f8c8
Add types for Config\FormDisplay::save() parameters
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 19:19:36 -03:00
Mo Sureerat
8d3dc6c3f1
Add test for Search UUID
...
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-13 04:38:12 +07:00
Maurício Meneghini Fauth
46fdea0d0e
Remove unneeded writing to $_POST in Database\Structure controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 18:07:10 -03:00
Mo Sureerat
582476e5a5
Update operator options for UUID
...
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-13 03:39:51 +07:00