Commit Graph

125022 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
363a353ea7
Merge pull request #17919 from MauricioFauth/js-split-chunks
Create a `shared.js` file for common JS dependencies
2022-11-24 21:03:23 -03:00
Maurício Meneghini Fauth
b2971d618f
Import the AJAX object where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 15:21:18 -03:00
Maurício Meneghini Fauth
3ce84326f2
Import the Functions object where possible
Instead of using from the Window global object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:43:25 -03:00
Maurício Meneghini Fauth
6f54621b41
Create a shared.js file for common JS dependencies
Instead of using the Webpack's dependOn setting, uses the splitChunks
setting to automatically generate the shared.js file.

As the contents of these shared dependencies are being moved to the
shared.js file, the generated file for each dependency is now empty.

Is probably safe to not generate them, but some adjustments are needed
for that first. For example, the AJAX's onload and teardown functions
expects that some of these files exists.

For now, only dependencies that are loaded for all pages should be added
in this shared.js file.

This will facilitate the refactoring of the JS files, but the trade off,
at least for now, is that will be a single large file instead of a few
medium ones.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:43:24 -03:00
Maurício Meneghini Fauth
80b5358bc0
Add an unit test for Header::addDefaultScripts()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:34:10 -03:00
Domen
7bef320ca0
Translated using Weblate (Slovenian)
Currently translated at 100.0% (3434 of 3434 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/sl/
Signed-off-by: Domen <mitenem@outlook.com>
2022-11-23 23:48:42 +01:00
Kristijan Fremen Velkovski
2f9686c0e5
Translated using Weblate (Macedonian)
Currently translated at 21.9% (754 of 3435 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-11-23 23:48:41 +01:00
Maurício Meneghini Fauth
aabdbe7357
Update PHPStan and Psalm baselines
- Fix coding standard error
- Remove strict option from composer validate because the sql-parser is
  pointing to a commit-ref

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-23 17:28:31 -03:00
ru-asdx
f883d9021f
Replace POST vars with ServerRequest (#17903)
* Replace POST vars with ServerRequest in UserPasswordController
* Replace POST vars with ServerRequest in Normalization

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2022-11-23 17:14:14 -03:00
Maurício Meneghini Fauth
df23516145
Reorder JS scripts loading in Header class
First load vendor scripts, then load the Messages, then the other
scripts.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-23 15:57:06 -03:00
Maurício Meneghini Fauth
1dcfaa0358
Assign AJAX to window object after the its declaration
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-23 14:58:06 -03:00
Maurício Meneghini Fauth
d5fed1e989
Merge pull request #17918 from MauricioFauth/import-common-js
Import CommonParams and CommonActions as modules
2022-11-23 12:47:45 -03:00
Maurício Meneghini Fauth
8c525ed026
Import CommonParams and CommonActions as modules
Removes CommonParams and CommonActions from the Window object where
possible.

Uses Webpack's dependOn setting to prevent code duplication.

- https://webpack.js.org/guides/code-splitting/#prevent-duplication

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-22 22:07:41 -03:00
Maurício Meneghini Fauth
f421836ebe
Remove inline JS in change_password.twig template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-22 17:40:05 -03:00
Maurício Meneghini Fauth
45f3552fb3
Remove @implements EventListener JS annotation
Adds a link to the MDN documentation page instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-22 15:52:57 -03:00
Maurício Meneghini Fauth
3bf23620ae
Refactor Functions.escapeHtml() JS function
Uses native function to escape instead of custom one.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-22 00:59:43 -03:00
Kristijan Fremen Velkovski
e3bc449f94
Translated using Weblate (Macedonian)
Currently translated at 21.8% (751 of 3435 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-11-21 21:48:13 +01:00
William Desportes
1fb05ae4f8
Translated using Weblate (French)
Currently translated at 100.0% (3434 of 3434 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/fr/
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-21 21:48:12 +01:00
Oğuz Ersen
3b9f7bd444
Translated using Weblate (Turkish)
Currently translated at 100.0% (3434 of 3434 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/tr/
Signed-off-by: Oğuz Ersen <oguz@ersen.moe>
2022-11-21 21:48:11 +01:00
Maurício Meneghini Fauth
5ab7640bc7
Remove force_file_* global vars and param
Uses a HTML data attribute instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 17:30:55 -03:00
Maurício Meneghini Fauth
2ea4e59b48
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 16:37:43 -03:00
Maurício Meneghini Fauth
15308d7e27
Merge pull request #17915 from MauricioFauth/fix-config-exception
Catch exceptions/errors in the config file
2022-11-21 16:35:57 -03:00
Maurício Meneghini Fauth
ba81cdabce
Catch exceptions/errors in the config file
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17911

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 15:57:03 -03:00
Maurício Meneghini Fauth
e194eb3961
Improve type DatabaseInterface's $link params
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 14:50:52 -03:00
Maurício Meneghini Fauth
62891227f7
Update PHPStan/Psalm baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 13:54:45 -03:00
Maurício Meneghini Fauth
d2809ca096
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 13:50:30 -03:00
William Desportes
883226c1f7
Ref #17478 - Fix mistake in PHP operators
Ref: 630f9bf00e
Thank you @MoonE !

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-21 16:37:44 +01:00
William Desportes
630f9bf00e
Ref #17478 - Fix PHP Undefined array key "auth_type" when server does not start at 0
```
Internal error in ./libraries/classes/Controllers/HomeController.php#235
 ErrorException: Undefined array key "auth_type"
```

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 23:02:50 +01:00
William Desportes
182cb205a7
Fix coding standard mistakes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 21:55:52 +01:00
William Desportes
420485a41b
Fix tests after e28bc2d8f6
Ref: e28bc2d8f6

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:29:07 +01:00
William Desportes
655c5e1541
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:16:02 +01:00
William Desportes
7c8a3aee3a
Add a ChangeLog entries for #17446
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:12:03 +01:00
William Desportes
e28bc2d8f6
Fix #17446 - Missing option for STORED virtual column and lower the check to MySQL>=5.7.6. Nothing is supported on 5.7.5.
Fixes: #17446

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:08:35 +01:00
William Desportes
132b01d3fc
Add a ChangeLog entry for #17340
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 17:44:43 +01:00
William Desportes
bad8f2f913
Fix #17340 - New Table -> VIRTUAL attribute is lost when adding new column
Fixes: #17340

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 17:44:42 +01:00
William Desportes
151e6247c6
Bump codemirror 5.65.9 to 5.65.10
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 16:49:49 +01:00
William Desportes
156da4e3d2
Add a ChangeLog entry for c57fbe1924
Ref: c57fbe1924

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 16:42:23 +01:00
William Desportes
c57fbe1924
Fix broken tree line when the DB is expanded
Ref: 0dc9394b40

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 16:41:10 +01:00
William Desportes
e0e740f108
Add a ChangeLog entry for #17703
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 16:10:35 +01:00
William Desportes
33859e934b
Merge #17885 - Fix #17703 - Datepicker appears on all fields, not just date
Fixes: #17703
Pull-request: #17885

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 16:09:33 +01:00
vimal K
2abba13b0d
Fix #17703 - Multiple Datepicker issues resolved
Fixes: #17703

Signed-off-by: Vimal K <vimalinfo10@gmail.com>
2022-11-20 16:06:06 +01:00
William Desportes
099fa33530
Update FAQ 1.44 for 5.3
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 15:33:34 +01:00
William Desportes
1df41153e4
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 15:12:54 +01:00
William Desportes
c411d0fa4d
Update baselines
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 15:07:21 +01:00
William Desportes
f3c4ef9bfa
Update broken link on config.default.php and fix a typo
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 15:04:01 +01:00
William Desportes
45853b69b7
Fix #17902 - truncate "title" attribute of foreign keys
BrowseForeigners::getDescriptionAndTitle() uses the same method

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 14:18:53 +01:00
William Desportes
d88ef680da
Add a ChangeLog entry for 87e44947a6
Ref: 87e44947a6

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 11:29:59 +01:00
William Desportes
87e44947a6
Fix big performance issue making CPU 100% when scrolling the textarea of an export of #17902 data
Data can be found on #17902 (https://github.com/phpmyadmin/phpmyadmin/issues/17902#issuecomment-1321082358)

I changed the events to not bind all the document but only the root node they needed.
Scrolling is way better now

I used chrome coverage mode to ensure the code is still called and tested it.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 11:15:21 +01:00
Kristijan Fremen Velkovski
5723fe99f0
Translated using Weblate (Macedonian)
Currently translated at 21.8% (746 of 3418 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-11-20 05:54:43 +01:00
Hosted Weblate
49e4cc1fd7
Merge branch 'origin/master' into Weblate.
[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/
2022-11-20 01:23:39 +01:00