Commit Graph

114028 Commits

Author SHA1 Message Date
William Desportes
4f5a171826
Update po files
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:28:00 +02:00
William Desportes
8590357612
Fix a bug introduced by a23f2ba51a
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:25:02 +02:00
William Desportes
6d0f3083ca
Fix display field can return a boolean
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:15:21 +02:00
William Desportes
9c5195d438
Fix Unit tests broken by a23f2ba51a
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 01:07:24 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
William Desportes
5940d11e72
Merge #15448 - Fix many bugs when adding new tables to designer
Fixes: #15446
Pull-request: #15448
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-22 14:05:32 +02:00
William Desportes
9518e0d053
Merge #15452 - Display an error when trying to import in designer a table that's already imported
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-22 14:03:14 +02:00
Hugues Peccatte
58e3b71ae2 Update js/messages.php
add context for translators

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-22 10:07:15 +02:00
Hugues Peccatte
5c7eb38a81 Fix url encoding of table names
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-22 10:06:32 +02:00
William Desportes
4f832662c5
Merge #15451 - Designer export fails when a table name contains special chars
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-22 09:43:53 +02:00
Hugues Peccatte
b37b479da0 Display an error when trying to import in designer a table that's already imported
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 23:05:15 +02:00
Hugues Peccatte
67c94b17fd Designer export fails when a table name contains special chars
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 21:32:32 +02:00
William Desportes
3aa7a35dae
#15363 - substr can return false on tbl_definition_form
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-21 19:10:37 +02:00
Hugues Peccatte
fce235c7bc Remove variable that is unused anymore
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 08:27:32 +02:00
Hugues Peccatte
b13c05edfa Toggling global collapse of tables now relies on tables items instead of j_tabs
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:47:06 +02:00
Hugues Peccatte
ac340e29b6 Add missing overlay on added tables
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:20:13 +02:00
Hugues Peccatte
de57539fb7 Build "tables list" in JS
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:01:17 +02:00
Hugues Peccatte
c23bec2dee Be sure to use local variable
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 22:34:06 +02:00
Hugues Peccatte
14ba5a1b24 Retrieve DB instead of relying on current one
When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 22:23:35 +02:00
Hugues Peccatte
49dae2de12 Fix wrong id on table
When a table is added on the fly, the id was always built based on the first table of the targetted DB, not based on the selected table.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 20:57:20 +02:00
Hugues Peccatte
da9d907ad1 Fix #15446 Tables added from other databases are not collapsing in the designer section
The events to link all buttons to collapse tables were initialized at page loading. But when a new table was added, the event wasn't declared for this one.
With this commit, the event is now also declared on table addition.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 20:46:20 +02:00
William Desportes
10745bb392
#15363 - substr can return false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 16:43:31 +02:00
William Desportes
3b116de260
Fix tests for "NULL wrongly checked on field change"
Pull-request: #15445
Introduced-by: bef259c510

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 14:42:43 +02:00
William Desportes
fff26ed939
Add ChangeLog entries for #15363, bef259c5, #15388, #14291
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:29:22 +02:00
William Desportes
62a17fea45
Fix #14291 - Incorrect linkage from one table's value to another table
Fixes: #14291
Pull-request: #15414

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:24:43 +02:00
William Desportes
c4640c64b3
Fix #15388 - Allow rollback if empty statement
Fixes: #15388
Pull-request: #15408

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:16:24 +02:00
William Desportes
bef259c510
Fix NULL wrongly checked on field change
Pull-request: #15445

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:04:42 +02:00
William Desportes
6f14206810
Fix #15363 - Remove unexpected quotes on text fields
Fixes: #15363
Pull-request: #15409

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:03:27 +02:00
Hugues Peccatte
98a7479174 Fix NULL wrongly checked on field change
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-19 18:00:18 +02:00
William Desportes
a0bf9b50d1
Fix PHP 7.4 deprecation: accessing offset on null/bool
Pull-request: #15405
Ref: #15412
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 23:38:29 +02:00
William Desportes
b4d3b07476
Fix #15363 - Remove unexpected quotes on text fields
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 22:13:17 +02:00
Hugues Peccatte
c36a2cef02
Fix #15363 Remove unexpected quotes on text fields
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-15 20:53:36 +02:00
William Desportes
24fd209020
Add ChangeLog entry for #14950
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 20:51:38 +02:00
William Desportes
cfa1be5916
Fix #14950 - Left database overview "add column" triggers error
Fixes: #14950
Fixes: #15430
Pull-request: #15431

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 20:42:52 +02:00
William Desportes
27ead96225
Add ChangeLog entry for #15202
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 20:31:26 +02:00
William Desportes
6b9ccd675c
Fix #15202 - escaped correctly password
Fixes: #15202
Pull-request: #15428

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 20:29:58 +02:00
Kartik Kathuria
fd1bcc2415
Fix #15202 - escaped correctly password
Fixes: #15202
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-08-15 20:27:58 +02:00
William Desportes
61ea8b799a
Add ChangeLog entry for #15127
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 19:12:23 +02:00
William Desportes
61691091e5
Fix #15127 - fixed the white square in floating menubar
Pull-request: #15429
Fixes: #15127
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 19:06:08 +02:00
Shen Chen
e9ca69dcb7 [Bugfix] update if statement to make sure the field is not empty.
Signed-off-by: Shen Chen <schen89@live.com>
2019-08-13 23:59:32 -04:00
Rahul Gurung
2eaf9a516b fixed whitesquare in floating menubar
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-13 11:35:51 +05:30
William Desportes
7367753d0c
[structure] Remove html escaping in insert col after col <select>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-11 22:44:29 +02:00
William Desportes
973c40609b
Add ChangeLog entry for #15427
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-11 18:43:33 +02:00
William Desportes
71a032de33
Fix #15427 - "FilterLanguages" option does not work
Pull-request: #15426
Fixes: #15427
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-11 18:42:40 +02:00
Vadim Chernyshev
79c0c8a8f3 Fixed configuration for FilterLanguages
Signed-off-by: Vadim Chernyshev <tryfunc@gmail.com>
2019-08-11 19:13:54 +03:00
ssantos
c8478f5ead
Translated using Weblate (Portuguese)
Currently translated at 100.0% (3303 of 3303 strings)

[CI skip]

Translation: phpMyAdmin/4.9
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-9/pt/
Signed-off-by: ssantos <ssantos@web.de>
2019-08-09 20:22:26 +02:00
ssantos
536447a4cc
Translated using Weblate (German)
Currently translated at 100.0% (3303 of 3303 strings)

[CI skip]

Translation: phpMyAdmin/4.9
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-9/de/
Signed-off-by: ssantos <ssantos@web.de>
2019-08-09 20:22:22 +02:00
Ezéchiel Amen AGBLA
28c07ebcda
Translated using Weblate (French)
Currently translated at 100.0% (3303 of 3303 strings)

[CI skip]

Translation: phpMyAdmin/4.9
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-9/fr/
Signed-off-by: Ezéchiel Amen AGBLA <ezchilamen@gmail.com>
2019-08-04 14:34:37 +02:00
Hugues Peccatte
02225781f2 Add missing PHPDoc for new $displayedData parameter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-02 22:50:01 +02:00
Hugues Peccatte
20735aeff0 Fix #14291 Incorrect linkage from one table's value to another table
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-02 22:50:01 +02:00