Commit Graph

125236 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5708596146
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:52:00 -03:00
Maurício Meneghini Fauth
551c317aee
Merge pull request #17982 from kamil-tekiela/Elvis
Remove usage of elvis operator

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:46:33 -03:00
Maurício Meneghini Fauth
fdf474abf9
Merge pull request #17981 from kamil-tekiela/getTables-investigation
Improve some type inference in various places

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:44:45 -03:00
Maurício Meneghini Fauth
03911b593c
Update Psalm's baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:39:53 -03:00
Maurício Meneghini Fauth
d5f3c91b29
Merge pull request #17979 from kamil-tekiela/Optimize-fetchResult
Microoptimization of fetchResult()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:32:45 -03:00
Kamil Tekiela
f1a0f9d196
Minor refactoring of NavigationTree (#17970)
* Fix boolean expression
* Fix docbloc type
* Remove redundant arguments
* Refactor Node::hasChildren()
* Remove redundant count()
* Make $pos property not null
* Improve condition
* Replace escapeString with quoteString
* Update phpstan-baseline.neon
* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-24 13:25:03 -03:00
Maurício Meneghini Fauth
f4f933df8b
Merge pull request #17968 from kamil-tekiela/Remove-dependencies
Remove unused class dependencies

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:09:00 -03:00
Kamil Tekiela
2b2a758d1a Replace escapeString with quoteString
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-24 13:04:10 -03:00
Kamil Tekiela
6264f6f1ea
Various refactorings 2 (#17965)
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-24 12:54:23 -03:00
William Desportes
9c85aa6dc1
Improve tests for all supported PSR-7 implementations
Ref: #17975

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-22 10:17:12 +04:00
William Desportes
f023638693
Add tests for PSR-7 libs to the CI
Ref: #17975

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-22 09:38:14 +04:00
William Desportes
389f7ffb19
Add tests for all supported PSR-7 implementation
Ref: #17975

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-22 09:33:34 +04:00
William Desportes
8ee2afba7e
Merge #17975 - Add support for more PSR-7 packages
Pull-request: #17975

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-22 08:05:17 +04:00
Kamil Tekiela
9a8dc40ae9 Remove usage of elvis operator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-20 19:50:58 +00:00
Kamil Tekiela
70af3e9c1c Remove $GLOBALS['script_display_field'] & $GLOBALS['fullTableNames']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-20 18:55:03 +00:00
Kamil Tekiela
ba110e8638 Remove $GLOBALS['tab_pos']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-20 18:55:03 +00:00
Kamil Tekiela
4b4bd00f37 Simplify fetchResult in Common
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-20 18:55:03 +00:00
Kamil Tekiela
2bda275524 Add better type inference
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-20 18:55:03 +00:00
Kamil Tekiela
bc6fb312db Improve type inference in getTables()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-19 23:29:25 +00:00
Kamil Tekiela
fd52b85eed Microoptimization of fetchResult()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-19 19:30:13 +00:00
Maurício Meneghini Fauth
4e49c7760a
Add support for more PSR-7 packages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-19 01:40:05 -03:00
phpMyAdmin bot
e5e070c814 Update po files
[ci skip]

Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2022-12-18 00:18:18 +00:00
Maurício Meneghini Fauth
c8150fd81f
Update PHPStan baseline
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-17 18:31:43 -03:00
Kamil Tekiela
65ab1608f8 Remove dependency in DatabasesController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-16 20:58:48 +00:00
Kamil Tekiela
6735938f12 Remove dependancy in Table/StructureController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-16 20:58:48 +00:00
Kamil Tekiela
8b0cf8c16c Remove dependancy in Database/StructureController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-16 20:58:47 +00:00
Maurício Meneghini Fauth
13890a947a
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-16 11:53:18 -03:00
Maurício Meneghini Fauth
90f9e708cc
Fix missing icon for collapse all button
Fixes #17967

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-16 11:16:26 -03:00
Maurício Meneghini Fauth
63102c1253
Add unit test for Plugins\TwoFactor\Key::getRegistrations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-15 22:54:33 -03:00
Kamil Tekiela
3ff0dd38d4
Remove invalid usages of htmlspecialchars()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
(cherry picked from commit 59ba203280)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-15 14:00:41 -03:00
Maurício Meneghini Fauth
a5e81ad7d0
Ignore test/test_data/gis directory
Related to 5116b0f0fe.

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-15 13:48:00 -03:00
Maurício Meneghini Fauth
d57b955802
Bump selenium/standalone-chrome docker image to latest v4
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit dc5450d409)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-15 13:46:07 -03:00
Kamil Tekiela
db5db26c60
Refactor Database Search (#17962)
* Refactor Search::getWhereClause()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Refactor Search::getSearchSqls()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix HTML escaping issues in Database search

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Change links to buttons

More semantically correct, does not link to a separate page on middleclick, and looks better.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Refactor Search::getSearchResults()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-15 13:43:29 -03:00
Kamil Tekiela
1e4af77416
Refactor Plugins.php (#17960)
* Remove temporary variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove pass-by-ref

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Refactor getOneOption

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Refactor getOptions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 23:16:27 -03:00
Maurício Meneghini Fauth
08a27b8b7e
Merge pull request #17959 from kamil-tekiela/various-refactorings
Various refactorings
2022-12-14 23:10:11 -03:00
Maurício Meneghini Fauth
ab96edf359
Extract Navigation object dependency from CommonParams
This removes a circular dependency.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-14 20:08:58 -03:00
Maurício Meneghini Fauth
fafa7d289d
Merge pull request #17961 from MauricioFauth/selenium-4
Bump selenium/standalone-chrome docker image to latest v4
2022-12-14 18:26:23 -03:00
Maurício Meneghini Fauth
55e95ccd09
Fix type error when copying tables
Related to 873eb098b9 and
a84cae6c2d.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-14 18:24:11 -03:00
Maurício Meneghini Fauth
dc5450d409
Bump selenium/standalone-chrome docker image to latest v4
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-14 16:22:12 -03:00
Kamil Tekiela
0f1b6ec51d Remove temporary $backend var
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
1bb0e830c0 Remove temporary variables from Table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
0ae0516084 Refactor Table::countRecords()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
e64bbe2926 Remove temporary var $releases
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
ce0ee04406 Remove temporary variables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
59ba203280 Remove invalid usages of htmlspecialchars()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
7cc0fbcf56 Fix nullable arrays that should not be nullable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
f174282442 Remove temporary var $column_names
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
1c51769b32 Simplify for statement into foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
9e795e27a1 Remove temporary variable $cf
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
8d7e3e2229 Simplified switch
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00