gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,236 Commits 12 Branches 481 Tags 2.4 GiB
5708596146
Commit Graph

334 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
fdf474abf9
Merge pull request #17981 from kamil-tekiela/getTables-investigation 
Improve some type inference in various places

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-24 13:44:45 -03:00
Kamil Tekiela
70af3e9c1c Remove $GLOBALS['script_display_field'] & $GLOBALS['fullTableNames'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 18:55:03 +00:00
Kamil Tekiela
ba110e8638 Remove $GLOBALS['tab_pos'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 18:55:03 +00:00
Kamil Tekiela
8b0cf8c16c Remove dependancy in Database/StructureController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-16 20:58:47 +00:00
Kamil Tekiela
47d9ad9b23 Remove always false $_error 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-14 17:17:47 +00:00
Kamil Tekiela
7c1bfec7f5 Removal of globals 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-13 09:43:01 -03:00
Maurício Meneghini Fauth
66f0c2869a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-30 15:34:47 -03:00
William Desportes
ddd512cd8b
Fix #15887 - Drop table errors ignored 
Fixes: #15887

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-26 00:22:54 +01:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-13 21:08:00 -03:00
Maurício Meneghini Fauth
7b723d6318
Refactor SavedSearches class to use Exceptions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 00:22:37 -03:00
Maurício Meneghini Fauth
77f9ebb61a
Improve error message when UseDbSearch config is disabled 
Replaces Html\Generator::mysqlDie() to avoid calling the exit construct.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-09 14:55:14 -03:00
Maurício Meneghini Fauth
f103bdc1e2
Replace $_REQUEST with ServerRequest in Util::getDbInfo() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-08 00:06:25 -03:00
Maurício Meneghini Fauth
97aac39a40
Remove the sub_part global variable 
It's only used inside Util::getDbInfo() for pagination when not
exporting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 22:06:59 -03:00
Maurício Meneghini Fauth
4044c3bc3c
Remove unnecessary global variable 'data' 
Replaces it with a regular varible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 13:22:46 -03:00
Kamil Tekiela
94ba7d69d2 Remove $params array 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 21:24:10 +00:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00
pistej
1d619c11ad
Ref #17769 - ServerRequest Object instead superglobals - DB controllers (#17854) 
* Use ServerRequest Object instead superglobals - DB controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

* fixed phpstan

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:51:28 -03:00
Jozef Pistej
f089b5ae3d Use ServerRequest Object instead superglobals - DB/structure controllers 
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:05:44 +01:00
Maria Papadopoulou
c7e9d9049a
Ref #17769 - Replaced superglobal in LintController (#17828) 
* Replaced superglobal in LintController

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>
 2022-10-29 14:22:52 -03:00
pistej
932933d357
Use ServerRequest Object instead superglobals - CollationController (#17818) 
* Use ServerRequest Object instead superglobals - CollationController controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-29 10:26:42 -03:00
Maurício Meneghini Fauth
187642560c
Fix Database QbeTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-20 03:07:47 -03:00
Maurício Meneghini Fauth
816bec5493
Merge pull request #17816 from pistej/server-request-db-controllers-1 
Use ServerRequest Object instead superglobals - MultiTableQuery
 2022-10-20 02:02:19 -03:00
Sebastian Walther
d569fe2f05 Use ServerRequestObject to access POST-vars 
Signed-off-by: Sebastian Walther <swalther@complex-it.de>
 2022-10-20 01:23:50 -03:00
Jozef Pistej
5e23fcde36 Use ServerRequest Object instead superglobals - MultiTableQuery controllers 
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-19 22:48:37 +02:00
Kamil Tekiela
27fad8821e Make Routines a dependency 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-18 13:53:15 +01:00
Kamil Tekiela
3e5f101d6f Make Triggers a dependency 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-18 13:53:14 +01:00
Maurício Meneghini Fauth
0f57dfff5b
Merge pull request #17800 from kamil-tekiela/Fix-phpstan-issues-2 
Fix PHPStan issues 2
 2022-10-17 20:32:59 -03:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:41:31 -03:00
Kamil Tekiela
20ce0a8f2f Refactor $GLOBALS['display_page'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-15 20:15:50 +01:00
Luca Perna
40adf927c5
Move superglobals access to controllers (#17794) 
Related to #16276

Signed-off-by: Luca Perna <luca@perna.rocks>
 2022-10-14 08:34:42 -03:00
Arpit-Gulgulia
4302745a74 Fix:#17769 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com> 
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
 2022-10-13 17:36:20 +00:00
Maurício Meneghini Fauth
46fdea0d0e Remove unneeded writing to $_POST in Database\Structure controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-12 18:07:10 -03:00
Maurício Meneghini Fauth
135cd76d3b
Fix exception for invalid db and table names for the privileges page 
Related to #17729

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 20:49:21 -03:00
Solomon Okunuga
0f9c79ebed
Issue #17727 Started refactoring uses of $db and $table (#17729) 
* Issue #17727 Started refactoring uses of $db and $table to use the Objects -
DatabaseName and TableName

Changed uses related to Privileges

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>

* Apply suggestions from code review

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 19:33:36 -03:00
Maurício Meneghini Fauth
c51b5fa437
Use DatabaseName for the newname param in OperationsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-13 20:36:06 -03:00
Maurício Meneghini Fauth
5d74cd134e
Get 'newname' param from ServerRequest object 
Instead of the $_POST superglobal in OperationsController and Operations
classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-12 23:36:07 -03:00
Maurício Meneghini Fauth
d760df02dd
Move DBI getEvents method into the Events class 
DatabaseInterface::getEvents -> Database\Events::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-10 12:48:44 -03:00
Maurício Meneghini Fauth
81192a142b
Move DBI getRoutines method to the Routines class 
DatabaseInterface::getRoutines -> Database\Routines::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-09 23:29:26 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Kamil Tekiela
f471e7f8e3 Clean up autocomplete controller 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-09-07 15:35:56 +01:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
d58057daec
Extract Database\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 17:13:23 -03:00
Maurício Meneghini Fauth
6201c7f2ba
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 13:27:59 -03:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-24 21:35:30 -03:00
Maurício Meneghini Fauth
6dc859cbc2
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-28 15:56:18 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency 
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-27 19:47:31 -03:00